diff mbox series

[ovs-dev] ovs-dpctl-top: open stdin in binary mode

Message ID 376bc10cac7e0041d6c21e74c996cd033128bcb7.1592565629.git.tredaelli@redhat.com
State Superseded
Headers show
Series [ovs-dev] ovs-dpctl-top: open stdin in binary mode | expand

Commit Message

Timothy Redaelli June 19, 2020, 11:20 a.m. UTC 
On Python3 buffering can only be disabled on files opened in binary mode.
---
 utilities/ovs-dpctl-top.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

0-day Robot June 19, 2020, 12:28 p.m. UTC | #1 
Bleep bloop.  Greetings Timothy Redaelli, I am a robot and I have tried out your patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


checkpatch:
ERROR: Author Timothy Redaelli <tredaelli@redhat.com> needs to sign off.
Lines checked: 27, Warnings: 0, Errors: 1


Please check this out.  If you feel there has been an error, please email aconole@redhat.com

Thanks,
0-day Robot
diff mbox series

Patch

diff --git a/utilities/ovs-dpctl-top.in b/utilities/ovs-dpctl-top.in
index fbe6e4f56..97dc12f27 100755
--- a/utilities/ovs-dpctl-top.in
+++ b/utilities/ovs-dpctl-top.in
@@ -1236,7 +1236,7 @@  def flows_script(args):
 
     if (args.flowFiles is None):
         logging.info("reading flows from stdin")
-        ihdl = os.fdopen(sys.stdin.fileno(), 'r', 0)
+        ihdl = os.fdopen(sys.stdin.fileno(), 'rb', 0)
         try:
             flow_db = flows_read(ihdl, flow_db)
         finally: