From patchwork Wed Dec 24 07:41:23 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chander Wu X-Patchwork-Id: 2177197 X-Patchwork-Delegate: i.maximets@samsung.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=bPPys4WP; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.133; helo=smtp2.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4dbkN46PsPz1xty for ; Wed, 24 Dec 2025 18:41:39 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 2A12C4048F; Wed, 24 Dec 2025 07:41:36 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id X1MMO3r83fnx; Wed, 24 Dec 2025 07:41:35 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=2605:bc80:3010:104::8cd3:938; helo=lists.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 2AFA7400A4 Authentication-Results: smtp2.osuosl.org; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=bPPys4WP Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp2.osuosl.org (Postfix) with ESMTPS id 2AFA7400A4; Wed, 24 Dec 2025 07:41:35 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 0BC67C04E8; Wed, 24 Dec 2025 07:41:35 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 0A54AC04E7 for ; Wed, 24 Dec 2025 07:41:33 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id DF2C560AB7 for ; Wed, 24 Dec 2025 07:41:32 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 187qNQtsSdFl for ; Wed, 24 Dec 2025 07:41:32 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2607:f8b0:4864:20::634; helo=mail-pl1-x634.google.com; envelope-from=chandler0149@gmail.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp3.osuosl.org 496BB6067E Authentication-Results: smtp3.osuosl.org; dmarc=pass (p=none dis=none) header.from=gmail.com DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 496BB6067E Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=bPPys4WP Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [IPv6:2607:f8b0:4864:20::634]) by smtp3.osuosl.org (Postfix) with ESMTPS id 496BB6067E for ; Wed, 24 Dec 2025 07:41:32 +0000 (UTC) Received: by mail-pl1-x634.google.com with SMTP id d9443c01a7336-2a0d6f647e2so91703295ad.1 for ; Tue, 23 Dec 2025 23:41:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766562091; x=1767166891; darn=openvswitch.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=hci/f8/z8KmLjEASpNXfMl3FFvBclHcIZESHStxL3kU=; b=bPPys4WPqQoB+GpSdTQ1qxzgsIWTRUczQpzFOw/e+sok8VIANbJ5RkK7Q64k1wsmW0 gyViUB1JbuJuEdhHU32A9oNMJQfy7REzeolXyzKYjxh6ExRq9yWeTZT+lWj4jjBrCxfa VmChCKHAvxAXgR829idAVBqI+TxJ7oEsOAy+DT42pTLQooESVJwFmhZoMYztol90af5H B/7IETZtprCU73Ail4KOs+pUskeaBLjwIKRx5AREVRueSsX+24XvUEVVNzxl8ed2Uqe1 g1JuEk67B0HW/SVWqmUIq/Buf7fEN8kR41zV0/Yii+6XZZMTEPyaNcgc8EhWu/4kvqgd BE+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766562091; x=1767166891; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hci/f8/z8KmLjEASpNXfMl3FFvBclHcIZESHStxL3kU=; b=oQO+KJOgHq8tTN1alqdU+7bPdJEcWME4V6sJjFE2Osq+95eeUZ0xkQPp22fkfMgVpM ZBDovNnyW6VjAPOHyd7CYkNfzfRIhmTQMwkhcDtO4AHsOnVfnXDa1nP2FMadqSgMSMT4 flr/AwO/OTc4nRyePLVS8buMP9wl1WXHvxXeoXF1Yx1tu3HrXSxDD2KBVItluodnWWFI GCKTvziYssaej5cWRB27qAq9FybctZnF6V68o2QhH+sAw7QT6DKf6MPj+GJhthrGX+oL VoO2HD7RCtKC9NiayaXHKgEYijYZUptT36ooKGgfny0CRdyLmnUq+KdApnzJ7/Fc8DrX +a8g== X-Gm-Message-State: AOJu0YzI2j7dEYEFuTuAINS9BTmC1kFOgNRDmxw37b9PBowmxRfB8RzK ucOw7PD+2Hd915lgl6dqGl4lcMzqQ4zXECYYLrq2hoWm0O9YSZkpIDQYpJGHMRonPP0= X-Gm-Gg: AY/fxX7MSz3uFTgMbgFfHkQ3JgEFMKQlSYz7M3GDaN235T3ktL+HXRvCnBP0B2iHC85 JvjuoS08AGZIWTFtoMm4wqyO+evHEgI0DcizUs17paw34cBXBNdMx4L/7py5zMhZUq33TFnXt4E DjmjAWpYlh1c/0Isx1XCxeP7dczeTCCOrJCp9ZzjjS5PuxjoLIjYWb4/A0lFmQ2GrSuDctQk4sm luPXg4xcRIZQ1R3fWyoriigWe0jXhmZnqf3Jwwv1w+FllDKgYaGdpMUu5SagVBSFQYTcp98BKE5 OdvJ3GMEHJIQLMV/m+HBQEpbzoY2U8Ho5+fwOPCk4VKnVelU21qMA84Ro/1sQ36O7c8ncxEfHIt baf+inLrwXt0CtIAn2F+UV0eh4rGX1JUe1IcU0s40AYgYkiG9MtGrI7Bd3VnxQCbsES1sJ44o0z +sT1NHLA+098dzvs0I1NL8oVbsu7llKg== X-Google-Smtp-Source: AGHT+IH39ozCaTRkR+3sUuzir4LnprgdpGumOEUY44qlg3KeQR9fiWwKTUCBJandEWP8raCnWpUMjw== X-Received: by 2002:a05:7022:6194:b0:119:e56b:c73e with SMTP id a92af1059eb24-121722a600amr24458529c88.3.1766562091026; Tue, 23 Dec 2025 23:41:31 -0800 (PST) Received: from dev.localdomain ([142.171.69.238]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1217253c058sm65272020c88.11.2025.12.23.23.41.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Dec 2025 23:41:30 -0800 (PST) From: chandler To: dev@openvswitch.org Cc: chandler Date: Wed, 24 Dec 2025 07:41:23 +0000 Message-Id: <20251224074123.2892113-1-chandler0149@gmail.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 Subject: [ovs-dev] [PATCH] rconn: Fix fd leak when close monitor. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" prior to the patch, the last monitor vconn copied to the deleted one, causing the monitor fd to be leaked, the patch fixes it. Signed-off-by: chandler --- lib/rconn.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/rconn.c b/lib/rconn.c index 4afa21515..3815cfed5 100644 --- a/lib/rconn.c +++ b/lib/rconn.c @@ -1285,6 +1285,7 @@ close_monitor(struct rconn *rc, size_t idx, int retval) VLOG_DBG("%s: closing monitor connection to %s: %s", rconn_get_name(rc), vconn_get_name(rc->monitors[idx]), ovs_retval_to_string(retval)); + vconn_close(rc->monitors[idx]); rc->monitors[idx] = rc->monitors[--rc->n_monitors]; }