diff mbox series

[ovs-dev,v2,04/11] dpif-netdev.at: Rename checksum offloads tests.

Message ID 20251112170420.3155127-5-david.marchand@redhat.com
State Under Review
Headers show
Series Outer UDP checksum optimisations. | expand

Checks

Context Check Description
ovsrobot/apply-robot success apply and check: success
ovsrobot/github-robot-_Build_and_Test success github build: passed

Commit Message

David Marchand Nov. 12, 2025, 5:04 p.m. UTC 
For consistency, rename those tests and use the dpif-netdev namespace.
Keep common userspace offload keywords for ease of use.

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 tests/dpif-netdev.at | 30 ++++++++++++++++++++----------
 1 file changed, 20 insertions(+), 10 deletions(-)

Comments

Mike Pattrick Dec. 1, 2025, 5:38 a.m. UTC | #1 
On Wed, Nov 12, 2025 at 12:04 PM David Marchand <david.marchand@redhat.com>
wrote:

> For consistency, rename those tests and use the dpif-netdev namespace.
> Keep common userspace offload keywords for ease of use.
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>

 I have no objection to this.

Acked-by: Mike Pattrick <mkp@redhat.com>
Kevin Traynor Dec. 5, 2025, 4:15 p.m. UTC | #2 
On 12/11/2025 17:04, David Marchand via dev wrote:
> For consistency, rename those tests and use the dpif-netdev namespace.
> Keep common userspace offload keywords for ease of use.
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>  tests/dpif-netdev.at | 30 ++++++++++++++++++++----------
>  1 file changed, 20 insertions(+), 10 deletions(-)
> 
> diff --git a/tests/dpif-netdev.at b/tests/dpif-netdev.at
> index 10dbbb4c7e..90d7497664 100644
> --- a/tests/dpif-netdev.at
> +++ b/tests/dpif-netdev.at

LGTM
Acked-by: Kevin Traynor <ktraynor@redhat.com>
diff mbox series

Patch

diff --git a/tests/dpif-netdev.at b/tests/dpif-netdev.at
index 10dbbb4c7e..90d7497664 100644
--- a/tests/dpif-netdev.at
+++ b/tests/dpif-netdev.at
@@ -736,7 +736,8 @@  AT_CHECK([test `ovs-vsctl get Interface p2 statistics:tx_q0_packets` -gt 0 -a dn
 OVS_VSWITCHD_STOP
 AT_CLEANUP
 
-AT_SETUP([userspace offload - ip csum offload])
+AT_SETUP([dpif-netdev - ip csum offload])
+AT_KEYWORDS([userspace offload])
 OVS_VSWITCHD_START(
   [add-br br1 -- set bridge br1 datapath-type=dummy -- \
    add-port br1 p1 -- \
@@ -946,7 +947,8 @@  AT_CHECK([tail -n 2 p2.pcap.txt], [0], [expout])
 OVS_VSWITCHD_STOP
 AT_CLEANUP
 
-AT_SETUP([userspace offload - tcp csum offload])
+AT_SETUP([dpif-netdev - tcp csum offload])
+AT_KEYWORDS([userspace offload])
 OVS_VSWITCHD_START(
   [add-br br1 -- set bridge br1 datapath-type=dummy -- \
    add-port br1 p1 -- \
@@ -1120,7 +1122,8 @@  AT_CHECK([ovs-vsctl set Interface p1 options:ol_l4_rx_csum_set_good=false])
 OVS_VSWITCHD_STOP
 AT_CLEANUP
 
-AT_SETUP([userspace offload - tcp csum offload (simple match)])
+AT_SETUP([dpif-netdev - tcp csum offload (simple match)])
+AT_KEYWORDS([userspace offload])
 OVS_VSWITCHD_START(
   [add-br br1 -- set bridge br1 datapath-type=dummy -- \
    add-port br1 p1 -- \
@@ -1196,7 +1199,8 @@  AT_CHECK([ovs-appctl dpif-netdev/pmd-stats-show | grep 'simple match hits'], [0]
 OVS_VSWITCHD_STOP
 AT_CLEANUP
 
-AT_SETUP([userspace offload - udp csum offload])
+AT_SETUP([dpif-netdev - udp csum offload])
+AT_KEYWORDS([userspace offload])
 OVS_VSWITCHD_START(
   [add-br br1 -- set bridge br1 datapath-type=dummy -- \
    add-port br1 p1 -- \
@@ -1370,7 +1374,8 @@  AT_CHECK([ovs-vsctl set Interface p1 options:ol_l4_rx_csum_set_good=false])
 OVS_VSWITCHD_STOP
 AT_CLEANUP
 
-AT_SETUP([userspace offload - IPv6 tcp csum offload])
+AT_SETUP([dpif-netdev - IPv6 tcp csum offload])
+AT_KEYWORDS([userspace offload])
 OVS_VSWITCHD_START(
   [add-br br1 -- set bridge br1 datapath-type=dummy -- \
    add-port br1 p1 -- \
@@ -1544,7 +1549,8 @@  AT_CHECK([ovs-vsctl set Interface p1 options:ol_l4_rx_csum_set_good=false])
 OVS_VSWITCHD_STOP
 AT_CLEANUP
 
-AT_SETUP([userspace offload - IPv6 udp csum offload])
+AT_SETUP([dpif-netdev - IPv6 udp csum offload])
+AT_KEYWORDS([userspace offload])
 OVS_VSWITCHD_START(
   [add-br br1 -- set bridge br1 datapath-type=dummy -- \
    add-port br1 p1 -- \
@@ -1718,7 +1724,8 @@  AT_CHECK([ovs-vsctl set Interface p1 options:ol_l4_rx_csum_set_good=false])
 OVS_VSWITCHD_STOP
 AT_CLEANUP
 
-AT_SETUP([userspace offload - conntrack])
+AT_SETUP([dpif-netdev - conntrack])
+AT_KEYWORDS([userspace offload])
 OVS_VSWITCHD_START(
   [add-br br1 -- set bridge br1 datapath-type=dummy -- \
    add-port br1 p1 -- \
@@ -1932,7 +1939,8 @@  AT_CHECK([ovs-vsctl set Interface p1 options:ol_ip_rx_csum_set_good=false])
 OVS_VSWITCHD_STOP
 AT_CLEANUP
 
-AT_SETUP([userspace offload - tso])
+AT_SETUP([dpif-netdev - tso])
+AT_KEYWORDS([userspace offload])
 OVS_VSWITCHD_START(
   [set Open_vSwitch . other_config:userspace-tso-enable=true -- \
    add-br br1 -- set bridge br1 datapath-type=dummy -- \
@@ -2004,7 +2012,8 @@  AT_CHECK_UNQUOTED([ovs-pcap p2.pcap], [0], [dnl
 OVS_VSWITCHD_STOP
 AT_CLEANUP
 
-AT_SETUP([userspace offload - tunnel tso fallback])
+AT_SETUP([dpif-netdev - tunnel tso fallback])
+AT_KEYWORDS([userspace offload])
 OVS_VSWITCHD_START([set Open_vSwitch . other_config:userspace-tso-enable=true \
                     -- add-br br1 -- set bridge br1 datapath-type=dummy \
                        other-config:hwaddr=aa:55:aa:55:00:03 \
@@ -2245,7 +2254,8 @@  AT_CHECK_UNQUOTED([ovs-pcap p1.pcap | sort], [0], [dnl
 OVS_VSWITCHD_STOP
 AT_CLEANUP
 
-AT_SETUP([userspace offload - tso + check_pkt_len])
+AT_SETUP([dpif-netdev - tso + check_pkt_len])
+AT_KEYWORDS([userspace offload])
 OVS_VSWITCHD_START(
   [set Open_vSwitch . other_config:userspace-tso-enable=true])
 add_of_ports --pcap br0 $(seq 1 3)