| Message ID | 20251030105119.1603148-1-i.maximets@ovn.org |
|---|---|
| State | Accepted |
| Commit | b4c158d9766a5002e18c44f6e59c21b463346c03 |
| Delegated to: | aaron conole |
| Headers | show |
| Series | [ovs-dev] dpif-netlink: Fix potential leak of a malformed meters netlink reply. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/cirrus-robot | success | cirrus build: passed |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
Ilya Maximets <i.maximets@ovn.org> writes: > If netlink transaction returns malformed or otherwise not parsable > reply, it should be freed, as callers will not do that on failure. > > Found while reading the code. > > Fixes: 80738e5f93a7 ("dpif-netlink: Add meter support.") > Signed-off-by: Ilya Maximets <i.maximets@ovn.org> > --- Good catch! Acked-by: Aaron Conole <aconole@redhat.com>
On 11/6/25 5:44 PM, Aaron Conole wrote: > Ilya Maximets <i.maximets@ovn.org> writes: > >> If netlink transaction returns malformed or otherwise not parsable >> reply, it should be freed, as callers will not do that on failure. >> >> Found while reading the code. >> >> Fixes: 80738e5f93a7 ("dpif-netlink: Add meter support.") >> Signed-off-by: Ilya Maximets <i.maximets@ovn.org> >> --- > > Good catch! > > Acked-by: Aaron Conole <aconole@redhat.com> > Thanks! Applied and backported down to 3.3. Best regards, Ilya Maximets.
diff --git a/lib/dpif-netlink.c b/lib/dpif-netlink.c index 2b33d0fa6..c327296ea 100644 --- a/lib/dpif-netlink.c +++ b/lib/dpif-netlink.c @@ -4083,6 +4083,7 @@ dpif_netlink_meter_transact(struct ofpbuf *request, struct ofpbuf **replyp, static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5); VLOG_DBG_RL(&rl, "Kernel module response to meter tranaction is invalid"); + ofpbuf_delete(*replyp); return EINVAL; } return 0;
If netlink transaction returns malformed or otherwise not parsable reply, it should be freed, as callers will not do that on failure. Found while reading the code. Fixes: 80738e5f93a7 ("dpif-netlink: Add meter support.") Signed-off-by: Ilya Maximets <i.maximets@ovn.org> --- lib/dpif-netlink.c | 1 + 1 file changed, 1 insertion(+)