| Message ID | 20250227172340.4120887-2-amorenoz@redhat.com |
|---|---|
| State | Changes Requested |
| Delegated to: | aaron conole |
| Headers | show |
| Series | utilities: upcall_monitor: Monitor drops. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
On 27 Feb 2025, at 18:23, Adrian Moreno wrote: > Without this patch, the chances of events being lost on highly loaded > systems increase. > > Signed-off-by: Adrian Moreno <amorenoz@redhat.com> Thanks for making the changes, this patch looks good to me. Acked-by: Eelco Chaudron <echaudro@redhat.com>
diff --git a/utilities/usdt-scripts/dpif_op_nl_monitor.py b/utilities/usdt-scripts/dpif_op_nl_monitor.py index 22d282328..cac14c695 100755 --- a/utilities/usdt-scripts/dpif_op_nl_monitor.py +++ b/utilities/usdt-scripts/dpif_op_nl_monitor.py @@ -92,7 +92,6 @@ import psutil import re import struct import sys -import time # # Actual eBPF source code @@ -784,7 +783,6 @@ def main(): while 1: try: b.ring_buffer_poll() - time.sleep(0.5) except KeyboardInterrupt: break diff --git a/utilities/usdt-scripts/upcall_cost.py b/utilities/usdt-scripts/upcall_cost.py index 765669585..f3fa8afc3 100755 --- a/utilities/usdt-scripts/upcall_cost.py +++ b/utilities/usdt-scripts/upcall_cost.py @@ -65,7 +65,6 @@ import re import struct import subprocess import sys -import time # # Global definitions @@ -1587,7 +1586,6 @@ def main(): b.ring_buffer_poll() if options.stop != 0 and events_received >= options.stop: break - time.sleep(0.5) except KeyboardInterrupt: break diff --git a/utilities/usdt-scripts/upcall_monitor.py b/utilities/usdt-scripts/upcall_monitor.py index d856547f0..3a758b2d2 100755 --- a/utilities/usdt-scripts/upcall_monitor.py +++ b/utilities/usdt-scripts/upcall_monitor.py @@ -120,7 +120,6 @@ import psutil import re import struct import sys -import time # # Actual eBPF source code @@ -513,7 +512,6 @@ def main(): while 1: try: b.ring_buffer_poll() - time.sleep(0.5) except KeyboardInterrupt: break
Without this patch, the chances of events being lost on highly loaded systems increase. Signed-off-by: Adrian Moreno <amorenoz@redhat.com> --- utilities/usdt-scripts/dpif_op_nl_monitor.py | 2 -- utilities/usdt-scripts/upcall_cost.py | 2 -- utilities/usdt-scripts/upcall_monitor.py | 2 -- 3 files changed, 6 deletions(-)