| Message ID | 20250113075203.1914-1-allen.chen@jaguarmicro.com |
|---|---|
| State | Accepted |
| Commit | 867093679b062af06967bdcb11145ae530db3d14 |
| Delegated to: | aaron conole |
| Headers | show |
| Series | [ovs-dev,v1] dpif-netdev: Modify code comments for function parse_tcp_flags. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
On Mon, Jan 13, 2025 at 03:52:03PM +0800, Allen Chen via dev wrote: > Fixes: e7e9973b80d3 ("dpif-netdev: Forwarding optimization for flows with a simple match") > > Signed-off-by: Allen Chen <allen.chen@jaguarmicro.com> Thanks for the patch, LGTM. Reviewed-by: Adrian Moreno <amorenoz@redhat.com> > --- > lib/flow.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/flow.c b/lib/flow.c > index 9be437524..0eb34892f 100644 > --- a/lib/flow.c > +++ b/lib/flow.c > @@ -1187,7 +1187,7 @@ parse_dl_type(const void **datap, size_t *sizep, ovs_be16 *first_vlan_tci_p) > * If 'packet' is not an Ethernet packet embedding TCP, returns 0. > * 'dl_type_p' will be set only if the 'packet' is an Ethernet packet. > * 'nw_frag_p' will be set only if the 'packet' is an IP packet. > - * 'first_vlan_tci' will be set only if the 'packet' contains vlan header. > + * 'first_vlan_tci_p' will be set only if the 'packet' contains vlan header. > * > * The caller must ensure that 'packet' is at least ETH_HEADER_LEN bytes > * long.'*/ > -- > 2.33.0.windows.2 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev >
Allen Chen via dev <ovs-dev@openvswitch.org> writes: > Fixes: e7e9973b80d3 ("dpif-netdev: Forwarding optimization for flows with a simple match") > > Signed-off-by: Allen Chen <allen.chen@jaguarmicro.com> > --- Thanks Allen and Adrian. I've applied and backported down through 2.17.
diff --git a/lib/flow.c b/lib/flow.c index 9be437524..0eb34892f 100644 --- a/lib/flow.c +++ b/lib/flow.c @@ -1187,7 +1187,7 @@ parse_dl_type(const void **datap, size_t *sizep, ovs_be16 *first_vlan_tci_p) * If 'packet' is not an Ethernet packet embedding TCP, returns 0. * 'dl_type_p' will be set only if the 'packet' is an Ethernet packet. * 'nw_frag_p' will be set only if the 'packet' is an IP packet. - * 'first_vlan_tci' will be set only if the 'packet' contains vlan header. + * 'first_vlan_tci_p' will be set only if the 'packet' contains vlan header. * * The caller must ensure that 'packet' is at least ETH_HEADER_LEN bytes * long.'*/
Fixes: e7e9973b80d3 ("dpif-netdev: Forwarding optimization for flows with a simple match") Signed-off-by: Allen Chen <allen.chen@jaguarmicro.com> --- lib/flow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)