| Message ID | 20250106110917.1276665-4-roid@nvidia.com |
|---|---|
| State | Accepted |
| Delegated to: | Ilya Maximets |
| Headers | show |
| Series | [ovs-dev,1/5] dpdk: Add ovs-appctl dpdk/get-mempool-stats command. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
On 1/6/25 12:09, Roi Dayan via dev wrote: > From: Han Zhou <hzhou@ovn.org> > > This causes the /var/run/openvswitch directory being recreated when > service "stop" encounters failures, which causes container mount > failure after service restart of openvswitch-switch on Ubuntu. > > The same was done in rhel service. See [1]. > > [1] 7a65e5a9252a rhel: let *-ctl handle runtime directory > > Signed-off-by: Han Zhou <hzhou@ovn.org> > Acked-by: Roi Dayan <roid@nvidia.com> > --- > debian/openvswitch-switch.ovsdb-server.service | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/debian/openvswitch-switch.ovsdb-server.service b/debian/openvswitch-switch.ovsdb-server.service > index e0b0a727eede..35654d7059d1 100644 > --- a/debian/openvswitch-switch.ovsdb-server.service > +++ b/debian/openvswitch-switch.ovsdb-server.service > @@ -19,6 +19,3 @@ ExecStop=/usr/share/openvswitch/scripts/ovs-ctl --no-ovs-vswitchd stop > ExecReload=/usr/share/openvswitch/scripts/ovs-ctl --no-ovs-vswitchd \ > --no-record-hostname \ > --no-monitor restart $OVS_CTL_OPTS > -RuntimeDirectory=openvswitch > -RuntimeDirectoryMode=0755 > -RuntimeDirectoryPreserve=yes This seems reasonable to me. Frode, what do you think? Best regards, Ilya Maximets.
On Fri, Jan 10, 2025 at 6:46 PM Ilya Maximets <i.maximets@ovn.org> wrote: > > On 1/6/25 12:09, Roi Dayan via dev wrote: > > From: Han Zhou <hzhou@ovn.org> > > > > This causes the /var/run/openvswitch directory being recreated when > > service "stop" encounters failures, which causes container mount > > failure after service restart of openvswitch-switch on Ubuntu. > > > > The same was done in rhel service. See [1]. > > > > [1] 7a65e5a9252a rhel: let *-ctl handle runtime directory > > > > Signed-off-by: Han Zhou <hzhou@ovn.org> > > Acked-by: Roi Dayan <roid@nvidia.com> > > --- > > debian/openvswitch-switch.ovsdb-server.service | 3 --- > > 1 file changed, 3 deletions(-) > > > > diff --git a/debian/openvswitch-switch.ovsdb-server.service b/debian/openvswitch-switch.ovsdb-server.service > > index e0b0a727eede..35654d7059d1 100644 > > --- a/debian/openvswitch-switch.ovsdb-server.service > > +++ b/debian/openvswitch-switch.ovsdb-server.service > > @@ -19,6 +19,3 @@ ExecStop=/usr/share/openvswitch/scripts/ovs-ctl --no-ovs-vswitchd stop > > ExecReload=/usr/share/openvswitch/scripts/ovs-ctl --no-ovs-vswitchd \ > > --no-record-hostname \ > > --no-monitor restart $OVS_CTL_OPTS > > -RuntimeDirectory=openvswitch > > -RuntimeDirectoryMode=0755 > > -RuntimeDirectoryPreserve=yes > > This seems reasonable to me. > > Frode, what do you think? LGTM. Acked-by: Frode Nordahl <fnordahl@ubuntu.com> -- Frode Nordahl > Best regards, Ilya Maximets. > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 1/14/25 16:18, Frode Nordahl wrote: > On Fri, Jan 10, 2025 at 6:46 PM Ilya Maximets <i.maximets@ovn.org> wrote: >> >> On 1/6/25 12:09, Roi Dayan via dev wrote: >>> From: Han Zhou <hzhou@ovn.org> >>> >>> This causes the /var/run/openvswitch directory being recreated when >>> service "stop" encounters failures, which causes container mount >>> failure after service restart of openvswitch-switch on Ubuntu. >>> >>> The same was done in rhel service. See [1]. >>> >>> [1] 7a65e5a9252a rhel: let *-ctl handle runtime directory >>> >>> Signed-off-by: Han Zhou <hzhou@ovn.org> >>> Acked-by: Roi Dayan <roid@nvidia.com> >>> --- >>> debian/openvswitch-switch.ovsdb-server.service | 3 --- >>> 1 file changed, 3 deletions(-) >>> >>> diff --git a/debian/openvswitch-switch.ovsdb-server.service b/debian/openvswitch-switch.ovsdb-server.service >>> index e0b0a727eede..35654d7059d1 100644 >>> --- a/debian/openvswitch-switch.ovsdb-server.service >>> +++ b/debian/openvswitch-switch.ovsdb-server.service >>> @@ -19,6 +19,3 @@ ExecStop=/usr/share/openvswitch/scripts/ovs-ctl --no-ovs-vswitchd stop >>> ExecReload=/usr/share/openvswitch/scripts/ovs-ctl --no-ovs-vswitchd \ >>> --no-record-hostname \ >>> --no-monitor restart $OVS_CTL_OPTS >>> -RuntimeDirectory=openvswitch >>> -RuntimeDirectoryMode=0755 >>> -RuntimeDirectoryPreserve=yes >> >> This seems reasonable to me. >> >> Frode, what do you think? > > LGTM. > > Acked-by: Frode Nordahl <fnordahl@ubuntu.com> Thanks, Han, Roi and Frode! Applied. And since this one is fixing a real issue, also backported down to 3.3. Best regards, Ilya Maximets.
diff --git a/debian/openvswitch-switch.ovsdb-server.service b/debian/openvswitch-switch.ovsdb-server.service index e0b0a727eede..35654d7059d1 100644 --- a/debian/openvswitch-switch.ovsdb-server.service +++ b/debian/openvswitch-switch.ovsdb-server.service @@ -19,6 +19,3 @@ ExecStop=/usr/share/openvswitch/scripts/ovs-ctl --no-ovs-vswitchd stop ExecReload=/usr/share/openvswitch/scripts/ovs-ctl --no-ovs-vswitchd \ --no-record-hostname \ --no-monitor restart $OVS_CTL_OPTS -RuntimeDirectory=openvswitch -RuntimeDirectoryMode=0755 -RuntimeDirectoryPreserve=yes