diff mbox series

[ovs-dev,3/5] debian: Use PIDFile with systemd.

Message ID 20250106110917.1276665-3-roid@nvidia.com
State Accepted
Commit 3f19558e73510035496fae9d1e779c34e536f93a
Delegated to: Ilya Maximets
Headers show
Series [ovs-dev,1/5] dpdk: Add ovs-appctl dpdk/get-mempool-stats command. | expand

Checks

Context Check Description
ovsrobot/apply-robot success apply and check: success
ovsrobot/github-robot-_Build_and_Test success github build: passed

Commit Message

Roi Dayan Jan. 6, 2025, 11:09 a.m. UTC
This commit adds PIDFile to all systemd service file with Type=forking
in order to always have the correct PID to monitor.

Related commit:
f385abded520 rhel: Use PIDFile on forking systemd service files

Signed-off-by: Roi Dayan <roid@nvidia.com>
Acked-by: Eli Britstein <elibr@nvidia.com>
---
 debian/openvswitch-switch.ovs-vswitchd.service | 1 +
 debian/openvswitch-switch.ovsdb-server.service | 1 +
 2 files changed, 2 insertions(+)

Comments

Ilya Maximets Jan. 14, 2025, 9:40 p.m. UTC | #1
On 1/6/25 12:09, Roi Dayan via dev wrote:
> This commit adds PIDFile to all systemd service file with Type=forking
> in order to always have the correct PID to monitor.
> 
> Related commit:
> f385abded520 rhel: Use PIDFile on forking systemd service files
> 
> Signed-off-by: Roi Dayan <roid@nvidia.com>
> Acked-by: Eli Britstein <elibr@nvidia.com>
> ---
>  debian/openvswitch-switch.ovs-vswitchd.service | 1 +
>  debian/openvswitch-switch.ovsdb-server.service | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/debian/openvswitch-switch.ovs-vswitchd.service b/debian/openvswitch-switch.ovs-vswitchd.service
> index 519d80d8ede1..a4d445b953b6 100644
> --- a/debian/openvswitch-switch.ovs-vswitchd.service
> +++ b/debian/openvswitch-switch.ovs-vswitchd.service
> @@ -11,6 +11,7 @@ DefaultDependencies=no
>  [Service]
>  LimitNOFILE=1048576
>  Type=forking
> +PIDFile=/run/openvswitch/ovs-vswitchd.pid
>  Restart=on-failure
>  Environment=HOME=/var/run/openvswitch
>  EnvironmentFile=-/etc/default/openvswitch-switch
> diff --git a/debian/openvswitch-switch.ovsdb-server.service b/debian/openvswitch-switch.ovsdb-server.service
> index 339665b25558..e0b0a727eede 100644
> --- a/debian/openvswitch-switch.ovsdb-server.service
> +++ b/debian/openvswitch-switch.ovsdb-server.service
> @@ -8,6 +8,7 @@ DefaultDependencies=no
>  [Service]
>  LimitNOFILE=1048576
>  Type=forking
> +PIDFile=/run/openvswitch/ovsdb-server.pid
>  Restart=on-failure
>  EnvironmentFile=-/etc/default/openvswitch-switch
>  ExecStart=/usr/share/openvswitch/scripts/ovs-ctl \

Thanks!  Applied and backported down to 3.3.

Best regards, Ilya Maximets.
diff mbox series

Patch

diff --git a/debian/openvswitch-switch.ovs-vswitchd.service b/debian/openvswitch-switch.ovs-vswitchd.service
index 519d80d8ede1..a4d445b953b6 100644
--- a/debian/openvswitch-switch.ovs-vswitchd.service
+++ b/debian/openvswitch-switch.ovs-vswitchd.service
@@ -11,6 +11,7 @@  DefaultDependencies=no
 [Service]
 LimitNOFILE=1048576
 Type=forking
+PIDFile=/run/openvswitch/ovs-vswitchd.pid
 Restart=on-failure
 Environment=HOME=/var/run/openvswitch
 EnvironmentFile=-/etc/default/openvswitch-switch
diff --git a/debian/openvswitch-switch.ovsdb-server.service b/debian/openvswitch-switch.ovsdb-server.service
index 339665b25558..e0b0a727eede 100644
--- a/debian/openvswitch-switch.ovsdb-server.service
+++ b/debian/openvswitch-switch.ovsdb-server.service
@@ -8,6 +8,7 @@  DefaultDependencies=no
 [Service]
 LimitNOFILE=1048576
 Type=forking
+PIDFile=/run/openvswitch/ovsdb-server.pid
 Restart=on-failure
 EnvironmentFile=-/etc/default/openvswitch-switch
 ExecStart=/usr/share/openvswitch/scripts/ovs-ctl \