| Message ID | 20241226084622.1955-1-allen.chen@jaguarmicro.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [ovs-dev,v1] netdev_offload_dpdk: Fix spelling error in the comments on struct flow_patterns. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | warning | apply and check: warning |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
References: <20241226084622.1955-1-allen.chen@jaguarmicro.com>
Bleep bloop. Greetings Allen Chen, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: The subject, '<area>: <summary>', is over 70 characters, i.e., 80.
Subject: netdev_offload_dpdk: Fix spelling error in the comments on struct flow_patterns.
ERROR: "Fixes" tag is malformed.
Use the following format:
git log -1 --pretty=format:"Fixes: %h (\"%s\")" --abbrev=12 COMMIT_REF
5: Fixes:3d67b2d28e7 ("netdev-dpdk: Move offloading code to a new file")
Please check this out. If you feel there has been an error, please email aconole@redhat.com
Thanks,
0-day Robot
On 26 Dec 2024, at 9:46, Allen Chen via dev wrote: > Fixes:3d67b2d28e7 ("netdev-dpdk: Move offloading code to a new file") > > Signed-off-by: Allen Chen <allen.chen@jaguarmicro.com> > Hi Allen, The patch itself looks good to me. However, the robot complained about two issues on the commit message. Can you fix them, and send a v2? You can manually run ./utilities/checkpatch.py to verify you fixed them to the Robot’s satisfaction. Thanks, Eelco > --- > lib/netdev-offload-dpdk.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/netdev-offload-dpdk.c b/lib/netdev-offload-dpdk.c > index cda0e8d13..b1c848f4d 100644 > --- a/lib/netdev-offload-dpdk.c > +++ b/lib/netdev-offload-dpdk.c > @@ -283,7 +283,7 @@ ufid_to_rte_flow_disassociate(struct ufid_to_rte_flow_data *data) > } > > /* > - * To avoid individual xrealloc calls for each new element, a 'curent_max' > + * To avoid individual xrealloc calls for each new element, a 'current_max' > * is used to keep track of current allocated number of elements. Starts > * by 8 and doubles on each xrealloc call. > */ > -- > 2.33.0.windows.2 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 1/2/25 11:41, Eelco Chaudron wrote: > > > On 26 Dec 2024, at 9:46, Allen Chen via dev wrote: > >> Fixes:3d67b2d28e7 ("netdev-dpdk: Move offloading code to a new file") >> >> Signed-off-by: Allen Chen <allen.chen@jaguarmicro.com> > >> Hi Allen, > > The patch itself looks good to me. However, the robot complained about two issues on the commit message. > > Can you fix them, and send a v2? You can manually run ./utilities/checkpatch.py to verify you fixed them to the Robot’s satisfaction. BTW, besides formatting, the 'Fixes' tag also points to a wrong commit. > > Thanks, > > Eelco > >> --- >> lib/netdev-offload-dpdk.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/lib/netdev-offload-dpdk.c b/lib/netdev-offload-dpdk.c >> index cda0e8d13..b1c848f4d 100644 >> --- a/lib/netdev-offload-dpdk.c >> +++ b/lib/netdev-offload-dpdk.c >> @@ -283,7 +283,7 @@ ufid_to_rte_flow_disassociate(struct ufid_to_rte_flow_data *data) >> } >> >> /* >> - * To avoid individual xrealloc calls for each new element, a 'curent_max' >> + * To avoid individual xrealloc calls for each new element, a 'current_max' >> * is used to keep track of current allocated number of elements. Starts >> * by 8 and doubles on each xrealloc call. >> */ >> -- >> 2.33.0.windows.2
diff --git a/lib/netdev-offload-dpdk.c b/lib/netdev-offload-dpdk.c index cda0e8d13..b1c848f4d 100644 --- a/lib/netdev-offload-dpdk.c +++ b/lib/netdev-offload-dpdk.c @@ -283,7 +283,7 @@ ufid_to_rte_flow_disassociate(struct ufid_to_rte_flow_data *data) } /* - * To avoid individual xrealloc calls for each new element, a 'curent_max' + * To avoid individual xrealloc calls for each new element, a 'current_max' * is used to keep track of current allocated number of elements. Starts * by 8 and doubles on each xrealloc call. */
Fixes:3d67b2d28e7 ("netdev-dpdk: Move offloading code to a new file") Signed-off-by: Allen Chen <allen.chen@jaguarmicro.com> --- lib/netdev-offload-dpdk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)