| Message ID | 20241127153130.1435730-1-david.marchand@redhat.com |
|---|---|
| State | New |
| Delegated to: | Kevin Traynor |
| Headers | show |
| Series | [ovs-dev] netdev-dpdk: Restore outer UDP checksum for Intel nics. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
On Wed, Nov 27, 2024 at 10:31 AM David Marchand <david.marchand@redhat.com> wrote: > > Fixes for Intel drivers are included in DPDK v23.11.2. > > Link: https://git.dpdk.org/dpdk-stable/commit/?id=e8c2cccfbdef > Link: https://git.dpdk.org/dpdk-stable/commit/?id=1970a0ca45f1 > Link: https://git.dpdk.org/dpdk-stable/commit/?id=80c5c9789b73 > Fixes: 0256ee64ed39 ("dpdk: Use DPDK 23.11.2 release.") > Signed-off-by: David Marchand <david.marchand@redhat.com> Good to hear! Acked-by: Mike Pattrick <mkp@redhat.com> > --- > lib/netdev-dpdk.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c > index e454a4a5d3..52f2e15fa2 100644 > --- a/lib/netdev-dpdk.c > +++ b/lib/netdev-dpdk.c > @@ -1353,15 +1353,12 @@ dpdk_eth_dev_init(struct netdev_dpdk *dev) > info.tx_offload_capa &= ~RTE_ETH_TX_OFFLOAD_TCP_CKSUM; > } > > - if (!strcmp(info.driver_name, "net_ice") > - || !strcmp(info.driver_name, "net_i40e") > - || !strcmp(info.driver_name, "net_iavf") > - || !strcmp(info.driver_name, "net_txgbe")) { > + if (!strcmp(info.driver_name, "net_txgbe")) { > /* FIXME: Driver advertises the capability but doesn't seem > * to actually support it correctly. Can remove this once > * the driver is fixed on DPDK side. */ > VLOG_INFO("%s: disabled Tx outer udp checksum offloads for a " > - "net/ice, net/i40e, net/iavf or net/txgbe port.", > + "net/txgbe port.", > netdev_get_name(&dev->up)); > info.tx_offload_capa &= ~RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM; > } > -- > 2.47.0 >
diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index e454a4a5d3..52f2e15fa2 100644 --- a/lib/netdev-dpdk.c +++ b/lib/netdev-dpdk.c @@ -1353,15 +1353,12 @@ dpdk_eth_dev_init(struct netdev_dpdk *dev) info.tx_offload_capa &= ~RTE_ETH_TX_OFFLOAD_TCP_CKSUM; } - if (!strcmp(info.driver_name, "net_ice") - || !strcmp(info.driver_name, "net_i40e") - || !strcmp(info.driver_name, "net_iavf") - || !strcmp(info.driver_name, "net_txgbe")) { + if (!strcmp(info.driver_name, "net_txgbe")) { /* FIXME: Driver advertises the capability but doesn't seem * to actually support it correctly. Can remove this once * the driver is fixed on DPDK side. */ VLOG_INFO("%s: disabled Tx outer udp checksum offloads for a " - "net/ice, net/i40e, net/iavf or net/txgbe port.", + "net/txgbe port.", netdev_get_name(&dev->up)); info.tx_offload_capa &= ~RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM; }
Fixes for Intel drivers are included in DPDK v23.11.2. Link: https://git.dpdk.org/dpdk-stable/commit/?id=e8c2cccfbdef Link: https://git.dpdk.org/dpdk-stable/commit/?id=1970a0ca45f1 Link: https://git.dpdk.org/dpdk-stable/commit/?id=80c5c9789b73 Fixes: 0256ee64ed39 ("dpdk: Use DPDK 23.11.2 release.") Signed-off-by: David Marchand <david.marchand@redhat.com> --- lib/netdev-dpdk.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)