| Message ID | 20241115130959.1145782-1-i.maximets@ovn.org |
|---|---|
| State | Accepted |
| Commit | f0d1608a72d74633050afc3bbdad680660108417 |
| Headers | show |
| Series | [ovs-dev,v2] classifier: Fix the fieldspec comment in the prefix tracking section. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | fail | github build: failed |
| ovsrobot/github-robot-_Build_and_Test | fail | github build: failed |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
On 11/15/24 14:09, Ilya Maximets wrote: > 'fieldspec' was a name in the original version of the patch, but > it was changed to 'prefixes' in the version that got accepted. > > Fixes: 13751fd88c4b ("Classifier: Track address prefixes.") > Signed-off-by: Ilya Maximets <i.maximets@ovn.org> > --- > lib/classifier.h | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/lib/classifier.h b/lib/classifier.h > index f55a2cba9..709b0f156 100644 > --- a/lib/classifier.h > +++ b/lib/classifier.h > @@ -165,9 +165,8 @@ > * separate tries for subsets of rules separated by metadata fields. > * > * Prefix tracking is configured via OVSDB "Flow_Table" table, > - * "fieldspec" column. "fieldspec" is a string map where a "prefix" > - * key tells which fields should be used for prefix tracking. The > - * value of the "prefix" key is a comma separated list of field names. > + * "prefixes" column. "prefixes" is a string set where each element > + * is a name of a field that should be used for prefix tracking. > * > * There is a maximum number of fields that can be enabled for any one > * flow table. Currently this limit is 3. Libreswan failure, so: Recheck-request: github-robot
On 11/15/24 14:47, Ilya Maximets wrote: > On 11/15/24 14:09, Ilya Maximets wrote: >> 'fieldspec' was a name in the original version of the patch, but >> it was changed to 'prefixes' in the version that got accepted. >> >> Fixes: 13751fd88c4b ("Classifier: Track address prefixes.") >> Signed-off-by: Ilya Maximets <i.maximets@ovn.org> >> --- >> lib/classifier.h | 5 ++--- >> 1 file changed, 2 insertions(+), 3 deletions(-) >> >> diff --git a/lib/classifier.h b/lib/classifier.h >> index f55a2cba9..709b0f156 100644 >> --- a/lib/classifier.h >> +++ b/lib/classifier.h >> @@ -165,9 +165,8 @@ >> * separate tries for subsets of rules separated by metadata fields. >> * >> * Prefix tracking is configured via OVSDB "Flow_Table" table, >> - * "fieldspec" column. "fieldspec" is a string map where a "prefix" >> - * key tells which fields should be used for prefix tracking. The >> - * value of the "prefix" key is a comma separated list of field names. >> + * "prefixes" column. "prefixes" is a string set where each element >> + * is a name of a field that should be used for prefix tracking. >> * >> * There is a maximum number of fields that can be enabled for any one >> * flow table. Currently this limit is 3. > > Libreswan failure, so: > > Recheck-request: github-robot Once more... Recheck-request: github-robot
On 15 Nov 2024, at 14:09, Ilya Maximets wrote: > 'fieldspec' was a name in the original version of the patch, but > it was changed to 'prefixes' in the version that got accepted. > > Fixes: 13751fd88c4b ("Classifier: Track address prefixes.") > Signed-off-by: Ilya Maximets <i.maximets@ovn.org> Missed this patch! The changes look good to me. Acked-by: Eelco Chaudron <echaudro@redhat.com>
On 12/2/24 14:18, Eelco Chaudron wrote: > > > On 15 Nov 2024, at 14:09, Ilya Maximets wrote: > >> 'fieldspec' was a name in the original version of the patch, but >> it was changed to 'prefixes' in the version that got accepted. >> >> Fixes: 13751fd88c4b ("Classifier: Track address prefixes.") >> Signed-off-by: Ilya Maximets <i.maximets@ovn.org> > > Missed this patch! The changes look good to me. > > Acked-by: Eelco Chaudron <echaudro@redhat.com> > Thanks! Applied. It wasn't necessary to backport this one, but I was backporting other changes, so took this one down to 3.3 as well. Best regards, Ilya Maximets.
diff --git a/lib/classifier.h b/lib/classifier.h index f55a2cba9..709b0f156 100644 --- a/lib/classifier.h +++ b/lib/classifier.h @@ -165,9 +165,8 @@ * separate tries for subsets of rules separated by metadata fields. * * Prefix tracking is configured via OVSDB "Flow_Table" table, - * "fieldspec" column. "fieldspec" is a string map where a "prefix" - * key tells which fields should be used for prefix tracking. The - * value of the "prefix" key is a comma separated list of field names. + * "prefixes" column. "prefixes" is a string set where each element + * is a name of a field that should be used for prefix tracking. * * There is a maximum number of fields that can be enabled for any one * flow table. Currently this limit is 3.
'fieldspec' was a name in the original version of the patch, but it was changed to 'prefixes' in the version that got accepted. Fixes: 13751fd88c4b ("Classifier: Track address prefixes.") Signed-off-by: Ilya Maximets <i.maximets@ovn.org> --- lib/classifier.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)