| Message ID | 20240705204413.1105558-3-mkp@redhat.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | [ovs-dev,v4,1/3] userspace: Adjust segment size on encapsulation. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | fail | github build: failed |
| ovsrobot/intel-ovs-compilation | fail | test: fail |
On Fri, Jul 5, 2024 at 10:44 PM Mike Pattrick <mkp@redhat.com> wrote: > > Previously the OVS support for checksum/TSO offloading didn't work well > with some network cards that supported VXLAN/Geneve tunnel TSO but not > outer UDP checksums. Now support for this configuration is improved and > we no longer need to disable the VXLAN/Geneve TSO flags from intel > hardware support flags. > > The modification to outer UDP offload is still required pending a future > DPDK release. > > Suggested-by: David Marchand <david.marchand@redhat.com> > Signed-off-by: Mike Pattrick <mkp@redhat.com> Reviewed-by: David Marchand <david.marchand@redhat.com> (for the record, I tested with E810 PF and VF) Thanks Mike!
On 7/5/24 22:44, Mike Pattrick wrote: > Previously the OVS support for checksum/TSO offloading didn't work well > with some network cards that supported VXLAN/Geneve tunnel TSO but not > outer UDP checksums. Now support for this configuration is improved and Could you, please, point out how exactly it is improved or add a link to the changes you're referring to? Best regards, Ilya Maximets.
diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index 02cef6e45..95a78241d 100644 --- a/lib/netdev-dpdk.c +++ b/lib/netdev-dpdk.c @@ -1363,8 +1363,6 @@ dpdk_eth_dev_init(struct netdev_dpdk *dev) "net/ice, net/i40e or net/iavf port.", netdev_get_name(&dev->up)); info.tx_offload_capa &= ~RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM; - info.tx_offload_capa &= ~RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO; - info.tx_offload_capa &= ~RTE_ETH_TX_OFFLOAD_GENEVE_TNL_TSO; } if (info.tx_offload_capa & RTE_ETH_TX_OFFLOAD_IPV4_CKSUM) {
Previously the OVS support for checksum/TSO offloading didn't work well with some network cards that supported VXLAN/Geneve tunnel TSO but not outer UDP checksums. Now support for this configuration is improved and we no longer need to disable the VXLAN/Geneve TSO flags from intel hardware support flags. The modification to outer UDP offload is still required pending a future DPDK release. Suggested-by: David Marchand <david.marchand@redhat.com> Signed-off-by: Mike Pattrick <mkp@redhat.com> --- lib/netdev-dpdk.c | 2 -- 1 file changed, 2 deletions(-)