| Message ID | 20240501111043.357669-1-martin.kalcok@canonical.com |
|---|---|
| State | Accepted |
| Delegated to: | Simon Horman |
| Headers | show |
| Series | [ovs-dev] ovsdb-client: Add missing arg to help for 'dump'. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
| ovsrobot/intel-ovs-compilation | success | test: success |
On Wed, May 01, 2024 at 01:10:43PM +0200, Martin Kalcok wrote: > Help text for 'ovsdb-client dump' does not mention that it's capable > of dumping specific table's contents if user supplies table's name > as a third positional argument. > > Signed-off-by: Martin Kalcok <martin.kalcok@canonical.com> Acked-by: Simon Horman <horms@ovn.org>
On Wed, May 01, 2024 at 01:50:36PM +0100, Simon Horman wrote: > On Wed, May 01, 2024 at 01:10:43PM +0200, Martin Kalcok wrote: > > Help text for 'ovsdb-client dump' does not mention that it's capable > > of dumping specific table's contents if user supplies table's name > > as a third positional argument. > > > > Signed-off-by: Martin Kalcok <martin.kalcok@canonical.com> > > Acked-by: Simon Horman <horms@ovn.org> Hi Martin, I am unsure what has happened, perhaps there is some silly error on my side, but I am unable to see this patch in OVS patchwork [1]. If it is not there, would it be possible to resubmit? [1] https://patchwork.ozlabs.org/project/openvswitch/list/
On 5/3/24 14:16, Simon Horman wrote: > On Wed, May 01, 2024 at 01:50:36PM +0100, Simon Horman wrote: >> On Wed, May 01, 2024 at 01:10:43PM +0200, Martin Kalcok wrote: >>> Help text for 'ovsdb-client dump' does not mention that it's capable >>> of dumping specific table's contents if user supplies table's name >>> as a third positional argument. >>> >>> Signed-off-by: Martin Kalcok <martin.kalcok@canonical.com> >> >> Acked-by: Simon Horman <horms@ovn.org> > > Hi Martin, > > I am unsure what has happened, perhaps there is some silly error on my > side, but I am unable to see this patch in OVS patchwork [1]. > > If it is not there, would it be possible to resubmit? > > [1] https://patchwork.ozlabs.org/project/openvswitch/list/ For some reason it had 'Archived' flag set. I un-archived it: https://patchwork.ozlabs.org/project/openvswitch/patch/20240501111043.357669-1-martin.kalcok@canonical.com/ Best regards, Ilya Maximets.
Hi Simon, It seems that it[0] got archived, not sure how. I unticked the 'archived' box and it should again appear in the the list in OVS patchwork. Thanks for the review. Martin. [0] https://patchwork.ozlabs.org/project/openvswitch/patch/20240501111043.357669-1-martin.kalcok@canonical.com/ On Fri, 2024-05-03 at 13:16 +0100, Simon Horman wrote: > On Wed, May 01, 2024 at 01:50:36PM +0100, Simon Horman wrote: > > On Wed, May 01, 2024 at 01:10:43PM +0200, Martin Kalcok wrote: > > > Help text for 'ovsdb-client dump' does not mention that it's > > > capable > > > of dumping specific table's contents if user supplies table's > > > name > > > as a third positional argument. > > > > > > Signed-off-by: Martin Kalcok <martin.kalcok@canonical.com> > > > > Acked-by: Simon Horman <horms@ovn.org> > > Hi Martin, > > I am unsure what has happened, perhaps there is some silly error on > my > side, but I am unable to see this patch in OVS patchwork [1]. > > If it is not there, would it be possible to resubmit? > > [1] https://patchwork.ozlabs.org/project/openvswitch/list/
On Fri, May 03, 2024 at 02:22:27PM +0200, martin.kalcok@canonical.com wrote: > Hi Simon, > > It seems that it[0] got archived, not sure how. I unticked the > 'archived' box and it should again appear in the the list in OVS > patchwork. > > Thanks for the review. > Martin. > > [0] > https://patchwork.ozlabs.org/project/openvswitch/patch/20240501111043.357669-1-martin.kalcok@canonical.com/ > > On Fri, 2024-05-03 at 13:16 +0100, Simon Horman wrote: > > On Wed, May 01, 2024 at 01:50:36PM +0100, Simon Horman wrote: > > > On Wed, May 01, 2024 at 01:10:43PM +0200, Martin Kalcok wrote: > > > > Help text for 'ovsdb-client dump' does not mention that it's > > > > capable > > > > of dumping specific table's contents if user supplies table's > > > > name > > > > as a third positional argument. > > > > > > > > Signed-off-by: Martin Kalcok <martin.kalcok@canonical.com> > > > > > > Acked-by: Simon Horman <horms@ovn.org> > > > > Hi Martin, > > > > I am unsure what has happened, perhaps there is some silly error on > > my > > side, but I am unable to see this patch in OVS patchwork [1]. > > > > If it is not there, would it be possible to resubmit? > > > > [1] https://patchwork.ozlabs.org/project/openvswitch/list/ Thanks, Sorry for the confusion on my part. Now that I can see it again I have applied it to main. - ovsdb-client: Add missing arg to help for 'dump'. https://github.com/openvswitch/ovs/commit/0940a51b1f5a As a follow-up I'll look at backporting this.
On Tue, May 07, 2024 at 03:16:25PM +0100, Simon Horman wrote: > On Fri, May 03, 2024 at 02:22:27PM +0200, martin.kalcok@canonical.com wrote: ... > Thanks, > > Sorry for the confusion on my part. > Now that I can see it again I have applied it to main. > > - ovsdb-client: Add missing arg to help for 'dump'. > https://github.com/openvswitch/ovs/commit/0940a51b1f5a > > As a follow-up I'll look at backporting this. Hi Martin, In preparing the backports I noticed that dump also supports optional TABLES arguments. Could you consider a follow-up patch to add that to the help text too? In any case, I have prepared and pushed the following backports. branch-3.3: - ovsdb-client: Add missing arg to help for 'dump'. https://github.com/openvswitch/ovs/commit/20ed5491c53f branch-3.2: - ovsdb-client: Add missing arg to help for 'dump'. https://github.com/openvswitch/ovs/commit/a3f9c5ae1b1e branch-3.1: - ovsdb-client: Add missing arg to help for 'dump'. https://github.com/openvswitch/ovs/commit/8b029bd258d5 branch-3.0: - ovsdb-client: Add missing arg to help for 'dump'. https://github.com/openvswitch/ovs/commit/65dcd5f27da0 branch-2.17: - ovsdb-client: Add missing arg to help for 'dump'. https://github.com/openvswitch/ovs/commit/d1a2af7c33fa
Thanks for the merge and backports Simon. On Tue, 2024-05-07 at 17:26 +0100, Simon Horman wrote: > On Tue, May 07, 2024 at 03:16:25PM +0100, Simon Horman wrote: > > On Fri, May 03, 2024 at 02:22:27PM +0200, > > martin.kalcok@canonical.com wrote: > > ... > > > Thanks, > > > > Sorry for the confusion on my part. > > Now that I can see it again I have applied it to main. > > > > - ovsdb-client: Add missing arg to help for 'dump'. > > https://github.com/openvswitch/ovs/commit/0940a51b1f5a > > > > As a follow-up I'll look at backporting this. > > Hi Martin, > > In preparing the backports I noticed that dump also supports optional > TABLES arguments. Could you consider a follow-up patch to add > that to the help text too? You mean COLUMNS argument, right? Yeah, I didn't noticed this earlier. I'll post follow-up patch, thanks. > > In any case, I have prepared and pushed the following backports. > > branch-3.3: > - ovsdb-client: Add missing arg to help for 'dump'. > https://github.com/openvswitch/ovs/commit/20ed5491c53f > > branch-3.2: > - ovsdb-client: Add missing arg to help for 'dump'. > https://github.com/openvswitch/ovs/commit/a3f9c5ae1b1e > > branch-3.1: > - ovsdb-client: Add missing arg to help for 'dump'. > https://github.com/openvswitch/ovs/commit/8b029bd258d5 > > branch-3.0: > - ovsdb-client: Add missing arg to help for 'dump'. > https://github.com/openvswitch/ovs/commit/65dcd5f27da0 > > branch-2.17: > - ovsdb-client: Add missing arg to help for 'dump'. > https://github.com/openvswitch/ovs/commit/d1a2af7c33fa > Martin.
On Fri, May 10, 2024 at 01:31:10PM +0200, martin.kalcok@canonical.com wrote: > Thanks for the merge and backports Simon. > > On Tue, 2024-05-07 at 17:26 +0100, Simon Horman wrote: > > On Tue, May 07, 2024 at 03:16:25PM +0100, Simon Horman wrote: > > > On Fri, May 03, 2024 at 02:22:27PM +0200, > > > martin.kalcok@canonical.com wrote: > > > > ... > > > > > Thanks, > > > > > > Sorry for the confusion on my part. > > > Now that I can see it again I have applied it to main. > > > > > > - ovsdb-client: Add missing arg to help for 'dump'. > > > https://github.com/openvswitch/ovs/commit/0940a51b1f5a > > > > > > As a follow-up I'll look at backporting this. > > > > Hi Martin, > > > > In preparing the backports I noticed that dump also supports optional > > TABLES arguments. Could you consider a follow-up patch to add > > that to the help text too? > > You mean COLUMNS argument, right? Yeah, I didn't noticed this earlier. > I'll post follow-up patch, thanks. Yes, I meant COLUMNS. Thanks.
diff --git a/ovsdb/ovsdb-client.c b/ovsdb/ovsdb-client.c index 7249805ba..cf2ecfd08 100644 --- a/ovsdb/ovsdb-client.c +++ b/ovsdb/ovsdb-client.c @@ -451,8 +451,9 @@ usage(void) " wait until DATABASE reaches STATE " "(\"added\" or \"connected\" or \"removed\")\n" " in DATBASE on SERVER.\n" - "\n dump [SERVER] [DATABASE]\n" - " dump contents of DATABASE on SERVER to stdout\n" + "\n dump [SERVER] [DATABASE] [TABLE]\n" + " dump contents of TABLE (or all tables) in DATABASE on SERVER\n" + " to stdout\n" "\n backup [SERVER] [DATABASE] > SNAPSHOT\n" " dump database contents in the form of a database file\n" "\n [--force] restore [SERVER] [DATABASE] < SNAPSHOT\n"
Help text for 'ovsdb-client dump' does not mention that it's capable of dumping specific table's contents if user supplies table's name as a third positional argument. Signed-off-by: Martin Kalcok <martin.kalcok@canonical.com> --- ovsdb/ovsdb-client.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)