diff mbox series

[ovs-dev,1/1] netdev-dpdk: Improve error print to the user for flow control error.

Message ID 20240417075414.2283175-1-roid@nvidia.com
State Accepted
Delegated to: Simon Horman
Headers show
Series [ovs-dev,1/1] netdev-dpdk: Improve error print to the user for flow control error. | expand

Checks

Context Check Description
ovsrobot/apply-robot success apply and check: success
ovsrobot/github-robot-_Build_and_Test success github build: passed
ovsrobot/intel-ovs-compilation success test: success

Commit Message

Roi Dayan April 17, 2024, 7:54 a.m. UTC 
When failing to get flow control parameters use VLOG_WARN_BUF()
to expose the error string in ovs-vsctl show.

Signed-off-by: Roi Dayan <roid@nvidia.com>
Suggested-by: Simon Horman <horms@ovn.org>
Acked-by: Eli Britstein <elibr@nvidia.com>
---
 lib/netdev-dpdk.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Simon Horman April 23, 2024, 10:26 a.m. UTC | #1 
On Wed, Apr 17, 2024 at 10:54:14AM +0300, Roi Dayan wrote:
> When failing to get flow control parameters use VLOG_WARN_BUF()
> to expose the error string in ovs-vsctl show.
> 
> Signed-off-by: Roi Dayan <roid@nvidia.com>
> Suggested-by: Simon Horman <horms@ovn.org>
> Acked-by: Eli Britstein <elibr@nvidia.com>

Acked-by: Simon Horman <horms@ovn.org>
Simon Horman April 26, 2024, 9:10 a.m. UTC | #2 
On Wed, Apr 17, 2024 at 10:54:14AM +0300, Roi Dayan wrote:
> When failing to get flow control parameters use VLOG_WARN_BUF()
> to expose the error string in ovs-vsctl show.
> 
> Signed-off-by: Roi Dayan <roid@nvidia.com>
> Suggested-by: Simon Horman <horms@ovn.org>
> Acked-by: Eli Britstein <elibr@nvidia.com>

Thanks Roi,

Applied to main.

- netdev-dpdk: Improve error print to the user for flow control error.
  https://github.com/openvswitch/ovs/commit/fb46f5d29ab8
diff mbox series

Patch

diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
index 2111f776810b..32d4193d24af 100644
--- a/lib/netdev-dpdk.c
+++ b/lib/netdev-dpdk.c
@@ -2426,8 +2426,8 @@  netdev_dpdk_set_config(struct netdev *netdev, const struct smap *args,
             }
             err = 0; /* Not fatal. */
         } else {
-            VLOG_WARN("%s: Cannot get flow control parameters: %s",
-                      netdev_get_name(netdev), rte_strerror(err));
+            VLOG_WARN_BUF(errp, "%s: Cannot get flow control parameters: %s",
+                          netdev_get_name(netdev), rte_strerror(err));
         }
         goto out;
     }