From patchwork Sat Apr 13 08:48:26 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jun Gu X-Patchwork-Id: 1923343 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.136; helo=smtp3.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VGnQC0SxCz1yYP for ; Sat, 13 Apr 2024 18:57:53 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 7CD616087D; Sat, 13 Apr 2024 08:57:50 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id Lyy4AIwkMa6v; Sat, 13 Apr 2024 08:57:46 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.9.56; helo=lists.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 8454A60899 Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp3.osuosl.org (Postfix) with ESMTPS id 8454A60899; Sat, 13 Apr 2024 08:57:46 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 47C01C0077; Sat, 13 Apr 2024 08:57:46 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 137EDC0037 for ; Sat, 13 Apr 2024 08:57:44 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id CFB2341767 for ; Sat, 13 Apr 2024 08:57:44 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id wCEhl6gIZVWT for ; Sat, 13 Apr 2024 08:57:39 +0000 (UTC) X-Greylist: delayed 515 seconds by postgrey-1.37 at util1.osuosl.org; Sat, 13 Apr 2024 08:57:38 UTC DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org 8FAA64173A Authentication-Results: smtp4.osuosl.org; dmarc=pass (p=none dis=none) header.from=easystack.cn DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 8FAA64173A Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=45.195.24.17; helo=mail-m2417.xmail.ntesmail.com; envelope-from=jun.gu@easystack.cn; receiver= Received: from mail-m2417.xmail.ntesmail.com (mail-m2417.xmail.ntesmail.com [45.195.24.17]) by smtp4.osuosl.org (Postfix) with ESMTPS id 8FAA64173A for ; Sat, 13 Apr 2024 08:57:38 +0000 (UTC) Received: from localhost.localdomain (unknown [IPV6:2409:8a62:79b:ed10:24be:fa63:4b9b:ba6e]) by smtp.qiye.163.com (Hmail) with ESMTPA id 34398560169; Sat, 13 Apr 2024 16:48:54 +0800 (CST) From: "jun.gu" To: pshelar@ovn.org Date: Sat, 13 Apr 2024 16:48:26 +0800 Message-Id: <20240413084826.52417-1-jun.gu@easystack.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFJQjdXWS1ZQUlXWQ8JGhUIEh9ZQVkaTUNMVk9OGh1MH0gZHUxLTFUZERMWGhIXJBQOD1 lXWRgSC1lBWUlPS0JBQxpNSUFMQhlBHh9KS0FJTxkeQR0aTUhBTxlCGUEZGk0eWVdZFhoPEhUdFF lBWU9LSFVKTU9JTE5VSktLVUpCS0tZBg++ X-HM-Tid: 0a8ed6a53217023dkunm34398560169 X-HM-MType: 1 X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6Py46Cxw6NzcwGS4NK0pONhUM NBkKCgJVSlVKTEpJQkJDSkhPTkNOVTMWGhIXVREOFVUcDjseGggCCA8aGBBVGBVFWVdZEgtZQVlJ T0tCQUMaTUlBTEIZQR4fSktBSU8ZHkEdGk1IQU8ZQhlBGRpNHllXWQgBWUFKT0JPNwY+ Cc: dev@openvswitch.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "jun.gu" Subject: [ovs-dev] [PATCH] net: openvswitch: Check vport name X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" Check vport name from dev_get_by_name, this can avoid to add and remove NIC repeatedly when NIC rename failed at system startup. Signed-off-by: Jun Gu --- net/openvswitch/vport-netdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/openvswitch/vport-netdev.c b/net/openvswitch/vport-netdev.c index 903537a5da22..de8977d7f329 100644 --- a/net/openvswitch/vport-netdev.c +++ b/net/openvswitch/vport-netdev.c @@ -78,7 +78,7 @@ struct vport *ovs_netdev_link(struct vport *vport, const char *name) int err; vport->dev = dev_get_by_name(ovs_dp_get_net(vport->dp), name); - if (!vport->dev) { + if (!vport->dev) || strcmp(name, ovs_vport_name(vport)) { err = -ENODEV; goto error_free_vport; }