| Message ID | 20240410213826.3126397-1-twilson@redhat.com |
|---|---|
| State | Accepted |
| Delegated to: | Simon Horman |
| Headers | show |
| Series | [ovs-dev,1/3] ovsdb-idl: Add python keyword to persistent UUID test. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
| ovsrobot/intel-ovs-compilation | success | test: success |
On Wed, Apr 10, 2024 at 04:38:24PM -0500, Terry Wilson wrote: > The Python persistent UUID tests should have the keyword "python" > added so that TESTSUITEFLAGS="-k python" will not miss testing > them. > > Fixes: 55b9507e6824 ("ovsdb-idl: Add the support to specify the uuid for row insert.") > Signed-off-by: Terry Wilson <twilson@redhat.com> Acked-by: Simon Horman <horms@ovn.org> Tested-by: Simon Horman <horms@ovn.org> ...
On Thu, Apr 11, 2024 at 11:46:01AM +0100, Simon Horman wrote: > On Wed, Apr 10, 2024 at 04:38:24PM -0500, Terry Wilson wrote: > > The Python persistent UUID tests should have the keyword "python" > > added so that TESTSUITEFLAGS="-k python" will not miss testing > > them. > > > > Fixes: 55b9507e6824 ("ovsdb-idl: Add the support to specify the uuid for row insert.") > > Signed-off-by: Terry Wilson <twilson@redhat.com> > > Acked-by: Simon Horman <horms@ovn.org> > Tested-by: Simon Horman <horms@ovn.org> Hi Terry, all, This patch seems to be both correct, and useful without the rest of the series. As the rest of the series seems to need discussion, I have gone ahead and applied only this patch. - ovsdb-idl: Add python keyword to persistent UUID test. https://github.com/openvswitch/ovs/commit/fbade819d2de
diff --git a/tests/ovsdb-idl.at b/tests/ovsdb-idl.at index fb568dd82..c9e36d678 100644 --- a/tests/ovsdb-idl.at +++ b/tests/ovsdb-idl.at @@ -2713,7 +2713,7 @@ m4_define([OVSDB_CHECK_IDL_PERS_UUID_INSERT_C], m4_define([OVSDB_CHECK_IDL_PERS_UUID_INSERT_PY], [AT_SETUP([$1 - Python3]) - AT_KEYWORDS([idl persistent uuid insert]) + AT_KEYWORDS([idl python persistent uuid insert]) OVSDB_START_IDLTEST([], ["$abs_srcdir/idltest.ovsschema"]) AT_CHECK([$PYTHON3 $srcdir/test-ovsdb.py -t10 idl $srcdir/idltest.ovsschema unix:socket $2], [0], [stdout], [stderr])
The Python persistent UUID tests should have the keyword "python" added so that TESTSUITEFLAGS="-k python" will not miss testing them. Fixes: 55b9507e6824 ("ovsdb-idl: Add the support to specify the uuid for row insert.") Signed-off-by: Terry Wilson <twilson@redhat.com> --- tests/ovsdb-idl.at | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)