| Message ID | 20240301-dei-t1-v2-5-10ee89c17b89@ovn.org |
|---|---|
| State | Accepted |
| Delegated to: | Simon Horman |
| Headers | show |
| Series | DEI: Address some instances of master and slave | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | warning | apply and check: warning |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
| ovsrobot/intel-ovs-compilation | success | test: success |
Bleep bloop. Greetings Simon Horman, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 108 characters long (recommended limit is 79) #66 FILE: utilities/usdt-scripts/kernel_delay.rst:591: [(DEBUG)root@localhost home]# ./kernel_delay.py --start-trigger up:bridge_run --stop-trigger ur:bridge_run Lines checked: 73, Warnings: 1, Errors: 0 Please check this out. If you feel there has been an error, please email aconole@redhat.com Thanks, 0-day Robot
On 1 Mar 2024, at 15:50, Simon Horman wrote: > Recently OVS adopted a policy of using the inclusive naming word list v1 > [1, 2]. > > This patch addresses the use of the term master in the context of a > hostname used in documentation of the kernel_delay utility. It does so > by using localhost as the hostname instead. > > [1] df5e5cf ("Documentation: Add section on inclusive language.") > [2] https://inclusivenaming.org/word-lists/ > > Cc: Eelco Chaudron <echaudro@redhat.com> > Signed-off-by: Simon Horman <horms@ovn.org> Thanks for fixing these. Acked-by: Eelco Chaudron <echaudro@redhat.com>
diff --git a/utilities/usdt-scripts/kernel_delay.rst b/utilities/usdt-scripts/kernel_delay.rst index e2e43752d202..0f6f916a71e2 100644 --- a/utilities/usdt-scripts/kernel_delay.rst +++ b/utilities/usdt-scripts/kernel_delay.rst @@ -553,7 +553,7 @@ First the containers need to be started: .. code-block:: console - [core@sno-master ~]$ sudo podman run -it --rm \ + [core@localhost ~]$ sudo podman run -it --rm \ -e PS1='[(DEBUG)\u@\h \W]\$ ' \ --privileged --network=host --pid=host \ -v /lib/modules:/lib/modules:ro \ @@ -562,14 +562,14 @@ First the containers need to be started: -v /:/mnt/rootdir \ quay.io/fedora/fedora:38-x86_64 - [(DEBUG)root@sno-master /]# + [(DEBUG)root@localhost /]# Next add the ``linux_delay.py`` dependencies: .. code-block:: console - [(DEBUG)root@sno-master /]# dnf install -y bcc-tools perl-interpreter \ + [(DEBUG)root@localhost /]# dnf install -y bcc-tools perl-interpreter \ python3-pytz python3-psutil @@ -578,7 +578,7 @@ version: .. code-block:: console - [(DEBUG)root@sno-master home]# rpm -i \ + [(DEBUG)root@localhost home]# rpm -i \ openvswitch2.17-debuginfo-2.17.0-67.el8fdp.x86_64.rpm \ openvswitch2.17-debugsource-2.17.0-67.el8fdp.x86_64.rpm \ kernel-devel-4.18.0-372.41.1.el8_6.x86_64.rpm @@ -588,7 +588,7 @@ Now the tool can be started. Here the above ``bridge_run()`` example is used: .. code-block:: console - [(DEBUG)root@sno-master home]# ./kernel_delay.py --start-trigger up:bridge_run --stop-trigger ur:bridge_run + [(DEBUG)root@localhost home]# ./kernel_delay.py --start-trigger up:bridge_run --stop-trigger ur:bridge_run # Start sampling (trigger@75279117343513) @2023-06-15T11:44:07.628372 (11:44:07 UTC) # Stop sampling (trigger@75279117443980) @2023-06-15T11:44:07.628529 (11:44:07 UTC) # Triggered sample dump, stop-start delta 100,467 ns @2023-06-15T11:44:07.628569 (11:44:07 UTC)
Recently OVS adopted a policy of using the inclusive naming word list v1 [1, 2]. This patch addresses the use of the term master in the context of a hostname used in documentation of the kernel_delay utility. It does so by using localhost as the hostname instead. [1] df5e5cf ("Documentation: Add section on inclusive language.") [2] https://inclusivenaming.org/word-lists/ Cc: Eelco Chaudron <echaudro@redhat.com> Signed-off-by: Simon Horman <horms@ovn.org> --- utilities/usdt-scripts/kernel_delay.rst | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)