| Message ID | 20240213194050.1590143-2-i.maximets@ovn.org |
|---|---|
| State | Superseded |
| Delegated to: | Ilya Maximets |
| Headers | show |
| Series | Windows: Fix OpenSSL build and ovs-pki. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
| ovsrobot/intel-ovs-compilation | success | test: success |
On Tue, Feb 13, 2024 at 08:40:15PM +0100, Ilya Maximets wrote: > We need to know exact linking / compilation errors in order > to fix issues. We could have uploaded it as an artifact, > but it seems easier to just print it out for now. > > Signed-off-by: Ilya Maximets <i.maximets@ovn.org> > --- > .ci/windows-build.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/.ci/windows-build.sh b/.ci/windows-build.sh > index 22994fcdd..e54fbacf4 100644 > --- a/.ci/windows-build.sh > +++ b/.ci/windows-build.sh > @@ -9,7 +9,7 @@ CONFIGURATION=$1 > --prefix=C:/openvswitch/usr --localstatedir=C:/openvswitch/var \ > --sysconfdir=C:/openvswitch/etc --with-pthread=c:/PTHREADS-BUILT/ \ > --enable-ssl --with-openssl=C:/OpenSSL-Win64 \ > - --with-vstudiotarget="${CONFIGURATION}" > + --with-vstudiotarget="${CONFIGURATION}" || (cat config.log && exit 1) FWIIW, I might have written (cat ..; exit 1). As that is how my brain models this situation. But as we are running with set -e, there is no difference either way. Acked-by: Simon Horman <horms@ovn.org>
diff --git a/.ci/windows-build.sh b/.ci/windows-build.sh index 22994fcdd..e54fbacf4 100644 --- a/.ci/windows-build.sh +++ b/.ci/windows-build.sh @@ -9,7 +9,7 @@ CONFIGURATION=$1 --prefix=C:/openvswitch/usr --localstatedir=C:/openvswitch/var \ --sysconfdir=C:/openvswitch/etc --with-pthread=c:/PTHREADS-BUILT/ \ --enable-ssl --with-openssl=C:/OpenSSL-Win64 \ - --with-vstudiotarget="${CONFIGURATION}" + --with-vstudiotarget="${CONFIGURATION}" || (cat config.log && exit 1) make -j4 make datapath_windows_analyze
We need to know exact linking / compilation errors in order to fix issues. We could have uploaded it as an artifact, but it seems easier to just print it out for now. Signed-off-by: Ilya Maximets <i.maximets@ovn.org> --- .ci/windows-build.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)