diff mbox series

[ovs-dev,master/branch-3.3] faq: Update DPDK releases for older branches.

Message ID 20240202124617.106125-5-ktraynor@redhat.com
State Accepted
Delegated to: Kevin Traynor
Headers show
Series [ovs-dev,master/branch-3.3] faq: Update DPDK releases for older branches. | expand

Checks

Context Check Description
ovsrobot/apply-robot success apply and check: success
ovsrobot/github-robot-_Build_and_Test success github build: passed
ovsrobot/intel-ovs-compilation fail test: fail

Commit Message

Kevin Traynor Feb. 2, 2024, 12:46 p.m. UTC
Branches 2.17/3.0/3.1/3.2 are using newer DPDK LTS releases.

Update the faq.

Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
---
 Documentation/faq/releases.rst | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Simon Horman Feb. 5, 2024, 11 a.m. UTC | #1
On Fri, Feb 02, 2024 at 12:46:17PM +0000, Kevin Traynor wrote:
> Branches 2.17/3.0/3.1/3.2 are using newer DPDK LTS releases.
> 
> Update the faq.
> 
> Signed-off-by: Kevin Traynor <ktraynor@redhat.com>

Acked-by: Simon Horman <horms@ovn.org>
Eelco Chaudron Feb. 5, 2024, 11:37 a.m. UTC | #2
On 2 Feb 2024, at 13:46, Kevin Traynor wrote:

> Branches 2.17/3.0/3.1/3.2 are using newer DPDK LTS releases.
>
> Update the faq.
>
> Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
> ---

Thanks for getting all DPDK packages upgraded. The changes look good to me. Did not run the GitHub actions, but assume they are fine.

Acked-by: Eelco Chaudron <echaudro@redhat.com>
Ilya Maximets Feb. 6, 2024, 12:28 p.m. UTC | #3
On 2/2/24 13:46, Kevin Traynor wrote:
> Branches 2.17/3.0/3.1/3.2 are using newer DPDK LTS releases.
> 
> Update the faq.
> 
> Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
> ---
>  Documentation/faq/releases.rst | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/faq/releases.rst b/Documentation/faq/releases.rst
> index 3a8387f84..49b987b61 100644
> --- a/Documentation/faq/releases.rst
> +++ b/Documentation/faq/releases.rst
> @@ -217,8 +217,8 @@ Q: What DPDK version does each Open vSwitch release work with?
>      2.15.x       20.11.6
>      2.16.x       20.11.6
> -    2.17.x       21.11.5
> -    3.0.x        21.11.5
> -    3.1.x        22.11.3
> -    3.2.x        22.11.3
> +    2.17.x       21.11.6
> +    3.0.x        21.11.6
> +    3.1.x        22.11.4
> +    3.2.x        22.11.4
>      3.3.x        23.11
>      ============ ========

Hi, Kevin.  Thanks for the patches!

I didn't test them, but LGTM.  For all DPDK update patches:

Acked-by: Ilya Maximets <i.maximets@ovn.org>

P.S.: the 'master/branch-3.3' tag is likely confusing for bots,
      it's better to send separate patches next time, or just
      not specify the branch at all and add a footnote that
      it should be applied to branch-3.3 as well.

Best regards, Ilya Maximets.
Kevin Traynor Feb. 6, 2024, 1:40 p.m. UTC | #4
On 06/02/2024 12:28, Ilya Maximets wrote:
> On 2/2/24 13:46, Kevin Traynor wrote:
>> Branches 2.17/3.0/3.1/3.2 are using newer DPDK LTS releases.
>>
>> Update the faq.
>>
>> Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
>> ---
>>  Documentation/faq/releases.rst | 8 ++++----
>>  1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/Documentation/faq/releases.rst b/Documentation/faq/releases.rst
>> index 3a8387f84..49b987b61 100644
>> --- a/Documentation/faq/releases.rst
>> +++ b/Documentation/faq/releases.rst
>> @@ -217,8 +217,8 @@ Q: What DPDK version does each Open vSwitch release work with?
>>      2.15.x       20.11.6
>>      2.16.x       20.11.6
>> -    2.17.x       21.11.5
>> -    3.0.x        21.11.5
>> -    3.1.x        22.11.3
>> -    3.2.x        22.11.3
>> +    2.17.x       21.11.6
>> +    3.0.x        21.11.6
>> +    3.1.x        22.11.4
>> +    3.2.x        22.11.4
>>      3.3.x        23.11
>>      ============ ========
> 
> Hi, Kevin.  Thanks for the patches!
> 
> I didn't test them, but LGTM.  For all DPDK update patches:
> 
> Acked-by: Ilya Maximets <i.maximets@ovn.org>
> 
> P.S.: the 'master/branch-3.3' tag is likely confusing for bots,
>       it's better to send separate patches next time, or just
>       not specify the branch at all and add a footnote that
>       it should be applied to branch-3.3 as well.
> 

Noted, thanks. It seems to report for a different patch in the email [0]
? The patches also didn't apply for 3.2 and 3.0 for
intel-ovs-compilation tests, but I can see that is fine in the GHA tests
and locally.

Perhaps chaining patches for different branches caused it some confusion
as well.

[0]
https://mail.openvswitch.org/pipermail/ovs-build/2024-February/036673.html

> Best regards, Ilya Maximets.
>
Kevin Traynor Feb. 7, 2024, 4:33 p.m. UTC | #5
On 06/02/2024 12:28, Ilya Maximets wrote:
> On 2/2/24 13:46, Kevin Traynor wrote:
>> Branches 2.17/3.0/3.1/3.2 are using newer DPDK LTS releases.
>>
>> Update the faq.
>>
>> Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
>> ---
>>  Documentation/faq/releases.rst | 8 ++++----
>>  1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/Documentation/faq/releases.rst b/Documentation/faq/releases.rst
>> index 3a8387f84..49b987b61 100644
>> --- a/Documentation/faq/releases.rst
>> +++ b/Documentation/faq/releases.rst
>> @@ -217,8 +217,8 @@ Q: What DPDK version does each Open vSwitch release work with?
>>      2.15.x       20.11.6
>>      2.16.x       20.11.6
>> -    2.17.x       21.11.5
>> -    3.0.x        21.11.5
>> -    3.1.x        22.11.3
>> -    3.2.x        22.11.3
>> +    2.17.x       21.11.6
>> +    3.0.x        21.11.6
>> +    3.1.x        22.11.4
>> +    3.2.x        22.11.4
>>      3.3.x        23.11
>>      ============ ========
> 
> Hi, Kevin.  Thanks for the patches!
> 
> I didn't test them, but LGTM.  For all DPDK update patches:
> 
> Acked-by: Ilya Maximets <i.maximets@ovn.org>
> 
> P.S.: the 'master/branch-3.3' tag is likely confusing for bots,
>       it's better to send separate patches next time, or just
>       not specify the branch at all and add a footnote that
>       it should be applied to branch-3.3 as well.
> 
> Best regards, Ilya Maximets.
> 

Thanks Simon, Eelco and Ilya. These are applied to the branches now.
diff mbox series

Patch

diff --git a/Documentation/faq/releases.rst b/Documentation/faq/releases.rst
index 3a8387f84..49b987b61 100644
--- a/Documentation/faq/releases.rst
+++ b/Documentation/faq/releases.rst
@@ -217,8 +217,8 @@  Q: What DPDK version does each Open vSwitch release work with?
     2.15.x       20.11.6
     2.16.x       20.11.6
-    2.17.x       21.11.5
-    3.0.x        21.11.5
-    3.1.x        22.11.3
-    3.2.x        22.11.3
+    2.17.x       21.11.6
+    3.0.x        21.11.6
+    3.1.x        22.11.4
+    3.2.x        22.11.4
     3.3.x        23.11
     ============ ========