diff mbox series

[ovs-dev] dpif-netdev: Increase MAX_RECIRC_DEPTH to 8.

Message ID 20240126132041.24299-1-jmeng@redhat.com
State Superseded, archived
Headers show
Series [ovs-dev] dpif-netdev: Increase MAX_RECIRC_DEPTH to 8. | expand

Checks

Context Check Description
ovsrobot/apply-robot success apply and check: success
ovsrobot/github-robot-_Build_and_Test success github build: passed
ovsrobot/intel-ovs-compilation success test: success

Commit Message

Jakob Meng Jan. 26, 2024, 1:20 p.m. UTC 
From: Jakob Meng <code@jakobmeng.de>

In a scenario where OVN does load balancing and then SNAT with a OVS
userspace datapath [0], the recirc_depth may be greater than 6. In
that case, ovs-vswitchd might drop packets and raise warnings:

  dpif_netdev|WARN|Packet dropped. Max recirculation depth exceeded.

Increasing MAX_RECIRC_DEPTH to 8 solves this issue.

[0] https://github.com/ovn-org/ovn/blob/dd5cd73e3df1bfb1a215cb45d1e2e03eff1d049a/tests/system-ovn-kmod.at#L740

Reported-at: https://issues.redhat.com/browse/FDP-251
Signed-off-by: Jakob Meng <code@jakobmeng.de>
---
 ovs/lib/dpif-netdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/ovs/lib/dpif-netdev.c b/ovs/lib/dpif-netdev.c
index c1981137f9..46e24d204d 100644
--- a/ovs/lib/dpif-netdev.c
+++ b/ovs/lib/dpif-netdev.c
@@ -99,7 +99,7 @@  VLOG_DEFINE_THIS_MODULE(dpif_netdev);
 
 #define FLOW_DUMP_MAX_BATCH 50
 /* Use per thread recirc_depth to prevent recirculation loop. */
-#define MAX_RECIRC_DEPTH 6
+#define MAX_RECIRC_DEPTH 8
 DEFINE_STATIC_PER_THREAD_DATA(uint32_t, recirc_depth, 0)
 
 /* Use instant packet send by default. */