diff mbox series

[ovs-dev,01/22] ovsdb-server.at: Enbale debug logs in active-backup tests.

Message ID 20231214010431.1664005-2-i.maximets@ovn.org
State Accepted
Commit 7c3df36762ba95c40698bf44e5be905c050b5730
Delegated to: Ilya Maximets
Headers show
Series [ovs-dev,01/22] ovsdb-server.at: Enbale debug logs in active-backup tests. | expand

Checks

Context Check Description
ovsrobot/apply-robot success apply and check: success
ovsrobot/github-robot-_Build_and_Test success github build: passed
ovsrobot/intel-ovs-compilation success test: success

Commit Message

Ilya Maximets Dec. 14, 2023, 1:04 a.m. UTC 
It's almost impossible to debug test failures without them.

Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
---
 tests/ovsdb-server.at | 20 ++++++++++++++++----
 1 file changed, 16 insertions(+), 4 deletions(-)

Comments

Mike Pattrick Jan. 2, 2024, 3:03 p.m. UTC | #1 
On Wed, Dec 13, 2023 at 8:05 PM Ilya Maximets <i.maximets@ovn.org> wrote:
>
> It's almost impossible to debug test failures without them.
>
> Signed-off-by: Ilya Maximets <i.maximets@ovn.org>

Acked-by: Mike Pattrick <mkp@redhat.com>
diff mbox series

Patch

diff --git a/tests/ovsdb-server.at b/tests/ovsdb-server.at
index d36c3c117..35286db37 100644
--- a/tests/ovsdb-server.at
+++ b/tests/ovsdb-server.at
@@ -1830,9 +1830,14 @@  replication_schema > schema
 AT_CHECK([ovsdb-tool create db1 schema], [0], [stdout], [ignore])
 AT_CHECK([ovsdb-tool create db2 schema], [0], [stdout], [ignore])
 
-AT_CHECK([ovsdb-server --detach --no-chdir --log-file=ovsdb-server1.log --pidfile --remote=punix:db.sock db1], [0], [ignore], [ignore])
+AT_CHECK([ovsdb-server -vfile --detach --no-chdir \
+            --log-file=ovsdb-server1.log --pidfile --remote=punix:db.sock db1],
+         [0], [ignore], [ignore])
 
-AT_CHECK([ovsdb-server --detach --no-chdir --log-file=ovsdb-server2.log --pidfile=2.pid --remote=punix:db2.sock --unixctl=unixctl2 db2], [0], [ignore], [ignore])
+AT_CHECK([ovsdb-server -vfile --detach --no-chdir \
+            --log-file=ovsdb-server2.log --pidfile=2.pid \
+            --remote=punix:db2.sock --unixctl=unixctl2 db2],
+         [0], [ignore], [ignore])
 
 dnl Try to connect without specifying the active server.
 AT_CHECK([ovs-appctl -t "`pwd`"/unixctl2 ovsdb-server/connect-active-ovsdb-server], [0],
@@ -2153,9 +2158,16 @@  AT_CHECK([ovsdb-tool transact db2 \
 
 dnl Start both 'db1' and 'db2'.
 on_exit 'kill `cat *.pid`'
-AT_CHECK([ovsdb-server --detach --no-chdir --log-file=ovsdb-server1.log --pidfile --remote=punix:db.sock --unixctl="`pwd`"/unixctl db1 --active ], [0], [ignore], [ignore])
+AT_CHECK([ovsdb-server -vfile --detach --no-chdir \
+            --log-file=ovsdb-server1.log --pidfile \
+            --remote=punix:db.sock \
+            --unixctl="$(pwd)"/unixctl db1 --active ],
+         [0], [ignore], [ignore])
 
-AT_CHECK([ovsdb-server --detach --no-chdir --log-file=ovsdb-server2.log --pidfile=2.pid --remote=punix:db2.sock --unixctl="`pwd`"/unixctl2 db2], [0], [ignore], [ignore])
+AT_CHECK([ovsdb-server -vfile --detach --no-chdir \
+            --log-file=ovsdb-server2.log --pidfile=2.pid \
+            --remote=punix:db2.sock --unixctl="$(pwd)"/unixctl2 db2],
+         [0], [ignore], [ignore])
 
 OVS_WAIT_UNTIL([ovs-appctl -t "`pwd`"/unixctl ovsdb-server/sync-status |grep active])
 OVS_WAIT_UNTIL([ovs-appctl -t "`pwd`"/unixctl2 ovsdb-server/sync-status |grep active])