diff mbox series

[ovs-dev,dpdk-latest] system-dpdk: Ignore net/ice error log about QinQ offloading.

Message ID 20231205083640.2654362-1-david.marchand@redhat.com
State Accepted
Delegated to: Kevin Traynor
Headers show
Series [ovs-dev,dpdk-latest] system-dpdk: Ignore net/ice error log about QinQ offloading. | expand

Checks

Context Check Description
ovsrobot/apply-robot success apply and check: success
ovsrobot/intel-ovs-compilation success test: success
ovsrobot/github-robot-_Build_and_Test success github build: passed

Commit Message

David Marchand Dec. 5, 2023, 8:36 a.m. UTC
The net/ice DPDK driver complains with an ERROR level log message if the
hw firmware only supports SVM (Single Vlan Mode).
DVM (Dual Vlan mode) seems required when using QinQ offloading.
OVS does not care about this offloading feature and configures nothing
on that topic.

While seeing this error log, some manual tests show that
untagged/tagged/"double" tagged packets (with 0x8100 ethertype)
are still received/transmitted fine.

Ignore this log waiting for a fix on the DPDK side.

Link: https://bugs.dpdk.org/show_bug.cgi?id=1331
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 tests/system-dpdk-macros.at | 1 +
 1 file changed, 1 insertion(+)

Comments

Eelco Chaudron Dec. 5, 2023, 9:25 a.m. UTC | #1
On 5 Dec 2023, at 9:36, David Marchand wrote:

> The net/ice DPDK driver complains with an ERROR level log message if the
> hw firmware only supports SVM (Single Vlan Mode).
> DVM (Dual Vlan mode) seems required when using QinQ offloading.
> OVS does not care about this offloading feature and configures nothing
> on that topic.
>
> While seeing this error log, some manual tests show that
> untagged/tagged/"double" tagged packets (with 0x8100 ethertype)
> are still received/transmitted fine.
>
> Ignore this log waiting for a fix on the DPDK side.
>
> Link: https://bugs.dpdk.org/show_bug.cgi?id=1331
> Signed-off-by: David Marchand <david.marchand@redhat.com>

Thanks for getting to the bottom of this!

Acked-by: Eelco Chaudron <echaudro@redhat.com>
Kevin Traynor Dec. 5, 2023, 2:15 p.m. UTC | #2
On 05/12/2023 08:36, David Marchand wrote:
> The net/ice DPDK driver complains with an ERROR level log message if the
> hw firmware only supports SVM (Single Vlan Mode).
> DVM (Dual Vlan mode) seems required when using QinQ offloading.
> OVS does not care about this offloading feature and configures nothing
> on that topic.
> 
> While seeing this error log, some manual tests show that
> untagged/tagged/"double" tagged packets (with 0x8100 ethertype)
> are still received/transmitted fine.
> 
> Ignore this log waiting for a fix on the DPDK side.
> 
> Link: https://bugs.dpdk.org/show_bug.cgi?id=1331
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>   tests/system-dpdk-macros.at | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/tests/system-dpdk-macros.at b/tests/system-dpdk-macros.at
> index dcdfa55741..c011487541 100644
> --- a/tests/system-dpdk-macros.at
> +++ b/tests/system-dpdk-macros.at
> @@ -86,6 +86,7 @@ $1";/does not exist. The Open vSwitch kernel module is probably not loaded./d
>   /does not support MTU configuration,/d
>   /EAL: No \(available\|free\) .*hugepages reported/d
>   /Failed to enable flow control/d
> +/ice_vsi_config_outer_vlan_stripping(): Single VLAN mode (SVM) does not support qinq/d
>   /Rx checksum offload is not supported on/d
>   /TELEMETRY: No legacy callbacks, legacy socket not created/d"])
>   ])

Thanks David

Acked-by: Kevin Traynor <ktraynor@redhat.com>
diff mbox series

Patch

diff --git a/tests/system-dpdk-macros.at b/tests/system-dpdk-macros.at
index dcdfa55741..c011487541 100644
--- a/tests/system-dpdk-macros.at
+++ b/tests/system-dpdk-macros.at
@@ -86,6 +86,7 @@  $1";/does not exist. The Open vSwitch kernel module is probably not loaded./d
 /does not support MTU configuration,/d
 /EAL: No \(available\|free\) .*hugepages reported/d
 /Failed to enable flow control/d
+/ice_vsi_config_outer_vlan_stripping(): Single VLAN mode (SVM) does not support qinq/d
 /Rx checksum offload is not supported on/d
 /TELEMETRY: No legacy callbacks, legacy socket not created/d"])
 ])