| Message ID | 20231128074622.42661-2-amusil@redhat.com |
|---|---|
| State | Accepted |
| Delegated to: | Ilya Maximets |
| Headers | show |
| Series | [ovs-dev,1/2] ofp-ct: Return error for unknown property in CT flush. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
| ovsrobot/intel-ovs-compilation | success | test: success |
On 11/28/23 08:46, Ales Musil wrote: > Change the ct-flush and ct-flush-zone to RW > as they do in fact modify the state. > > Fixes: 2a7c4805a76d ("Add OpenFlow command to flush conntrack table entries.") > Fixes: 08146bf7d9b4 ("openflow: Add extension to flush CT by generic match.") > Signed-off-by: Ales Musil <amusil@redhat.com> > --- > utilities/ovs-ofctl.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/utilities/ovs-ofctl.c b/utilities/ovs-ofctl.c > index 0a382f336..2d413e239 100644 > --- a/utilities/ovs-ofctl.c > +++ b/utilities/ovs-ofctl.c > @@ -5144,10 +5144,10 @@ static const struct ovs_cmdl_command all_commands[] = { > 1, 1, ofctl_dump_ipfix_flow, OVS_RO }, > > { "ct-flush-zone", "switch zone", > - 2, 2, ofctl_ct_flush_zone, OVS_RO }, > + 2, 2, ofctl_ct_flush_zone, OVS_RW }, > > { "ct-flush", "switch [zone=N] [ct-orig-tuple [ct-reply-tuple]]", > - 1, 4, ofctl_ct_flush, OVS_RO }, > + 1, 4, ofctl_ct_flush, OVS_RW }, > > { "ofp-parse", "file", > 1, 1, ofctl_ofp_parse, OVS_RW }, Hi, Ales. The subject of this patch should say 'ovs-ofctl' and not 'ovs-vsctl'. I fixed that and applied the change (only this one patch). Also backported down to 2.17 with necessary adjustments. Best regards, Ilya Maximets.
diff --git a/utilities/ovs-ofctl.c b/utilities/ovs-ofctl.c index 0a382f336..2d413e239 100644 --- a/utilities/ovs-ofctl.c +++ b/utilities/ovs-ofctl.c @@ -5144,10 +5144,10 @@ static const struct ovs_cmdl_command all_commands[] = { 1, 1, ofctl_dump_ipfix_flow, OVS_RO }, { "ct-flush-zone", "switch zone", - 2, 2, ofctl_ct_flush_zone, OVS_RO }, + 2, 2, ofctl_ct_flush_zone, OVS_RW }, { "ct-flush", "switch [zone=N] [ct-orig-tuple [ct-reply-tuple]]", - 1, 4, ofctl_ct_flush, OVS_RO }, + 1, 4, ofctl_ct_flush, OVS_RW }, { "ofp-parse", "file", 1, 1, ofctl_ofp_parse, OVS_RW },
Change the ct-flush and ct-flush-zone to RW as they do in fact modify the state. Fixes: 2a7c4805a76d ("Add OpenFlow command to flush conntrack table entries.") Fixes: 08146bf7d9b4 ("openflow: Add extension to flush CT by generic match.") Signed-off-by: Ales Musil <amusil@redhat.com> --- utilities/ovs-ofctl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)