Message ID | 20231120155650.36021-8-david.marchand@redhat.com |
---|---|
State | Accepted |
Delegated to: | Simon Horman |
Headers | show |
Series | [ovs-dev,v9,01/11] system-dpdk: Introduce helpers for testpmd. | expand |
Context | Check | Description |
---|---|---|
ovsrobot/apply-robot | success | apply and check: success |
ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
ovsrobot/intel-ovs-compilation | success | test: success |
On 20 Nov 2023, at 16:56, David Marchand wrote: > Adding those grep gives enough time to OVS to be ready to connect with > the testpmd virtio-user port instantiated afterward. > > Fixes: bf47829116a8 ("tests: Add OVS-DPDK MTU unit tests.") > Signed-off-by: David Marchand <david.marchand@redhat.com> This looks fine, as it gets removed in the next patch. Acked-by: Eelco Chaudron <echaudro@redhat.com>
diff --git a/tests/system-dpdk.at b/tests/system-dpdk.at index c125d8051f..b7ae4af406 100644 --- a/tests/system-dpdk.at +++ b/tests/system-dpdk.at @@ -813,6 +813,10 @@ AT_CHECK([ovs-vsctl set Interface dpdkvhostuserclient0 mtu_request=9702]) AT_CHECK([ovs-vsctl show], [], [stdout]) sleep 2 +AT_CHECK([grep "VHOST_CONFIG: ($OVS_RUNDIR/dpdkvhostclient0) vhost-user client: socket created" ovs-vswitchd.log], [], [stdout]) +AT_CHECK([grep "vHost User device 'dpdkvhostuserclient0' created in 'client' mode, using client socket" ovs-vswitchd.log], [], [stdout]) +AT_CHECK([grep "VHOST_CONFIG: ($OVS_RUNDIR/dpdkvhostclient0) reconnecting..." ovs-vswitchd.log], [], [stdout]) + OVS_DPDK_START_TESTPMD([--vdev="net_virtio_user,path=$OVS_RUNDIR/dpdkvhostclient0,server=1"]) OVS_WAIT_UNTIL([grep "virtio is now ready for processing" ovs-vswitchd.log])
Adding those grep gives enough time to OVS to be ready to connect with the testpmd virtio-user port instantiated afterward. Fixes: bf47829116a8 ("tests: Add OVS-DPDK MTU unit tests.") Signed-off-by: David Marchand <david.marchand@redhat.com> --- Changes since v8: - added this patch for random failures observed on my laptop, --- tests/system-dpdk.at | 4 ++++ 1 file changed, 4 insertions(+)