diff mbox series

[ovs-dev,v2,2/4] Don't convert EAGAIN to EPROTO for unix sockets

Message ID 20231118010703.4154866-3-ihrachys@redhat.com
State Changes Requested
Delegated to: Simon Horman
Headers show
Series Improve unixctl AF_UNIX backlog handling | expand

Checks

Context Check Description
ovsrobot/apply-robot warning apply and check: warning
ovsrobot/github-robot-_Build_and_Test success github build: passed
ovsrobot/intel-ovs-compilation success test: success

Commit Message

Ihar Hrachyshka Nov. 18, 2023, 1:07 a.m. UTC 
Unix sockets also have listener backlog. Returning EAGAIN is valid to
allow the caller handle the non-blocking temporary failure to connect()
gracefully.

Signed-off-by: Ihar Hrachyshka <ihrachys@redhat.com>
---
 lib/socket-util-unix.c | 3 ---
 1 file changed, 3 deletions(-)
diff mbox series

Patch

diff --git a/lib/socket-util-unix.c b/lib/socket-util-unix.c
index 59f63fcce..0053a61b1 100644
--- a/lib/socket-util-unix.c
+++ b/lib/socket-util-unix.c
@@ -376,9 +376,6 @@  make_unix_socket(int style, bool nonblock,
     return fd;
 
 error:
-    if (error == EAGAIN) {
-        error = EPROTO;
-    }
     if (bind_path) {
         fatal_signal_unlink_file_now(bind_path);
     }