diff mbox series

[ovs-dev,v3,1/2] checkpatch: Fix personal word list storage.

Message ID 20231113130033.868689-2-roid@nvidia.com
State Changes Requested
Headers show
Series improve checkpatch spell checker | expand

Checks

Context Check Description
ovsrobot/apply-robot success apply and check: success
ovsrobot/intel-ovs-compilation success test: success
ovsrobot/github-robot-_Build_and_Test success github build: passed

Commit Message

Roi Dayan Nov. 13, 2023, 1 p.m. UTC
From: Gaetan Rivet <gaetanr@nvidia.com>

The enchant dictionary synchronizes additions to the source file.
Keep the two word source separate by adding the extra words only
to the current session.

Signed-off-by: Gaetan Rivet <gaetanr@nvidia.com>
Acked-by: Roi Dayan <roid@nvidia.com>
---
 utilities/checkpatch.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Eelco Chaudron Nov. 14, 2023, 8:22 a.m. UTC | #1
On 13 Nov 2023, at 14:00, Roi Dayan wrote:

> From: Gaetan Rivet <gaetanr@nvidia.com>
>
> The enchant dictionary synchronizes additions to the source file.
> Keep the two word source separate by adding the extra words only
> to the current session.
>
> Signed-off-by: Gaetan Rivet <gaetanr@nvidia.com>
> Acked-by: Roi Dayan <roid@nvidia.com>

This looks good to me, but we should add the below fixes tag.

Fixes: 999c7773a60b ("checkpatch: add a comment spell-checker")

//Eelco

Acked-by: Eelco Chaudron <echaudro@redhat.com>

> ---
>  utilities/checkpatch.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py
> index 6b210fab8385..2dd02ee6420c 100755
> --- a/utilities/checkpatch.py
> +++ b/utilities/checkpatch.py
> @@ -93,7 +93,7 @@ def open_spell_check_dict():
>          global spell_check_dict
>          spell_check_dict = enchant.Dict("en_US")
>          for kw in extra_keywords:
> -            spell_check_dict.add(kw)
> +            spell_check_dict.add_to_session(kw)
>
>          return True
>      except:
> -- 
> 2.40.1
diff mbox series

Patch

diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py
index 6b210fab8385..2dd02ee6420c 100755
--- a/utilities/checkpatch.py
+++ b/utilities/checkpatch.py
@@ -93,7 +93,7 @@  def open_spell_check_dict():
         global spell_check_dict
         spell_check_dict = enchant.Dict("en_US")
         for kw in extra_keywords:
-            spell_check_dict.add(kw)
+            spell_check_dict.add_to_session(kw)
 
         return True
     except: