diff mbox series

[ovs-dev] ovsdb-cluster.at: Remove extra ordinal schema and schema name operations.

Message ID 20230901173202.2749269-1-i.maximets@ovn.org
State Accepted
Commit 563c50fba7c5eb8ed4c2a4e42131a7bdc670a4a6
Headers show
Series [ovs-dev] ovsdb-cluster.at: Remove extra ordinal schema and schema name operations. | expand

Checks

Context Check Description
ovsrobot/apply-robot success apply and check: success
ovsrobot/github-robot-_Build_and_Test success github build: passed
ovsrobot/intel-ovs-compilation success test: success

Commit Message

Ilya Maximets Sept. 1, 2023, 5:32 p.m. UTC 
Many tests are retrieving the schema name twice and also producing
an ordinal schema which is not used in these tests.

Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
---
 tests/ovsdb-cluster.at | 12 ------------
 1 file changed, 12 deletions(-)

Comments

Simon Horman Sept. 2, 2023, 9:07 a.m. UTC | #1 
On Fri, Sep 01, 2023 at 07:32:02PM +0200, Ilya Maximets wrote:
> Many tests are retrieving the schema name twice and also producing
> an ordinal schema which is not used in these tests.
> 
> Signed-off-by: Ilya Maximets <i.maximets@ovn.org>

Acked-by: Simon Horman <horms@ovn.org>
Ilya Maximets Sept. 9, 2023, 1:07 a.m. UTC | #2 
On 9/2/23 11:07, Simon Horman wrote:
> On Fri, Sep 01, 2023 at 07:32:02PM +0200, Ilya Maximets wrote:
>> Many tests are retrieving the schema name twice and also producing
>> an ordinal schema which is not used in these tests.
>>
>> Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
> 
> Acked-by: Simon Horman <horms@ovn.org>
> 

Thanks!  Applied.

Best regards, Ilya Maximets.
diff mbox series

Patch

diff --git a/tests/ovsdb-cluster.at b/tests/ovsdb-cluster.at
index 3e8bca59a..481afc08b 100644
--- a/tests/ovsdb-cluster.at
+++ b/tests/ovsdb-cluster.at
@@ -104,8 +104,6 @@  ovsdb_test_cluster_disconnect () {
     n=$1
     leader_or_follower=$2
     check_flapping=$3
-    schema_name=`ovsdb-tool schema-name $abs_srcdir/idltest.ovsschema`
-    ordinal_schema > schema
     AT_CHECK([ovsdb-tool '-vPATTERN:console:%c|%p|%m' create-cluster s1.db $abs_srcdir/idltest.ovsschema unix:s1.raft], [0], [], [stderr])
     cid=`ovsdb-tool db-cid s1.db`
     schema_name=`ovsdb-tool schema-name $abs_srcdir/idltest.ovsschema`
@@ -221,8 +219,6 @@  AT_SETUP([OVSDB cluster - initial status should be disconnected])
 AT_KEYWORDS([ovsdb server negative unix cluster disconnect])
 
 n=3
-schema_name=`ovsdb-tool schema-name $abs_srcdir/idltest.ovsschema`
-ordinal_schema > schema
 AT_CHECK([ovsdb-tool '-vPATTERN:console:%c|%p|%m' create-cluster s1.db $abs_srcdir/idltest.ovsschema unix:s1.raft], [0], [], [stderr])
 cid=`ovsdb-tool db-cid s1.db`
 schema_name=`ovsdb-tool schema-name $abs_srcdir/idltest.ovsschema`
@@ -260,8 +256,6 @@  AT_SETUP([OVSDB cluster - election timer change])
 AT_KEYWORDS([ovsdb server positive unix cluster timer])
 
 n=3
-schema_name=`ovsdb-tool schema-name $abs_srcdir/idltest.ovsschema`
-ordinal_schema > schema
 AT_CHECK([ovsdb-tool '-vPATTERN:console:%c|%p|%m' create-cluster s1.db $abs_srcdir/idltest.ovsschema unix:s1.raft], [0], [], [stderr])
 cid=`ovsdb-tool db-cid s1.db`
 schema_name=`ovsdb-tool schema-name $abs_srcdir/idltest.ovsschema`
@@ -353,8 +347,6 @@  AT_SETUP([OVSDB cluster - install snapshot RPC])
 AT_KEYWORDS([ovsdb server positive unix cluster snapshot])
 
 n=3
-schema_name=`ovsdb-tool schema-name $abs_srcdir/idltest.ovsschema`
-ordinal_schema > schema
 AT_CHECK([ovsdb-tool '-vPATTERN:console:%c|%p|%m' create-cluster s1.db $abs_srcdir/idltest.ovsschema unix:s1.raft], [0], [], [stderr])
 cid=`ovsdb-tool db-cid s1.db`
 schema_name=`ovsdb-tool schema-name $abs_srcdir/idltest.ovsschema`
@@ -433,8 +425,6 @@  AT_SETUP([OVSDB cluster - follower crash while joining])
 AT_KEYWORDS([ovsdb server negative unix cluster join])
 
 n=3
-schema_name=`ovsdb-tool schema-name $abs_srcdir/idltest.ovsschema`
-ordinal_schema > schema
 AT_CHECK([ovsdb-tool '-vPATTERN:console:%c|%p|%m' create-cluster s1.db dnl
               $abs_srcdir/idltest.ovsschema unix:s1.raft], [0], [], [stderr])
 cid=`ovsdb-tool db-cid s1.db`
@@ -665,8 +655,6 @@  AT_SETUP([OVSDB cluster - competing candidates])
 AT_KEYWORDS([ovsdb server negative unix cluster competing-candidates])
 
 n=3
-schema_name=`ovsdb-tool schema-name $abs_srcdir/idltest.ovsschema`
-ordinal_schema > schema
 AT_CHECK([ovsdb-tool '-vPATTERN:console:%c|%p|%m' create-cluster s1.db $abs_srcdir/idltest.ovsschema unix:s1.raft], [0], [], [stderr])
 cid=`ovsdb-tool db-cid s1.db`
 schema_name=`ovsdb-tool schema-name $abs_srcdir/idltest.ovsschema`