| Message ID | 20230531132220.3530426-1-david.marchand@redhat.com |
|---|---|
| State | Accepted |
| Commit | 359cabbd6eb2cee19f6aa7db749a1a0c59e25292 |
| Headers | show |
| Series | [ovs-dev] netdev-offload: Fix some typos. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
| ovsrobot/intel-ovs-compilation | success | test: success |
On Wed, May 31, 2023 at 3:22 PM David Marchand <david.marchand@redhat.com> wrote: > > Caught while reviewing code. > > Fixes: aca2f8a8a6b6 ("netdev-offload-dpdk: Implement HW miss packet recover for vport.") > Fixes: b6cabb8f8f80 ("netdev: Split up netdev offloading to separate module.") Mm, forgot to refresh the patch before sending, the second Fixes tag should be: Fixes: 241bad15d99a ("dpif-netdev: associate flow with a mark id") I suppose this can be fixed when applying. > Signed-off-by: David Marchand <david.marchand@redhat.com>
On 31 May 2023, at 15:22, David Marchand wrote: > Caught while reviewing code. > > Fixes: aca2f8a8a6b6 ("netdev-offload-dpdk: Implement HW miss packet recover for vport.") > Fixes: b6cabb8f8f80 ("netdev: Split up netdev offloading to separate module.") > Signed-off-by: David Marchand <david.marchand@redhat.com> Changes look god to me (visual inspection only). Acked-by: Eelco Chaudron <echaudro@redhat.com> > --- > lib/netdev-offload-dpdk.c | 2 +- > lib/netdev-offload.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/netdev-offload-dpdk.c b/lib/netdev-offload-dpdk.c > index 2d7858f51c..14bc877719 100644 > --- a/lib/netdev-offload-dpdk.c > +++ b/lib/netdev-offload-dpdk.c > @@ -2672,7 +2672,7 @@ netdev_offload_dpdk_hw_miss_packet_recover(struct netdev *netdev, > if (rte_restore_info.flags & RTE_FLOW_RESTORE_INFO_ENCAPSULATED) { > if (!vport_netdev->netdev_class || > !vport_netdev->netdev_class->pop_header) { > - VLOG_ERR_RL(&rl, "vport nedtdev=%s with no pop_header method", > + VLOG_ERR_RL(&rl, "vport netdev=%s with no pop_header method", > netdev_get_name(vport_netdev)); > ret = EOPNOTSUPP; > goto close_vport_netdev; > diff --git a/lib/netdev-offload.h b/lib/netdev-offload.h > index edc843cd99..47f8e6f48b 100644 > --- a/lib/netdev-offload.h > +++ b/lib/netdev-offload.h > @@ -72,7 +72,7 @@ struct offload_info { > * sync with datapath recirc ids. */ > > /* > - * The flow mark id assigened to the flow. If any pkts hit the flow, > + * The flow mark id assigned to the flow. If any pkts hit the flow, > * it will be in the pkt meta data. > */ > uint32_t flow_mark; > -- > 2.40.1 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 5/31/23 16:03, Eelco Chaudron wrote: > > > On 31 May 2023, at 15:22, David Marchand wrote: > >> Caught while reviewing code. >> >> Fixes: aca2f8a8a6b6 ("netdev-offload-dpdk: Implement HW miss packet recover for vport.") >> Fixes: b6cabb8f8f80 ("netdev: Split up netdev offloading to separate module.") >> Signed-off-by: David Marchand <david.marchand@redhat.com> > > Changes look god to me (visual inspection only). > > Acked-by: Eelco Chaudron <echaudro@redhat.com> Applied. Thanks! Best regards, Ilya Maximets.
diff --git a/lib/netdev-offload-dpdk.c b/lib/netdev-offload-dpdk.c index 2d7858f51c..14bc877719 100644 --- a/lib/netdev-offload-dpdk.c +++ b/lib/netdev-offload-dpdk.c @@ -2672,7 +2672,7 @@ netdev_offload_dpdk_hw_miss_packet_recover(struct netdev *netdev, if (rte_restore_info.flags & RTE_FLOW_RESTORE_INFO_ENCAPSULATED) { if (!vport_netdev->netdev_class || !vport_netdev->netdev_class->pop_header) { - VLOG_ERR_RL(&rl, "vport nedtdev=%s with no pop_header method", + VLOG_ERR_RL(&rl, "vport netdev=%s with no pop_header method", netdev_get_name(vport_netdev)); ret = EOPNOTSUPP; goto close_vport_netdev; diff --git a/lib/netdev-offload.h b/lib/netdev-offload.h index edc843cd99..47f8e6f48b 100644 --- a/lib/netdev-offload.h +++ b/lib/netdev-offload.h @@ -72,7 +72,7 @@ struct offload_info { * sync with datapath recirc ids. */ /* - * The flow mark id assigened to the flow. If any pkts hit the flow, + * The flow mark id assigned to the flow. If any pkts hit the flow, * it will be in the pkt meta data. */ uint32_t flow_mark;
Caught while reviewing code. Fixes: aca2f8a8a6b6 ("netdev-offload-dpdk: Implement HW miss packet recover for vport.") Fixes: b6cabb8f8f80 ("netdev: Split up netdev offloading to separate module.") Signed-off-by: David Marchand <david.marchand@redhat.com> --- lib/netdev-offload-dpdk.c | 2 +- lib/netdev-offload.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)