| Message ID | 202305251754372872431@chinatelecom.cn |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev] userspace: modify the width of tpa and spa | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | fail | github build: failed |
On Thu, May 25, 2023 at 05:54:37PM +0800, yangchang wrote: > Arp_spa and arp_tpa are IP addresses, their width should be 32 bits. > > Signed-off-by: yangchang <yangchang@chinatelecom.cn> Reviewed-by: Simon Horman <simon.horman@corigine.com>
On 5/25/23 13:27, Simon Horman wrote: > On Thu, May 25, 2023 at 05:54:37PM +0800, yangchang wrote: >> Arp_spa and arp_tpa are IP addresses, their width should be 32 bits. >> >> Signed-off-by: yangchang <yangchang@chinatelecom.cn> > > Reviewed-by: Simon Horman <simon.horman@corigine.com> The change looks good to me, but the 'userspace' part in the patch subject doesn't make a lot of sense. I replaced it with 'ovs-fields'. With that, applied and backported down to 2.17. Thanks! Best regards, Ilya Maximets.
diff --git a/lib/meta-flow.xml b/lib/meta-flow.xml index a1a2036..bdd12f6 100644 --- a/lib/meta-flow.xml +++ b/lib/meta-flow.xml @@ -4312,9 +4312,9 @@ r r c c c. <bits name="pln" above="8" below="4" width=".2"/> <bits name="op" above="16" width=".2" fill="yes"/> <bits name="sha" above="48" width="0.5" fill="yes"/> - <bits name="spa" above="16" width="0.3" fill="yes"/> + <bits name="spa" above="32" width="0.5" fill="yes"/> <bits name="tha" above="48" width="0.5" fill="yes"/> - <bits name="tpa" above="16" width="0.3" fill="yes"/> + <bits name="tpa" above="32" width="0.5" fill="yes"/> </header> </diagram>
Arp_spa and arp_tpa are IP addresses, their width should be 32 bits. Signed-off-by: yangchang <yangchang@chinatelecom.cn> --- lib/meta-flow.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 1.8.3.1 yangchang@chinatelecom.cn