| Message ID | 20230418125807.2366713-1-david.marchand@redhat.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev] system-offloads-traffic: Fix tc ingress pps check for meter offload. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
| ovsrobot/intel-ovs-compilation | success | test: success |
On Tue, Apr 18, 2023 at 02:58:07PM +0200, David Marchand wrote: > Caught during some code review. > SUPPORT_TC_INGRESS_PPS has been replaced with CHECK_TC_INGRESS_PPS(). > > Fixes: 5f0fdf5e2c2e ("test: Move check for tc ingress pps support to test script.") > Signed-off-by: David Marchand <david.marchand@redhat.com> Thanks David, I tested the negative case, where the test should be skipped, and indeed this patch does fix a problem there. Unfortunately I'm not in a position to test the positive case this morning. But it should follow the pattern of the other positive cases, which I previously checked when preparing the above mentioned commit. So I am confident this case will work too. Applied as: - d70688a7291e ("system-offloads-traffic: Fix tc ingress pps check for meter offload.") https://github.com/openvswitch/ovs/commit/d70688a7291e Not backported as the commit this fixes is not present in any release branches.
diff --git a/tests/system-offloads-traffic.at b/tests/system-offloads-traffic.at index da18597cd8..ae302a2949 100644 --- a/tests/system-offloads-traffic.at +++ b/tests/system-offloads-traffic.at @@ -240,7 +240,7 @@ AT_CLEANUP AT_SETUP([offloads - check interface meter offloading - offloads enabled]) AT_KEYWORDS([offload-meter]) -AT_SKIP_IF([test $SUPPORT_TC_INGRESS_PPS = "no"]) +CHECK_TC_INGRESS_PPS() AT_SKIP_IF([test $HAVE_NC = "no"]) OVS_TRAFFIC_VSWITCHD_START([], [], [-- set Open_vSwitch . other_config:hw-offload=true])
Caught during some code review. SUPPORT_TC_INGRESS_PPS has been replaced with CHECK_TC_INGRESS_PPS(). Fixes: 5f0fdf5e2c2e ("test: Move check for tc ingress pps support to test script.") Signed-off-by: David Marchand <david.marchand@redhat.com> --- tests/system-offloads-traffic.at | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)