From patchwork Mon Mar 13 10:27:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Roi Dayan X-Patchwork-Id: 1756148 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.136; helo=smtp3.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=Ja8pFdq1; dkim-atps=neutral Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4PZtCp5FZ3z1yWt for ; Mon, 13 Mar 2023 21:28:20 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id A37B260E27; Mon, 13 Mar 2023 10:28:17 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org A37B260E27 Authentication-Results: smtp3.osuosl.org; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=Ja8pFdq1 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nuXbI1I_4gZx; Mon, 13 Mar 2023 10:28:16 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp3.osuosl.org (Postfix) with ESMTPS id 87E6960670; Mon, 13 Mar 2023 10:28:15 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 87E6960670 Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 54F9BC0035; Mon, 13 Mar 2023 10:28:15 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 16327C0032 for ; Mon, 13 Mar 2023 10:28:14 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 982CA60899 for ; Mon, 13 Mar 2023 10:28:13 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 982CA60899 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YKGCnyJbflee for ; Mon, 13 Mar 2023 10:28:12 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 5CA8860670 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on20600.outbound.protection.outlook.com [IPv6:2a01:111:f400:7eae::600]) by smtp3.osuosl.org (Postfix) with ESMTPS id 5CA8860670 for ; Mon, 13 Mar 2023 10:28:12 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WZX+isaLnUuqlJaFwzJof/u2iXHsn2oKEAcOXXO5EB38fxxpekFu7AetFU43bP6kS+fU3/BsISCgvUv4q+crSiIdqkQmZoAFOtFwoXx8i1Jgi2+XunssODMbBmSdnAszujc9s92m3F0Ctl4zBJgONafIQkLwQ65z649VSwFrg2pKJHNIdZJSzC80u6QM1vK59v2DUJq56BMoKMstNuBFM8Nq1m4Nvbdp1hxRNvO5V4QUgpBTvGBAlh3qlJuxbOn3akLFURB7ebWGDSRKBZRDwwNLe0ejQwWzg0sa9moGQdunrXPtgc74VMl0lpdVaWfi+NBiKqXh+HDhVu2O65hDdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ca8t9yRNhf9tMp0ZRXFsdYh5G5DXGxKg/HlMvMBxY1w=; b=gYtaMk2EC6ngCUf2XZNUZYuJeymIaWx/eQGeUBrxTFsOpWiDu05XAYKxphNFJv/KHKa5XXWHPG4tDQN9QiwcYCqk+OWwNEjtSOBYIy9NBm5NeumWBrAbaJoKvT76CYRdjQGd5D+ISkIiSB1n8W5MuosonTusfVZjt+CWOXaVaO9ZQOMkMggmO0WS+QWqBNzue2BOZ6YD3Jp6XNerth9J7zrqSDHLoFdle3QWMg3r+hxmll43LFfk52Qm0pTzZr86nQmiq65nEgRUjrL672+5eyddCFyHEObYAXM7J8GphGf8vsg2/xMdULCWfI5ICeFtQN9ke9NK+vRpnsMmhAq6RA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=openvswitch.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ca8t9yRNhf9tMp0ZRXFsdYh5G5DXGxKg/HlMvMBxY1w=; b=Ja8pFdq1ip8rpAx+u5G0+HjcX5Dq2TtCxLGKpNG20jzfivLjvvW4D0aaMjZX5fCPLQEG39XOtwGzjI36/U1rORw74+3OTQ8L8I435OkfsOjGQXf77W0EkUzHoPaTuOIbNnAmJjQtM3GUMo5gTNfMjGzu7PPZt88WaYeGqIHSZ/ZDxbVnvyHpbFRbqEgCbFbF2fCaK/x6YlkO7fKOoAjIrmfzKhEPwje3VTs1j/akRCwZfrG9JFF+J7L3BbPJ7pKu2VelLZ5VIQHYhbciVcLTKkQG0FaMdq/3n4oq6XUd/o8j77z9ZSOZVux+j/hrZx0qNblT0hpKy+/RRDMSDRYP4A== Received: from MW4PR04CA0084.namprd04.prod.outlook.com (2603:10b6:303:6b::29) by PH7PR12MB6396.namprd12.prod.outlook.com (2603:10b6:510:1fc::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.24; Mon, 13 Mar 2023 10:28:09 +0000 Received: from CO1NAM11FT012.eop-nam11.prod.protection.outlook.com (2603:10b6:303:6b:cafe::a5) by MW4PR04CA0084.outlook.office365.com (2603:10b6:303:6b::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.25 via Frontend Transport; Mon, 13 Mar 2023 10:28:09 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CO1NAM11FT012.mail.protection.outlook.com (10.13.175.192) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.24 via Frontend Transport; Mon, 13 Mar 2023 10:28:08 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Mon, 13 Mar 2023 03:27:56 -0700 Received: from rnnvmail205.nvidia.com (10.129.68.10) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Mon, 13 Mar 2023 03:27:55 -0700 Received: from dev-r-vrt-138.mtr.labs.mlnx (10.127.8.10) by mail.nvidia.com (10.129.68.10) with Microsoft SMTP Server id 15.2.986.5 via Frontend Transport; Mon, 13 Mar 2023 03:27:54 -0700 To: Date: Mon, 13 Mar 2023 12:27:51 +0200 Message-ID: <20230313102751.594104-1-roid@nvidia.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT012:EE_|PH7PR12MB6396:EE_ X-MS-Office365-Filtering-Correlation-Id: 2a515055-68f1-49de-8499-08db23ada3e4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yDmYD9rtE7rSSL5cec2q8sPzuaR+tqzH7r23cEKFoglnYkeAf5hlPtv54iCHy6nN81L/hCA1op7bn/AmNTyGJ2iw7jRwk6vaQJUJ8laH6IUOK6XiwA8hqdQErpbXJcwxvGHwDbZ2em8orH+4CSjs3tH6dsOhcgusajTOszOafLHJT4oenQPvEPqXEDNnCHWzzBNc3Zeie/tkt9YE6K64DZs9ZwHR3KuJ4iPYKrK1BzHxlzNryOO0jEn/P/Echh+dTVERfVWZXb/bagNRsQDgVk2gBU9IMN4UT0Dmo3L62zPbC8Vow9xtDAGadPvs6U2m/nS3inpRYCIvfQA1wVM749Y25m9rnkoAL+jiDrdFudCbrqSrZ9rxb45qMosXU/ea1WYLsLjb+hq3SuccNQU797vvFpWWMSUTKDfVFooscNHuk1KkzbHsr5njEWQA0uOMfNgGrZlFwCK0TWcB1zgggHh/mBHBaEtpCHuWzuvaIuzBLMtkw+qD9ymLDzDlkN1V56HHYEncGZFyYLLY5JSvMCTfTeRX+IdIPFHZpRvG30bqL1AKj+ekROnB4p6c21I6JCAf7XrJAewWhZgCvL/Zij43YyJQMHmiBJbU+6dR/1+H2rH6tcBAqO53gvkedymqrxiIUpW7sjKRuoCJWbEnE+mDT9hYEBa8hFAF0pK1YdCnUIP3JTARDZtA5kd8QVybDzumwfondh9gy2TbXgPTDl3pooNckVr/6/qDBbWtHKmHCPq4MWOo7wa9PwMWa86h X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230025)(4636009)(39860400002)(346002)(396003)(376002)(136003)(451199018)(36840700001)(40470700004)(46966006)(36756003)(82310400005)(86362001)(6916009)(41300700001)(186003)(26005)(1076003)(40460700003)(5660300002)(4326008)(336012)(2616005)(8936002)(316002)(54906003)(478600001)(70586007)(40480700001)(8676002)(70206006)(107886003)(6666004)(7636003)(82740400003)(356005)(2906002)(47076005)(426003)(36860700001)(83380400001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2023 10:28:08.7471 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2a515055-68f1-49de-8499-08db23ada3e4 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT012.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6396 Cc: Simon Horman , Ilya Maximets Subject: [ovs-dev] [PATCH 1/1] tc: translate mirror/stolen to mirred X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Roi Dayan via dev From: Roi Dayan Reply-To: Roi Dayan Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" From: Oz Shlomo Currently jumping over a output-to-port action is translated to tc mirror action and stolen control action. However, the tc control action is not propagated to the hw offload action, thus the hardware action will mirror the packet and continue to the next action. Transalte mirror/stolen to "mirred egress redirect" action which terminates the action list. Fixes: e4daf88a4390 ("netdev-offload-tc: Handle check_pkt_len datapath action.") Signed-off-by: Oz Shlomo Reviewed-by: Roi Dayan --- lib/tc.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/lib/tc.c b/lib/tc.c index 4c07e22162e7..fe06d3c110b6 100644 --- a/lib/tc.c +++ b/lib/tc.c @@ -3341,13 +3341,16 @@ nl_msg_put_flower_acts(struct ofpbuf *request, struct tc_flower *flower) } action->jump_action = JUMP_ACTION_STOP; } else { - if (ingress) { - nl_msg_put_act_mirred(request, ifindex, action_pc, - TCA_INGRESS_MIRROR); + int out_action; + + if (action_pc == TC_ACT_STOLEN) { + out_action = TCA_EGRESS_REDIR; } else { - nl_msg_put_act_mirred(request, ifindex, action_pc, - TCA_EGRESS_MIRROR); + out_action = TCA_EGRESS_MIRROR; } + + nl_msg_put_act_mirred(request, ifindex, action_pc, + out_action); } nl_msg_put_act_cookie(request, &flower->act_cookie); nl_msg_put_act_flags(request);