| Message ID | 20230127133407.492972-3-simon.horman@corigine.com |
|---|---|
| State | Accepted |
| Commit | 3f85b11d50bbac9b7e746a1a061dd361ab2fa00f |
| Headers | show |
| Series | [ovs-dev,1/2] system-traffic: remove unnecessary dependency on nc | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
| ovsrobot/intel-ovs-compilation | success | test: success |
On Fri, Jan 27, 2023 at 2:34 PM Simon Horman <simon.horman@corigine.com> wrote: > > The following tests use the nc command and should be skipped if > nc is not present. > > - "offloads - check interface meter offloading - offloads disabled" > - "offloads - check interface meter offloading - offloads enabled" > > Fixes: 5660b89a309d ("dpif-netlink: Offloading meter to tc police action") > Reported-by: David Marchand <david.marchand@redhat.com> > Reviewed-by: Louis Peens <louis.peens@corigine.com> > Signed-off-by: Simon Horman <simon.horman@corigine.com> Reviewed-by: David Marchand <david.marchand@redhat.com>
diff --git a/tests/system-offloads-traffic.at b/tests/system-offloads-traffic.at index 1a60570801e1..16a4c1a0088f 100644 --- a/tests/system-offloads-traffic.at +++ b/tests/system-offloads-traffic.at @@ -181,6 +181,7 @@ AT_CLEANUP AT_SETUP([offloads - check interface meter offloading - offloads disabled]) AT_KEYWORDS([dp-meter]) +AT_SKIP_IF([test $HAVE_NC = "no"]) OVS_TRAFFIC_VSWITCHD_START() AT_CHECK([ovs-ofctl -O OpenFlow13 add-meter br0 'meter=1 pktps bands=type=drop rate=1']) @@ -230,6 +231,7 @@ AT_CLEANUP AT_SETUP([offloads - check interface meter offloading - offloads enabled]) AT_KEYWORDS([offload-meter]) AT_SKIP_IF([test $SUPPORT_TC_INGRESS_PPS = "no"]) +AT_SKIP_IF([test $HAVE_NC = "no"]) OVS_TRAFFIC_VSWITCHD_START([], [], [-- set Open_vSwitch . other_config:hw-offload=true]) AT_CHECK([ovs-ofctl -O OpenFlow13 add-meter br0 'meter=1 pktps bands=type=drop rate=1'])
The following tests use the nc command and should be skipped if nc is not present. - "offloads - check interface meter offloading - offloads disabled" - "offloads - check interface meter offloading - offloads enabled" Fixes: 5660b89a309d ("dpif-netlink: Offloading meter to tc police action") Reported-by: David Marchand <david.marchand@redhat.com> Reviewed-by: Louis Peens <louis.peens@corigine.com> Signed-off-by: Simon Horman <simon.horman@corigine.com> --- tests/system-offloads-traffic.at | 2 ++ 1 file changed, 2 insertions(+)