diff mbox series

[ovs-dev,v6,2/2] netdev-dpdk: Drop coverage counter for vhost IRQs.

Message ID 20230105202425.4187792-2-david.marchand@redhat.com
State Superseded
Headers show
Series [ovs-dev,v6,1/2] netdev-dpdk: Add per virtqueue statistics. | expand

Checks

Context Check Description
ovsrobot/apply-robot success apply and check: success
ovsrobot/github-robot-_Build_and_Test fail github build: failed
ovsrobot/intel-ovs-compilation success test: success

Commit Message

David Marchand Jan. 5, 2023, 8:24 p.m. UTC
The vhost library now provides finegrained statistics for guest
notifications:
- notifications for buffer reclaim by the guest,
- notifications for buffer availability to the guest,

Example before this patch:
$ ovs-appctl coverage/show |
  grep vhost_notification
vhost_notification         0.0/sec     0.000/sec        2.0283/sec   total: 7302

$ ovs-vsctl get interface vhost4 statistics |
  sed -e 's#[{}]##g' -e 's#, #\n#g' |
  grep guest_notifications
rx_q0_guest_notifications=66
tx_q0_guest_notifications=7236

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 lib/netdev-dpdk.c | 9 ---------
 1 file changed, 9 deletions(-)
diff mbox series

Patch

diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
index 80ba650032..2b256df2b9 100644
--- a/lib/netdev-dpdk.c
+++ b/lib/netdev-dpdk.c
@@ -78,7 +78,6 @@  VLOG_DEFINE_THIS_MODULE(netdev_dpdk);
 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(5, 20);
 
 COVERAGE_DEFINE(vhost_tx_contention);
-COVERAGE_DEFINE(vhost_notification);
 
 static char *vhost_sock_dir = NULL;   /* Location of vhost-user sockets */
 static bool vhost_iommu_enabled = false; /* Status of vHost IOMMU support */
@@ -188,7 +187,6 @@  static int new_device(int vid);
 static void destroy_device(int vid);
 static int vring_state_changed(int vid, uint16_t queue_id, int enable);
 static void destroy_connection(int vid);
-static void vhost_guest_notified(int vid);
 
 static const struct rte_vhost_device_ops virtio_net_device_ops =
 {
@@ -198,7 +196,6 @@  static const struct rte_vhost_device_ops virtio_net_device_ops =
     .features_changed = NULL,
     .new_connection = NULL,
     .destroy_connection = destroy_connection,
-    .guest_notified = vhost_guest_notified,
 };
 
 /* Custom software stats for dpdk ports */
@@ -4370,12 +4367,6 @@  destroy_connection(int vid)
     }
 }
 
-static
-void vhost_guest_notified(int vid OVS_UNUSED)
-{
-    COVERAGE_INC(vhost_notification);
-}
-
 /*
  * Retrieve the DPDK virtio device ID (vid) associated with a vhostuser
  * or vhostuserclient netdev.