diff mbox series

[ovs-dev,v1,11/11] python: don't exit OFPFlow constructor

Message ID 20221123100303.323460-11-amorenoz@redhat.com
State Superseded
Headers show
Series [ovs-dev,v1,01/11] python: fix datapath flow decoders | expand

Checks

Context Check Description
ovsrobot/apply-robot success apply and check: success
ovsrobot/github-robot-_Build_and_Test success github build: passed
ovsrobot/intel-ovs-compilation success test: success

Commit Message

Adrian Moreno Nov. 23, 2022, 10:03 a.m. UTC 
returning None in a constructor does not make sense and is just error
prone.  Removing what was a lefover from an attempt to handle a common
error case of trying to parse what is commonly outputted by ovs-ofctl.
This should be done by the caller anyway.

Signed-off-by: Adrian Moreno <amorenoz@redhat.com>
Acked-by: Mike Pattrick <mkp@redhat.com>
---
 python/ovs/flow/ofp.py | 3 ---
 1 file changed, 3 deletions(-)
diff mbox series

Patch

diff --git a/python/ovs/flow/ofp.py b/python/ovs/flow/ofp.py
index eac8d0851..20231fd9f 100644
--- a/python/ovs/flow/ofp.py
+++ b/python/ovs/flow/ofp.py
@@ -104,9 +104,6 @@  class OFPFlow(Flow):
             ValueError if the string is malformed.
             ParseError if an error in parsing occurs.
         """
-        if " reply " in ofp_string:
-            return None
-
         sections = list()
         parts = ofp_string.split("actions=")
         if len(parts) != 2: