| Message ID | 20221116104727.915151-4-elibr@nvidia.com |
|---|---|
| State | Deferred |
| Headers | show
Return-Path: <ovs-dev-bounces@openvswitch.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=<UNKNOWN>) Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=qo5n5bV1; dkim-atps=neutral Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4NC0Bn4cNxz23n4 for <incoming@patchwork.ozlabs.org>; Wed, 16 Nov 2022 21:48:17 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 2786981FF4; Wed, 16 Nov 2022 10:48:15 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 2786981FF4 Authentication-Results: smtp1.osuosl.org; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=qo5n5bV1 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DIrl04Y_jxIm; Wed, 16 Nov 2022 10:48:13 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp1.osuosl.org (Postfix) with ESMTPS id 45C0882001; Wed, 16 Nov 2022 10:48:12 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 45C0882001 Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 06E1BC0071; Wed, 16 Nov 2022 10:48:12 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 1E6F0C0077 for <dev@openvswitch.org>; Wed, 16 Nov 2022 10:48:11 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 00B6981FEA for <dev@openvswitch.org>; Wed, 16 Nov 2022 10:48:05 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 00B6981FEA X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kQyjWMsoEoH2 for <dev@openvswitch.org>; Wed, 16 Nov 2022 10:48:05 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 3583281FE2 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2062c.outbound.protection.outlook.com [IPv6:2a01:111:f400:7eaa::62c]) by smtp1.osuosl.org (Postfix) with ESMTPS id 3583281FE2 for <dev@openvswitch.org>; Wed, 16 Nov 2022 10:48:05 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l9cMQxTmAlMFslc3ulZH7pSD2nTnCvcJ8y+ci4t1munprzphNtlRTPvovusqnoiErITG53N9dl2jPBsM51JT8V3T2ALksCGTWSh725WMTiFNhQCJSpxsjliWhcLKp4OSS25rApF0FHRFHPdwF5EzoFbw4Y1fea16jf4PlXve/IrMbQvssLvnvu5h16IZKQrMneshW1QKWnCIDkn99tWrfkaC6OfqvheOrPh1VNKnrSeWZWqxuRxBL26SBG8FOEMZRsevhSEJJl97CMzLEoPtepozya0U4s9GK2WmlkcMpJBm6dqIsNl2I10ZrbNBZkLl2h66LGk3bWtOCQClqseMGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EQII9F6/nad8H9fn8i1G638aYhBZQoAgcY09zYH3cNs=; b=cPKMn10UmQ6Y0Us98hW2qJN5YfxLA62kY5H9n3pih56p83nIaAhQ4TcVGmBAEjzvFe+bLIN58jQb+azr2NHp4gfnFY/PvmSZQ4Rs5iRyiy7QBdGFekVUmnYMF+tdyYa1ckCaxkUTjTbdkjf5GagqhONJgdijmho1z3CMvyXFXJJk4+GAzqWfEgJZd72r5d9yTyXkmjQZLx8ks9NShgVIQcOhwaUxowidM9p6AQCoMPhEQDaLso/lW97yHV8XrA0Ye2G6dxPP+wjCJFKXTIXW/5676SOZ/5lt9MNBlVhzo12+fXJlKQ/XLjACsq3V8h4t8xEuixb0+tk08T36Ot8Xjg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=openvswitch.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EQII9F6/nad8H9fn8i1G638aYhBZQoAgcY09zYH3cNs=; b=qo5n5bV11Vbdgjy7PZc5JH1+A9m+ZQX/nis1CekHFqWKsssmbVgw04Hp+zOwwFwCxMb59UclogUFPktzxB/3rwAMswbt92pWLqgCBV3k1zD5LeDhRKlx8zwuTUMZWVb5Dydv94IG6NLK55csMYNP/evXfiuyU3+TIX+S8bn//adeSrrdVkYlqqvVmk1vsleju/JrQNP16ClySBLxt9u16TkGVsQACdG4GLqttXY2dENG5OnPz9TJ8TseK1rCSs9FYezyThxVfLLc3e+bwb/R5VZxm8q6sq0IwjK4xNSxfveINtvGoshum9ZFFqgdU/bsoqJe6Lh3Kek2gsIelbur6A== Received: from DM6PR06CA0070.namprd06.prod.outlook.com (2603:10b6:5:54::47) by SN7PR12MB8145.namprd12.prod.outlook.com (2603:10b6:806:350::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.18; Wed, 16 Nov 2022 10:48:02 +0000 Received: from DM6NAM11FT069.eop-nam11.prod.protection.outlook.com (2603:10b6:5:54:cafe::a4) by DM6PR06CA0070.outlook.office365.com (2603:10b6:5:54::47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.17 via Frontend Transport; Wed, 16 Nov 2022 10:48:02 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by DM6NAM11FT069.mail.protection.outlook.com (10.13.173.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.8 via Frontend Transport; Wed, 16 Nov 2022 10:48:01 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Wed, 16 Nov 2022 02:47:49 -0800 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Wed, 16 Nov 2022 02:47:47 -0800 To: <dev@openvswitch.org>, Simon Horman <simon.horman@netronome.com>, "Ilya Maximets" <i.maximets@ovn.org> Date: Wed, 16 Nov 2022 12:47:22 +0200 Message-ID: <20221116104727.915151-4-elibr@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221116104727.915151-1-elibr@nvidia.com> References: <20221116104727.915151-1-elibr@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT069:EE_|SN7PR12MB8145:EE_ X-MS-Office365-Filtering-Correlation-Id: 686c93da-2b46-4d24-a3ea-08dac7c008c9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hnusXLhD7BComVa6TRNTByBXafj/PvMb8YE6V6KCknsqk5PoMAtWtXk2IlwK6JgAsdGmjcgxdRk9yZgkddQKu9cej0ejVdmOKHgN3q5BkhawbQTuHvVJqA0TXNln5HcePW7ZY+chUUUJZnGti/iQfQCrg2e0JSGgk7JPe/zhEvPb4ZMKINw+/fwBHkkQmuvdZGOLJxQP2NV8Zbx36evzYrqeUBRq5BCdGr6o8P8WVUj0vxUfyD2Co4eGCubGhhyfzz00eFNIZ/JquOGTjCfq8Z2E0fgGlP0bRdPSS4t40mVJOx+nQi/BzyqUoaKsFWmWrQgyIpXilG+lSOtRygPoiXxJUXeByMWvia+tLTVTFlrP6pX96WGz57rUBlcm77pF48ICa5ke0lfUTUJ5k74CuIttjCFv6HS+VFvtLp5z8tw7/IB12Bh9ZmPcIONsQhZIVrPZhatkCbHMiD0vAUQkQ1NddXl0mI8OpUa8v7Nl0R55rbiq/go3zOfOKK3J9X1vicvmql6HGBfxTScTe876QyPKgGtuDDff79WZS+bHHvu87SAgrOK29jepkEZb1Ug05QGHa9Yvw9EdOcqkDHNWiCGuyDpfOhLyBnMufDRj6nF6Y84iNlpByDVfoPKeTN3zTSUlofH0OOOWiY+yaaZ6OAv0lELXS/fYfo7AHbqkkBqi8w1lNEj9Ih51S/msfiTJMU4Ku4guu842o0btfoFQCbb3v3ovDW3SAciQQKNEGxeMbXaOJsn8hMvdZ1C69oqww0Qn53wYamGr2XiElCTS2A== X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230022)(4636009)(376002)(396003)(346002)(39860400002)(136003)(451199015)(40470700004)(36840700001)(46966006)(82310400005)(5660300002)(41300700001)(2906002)(110136005)(70206006)(70586007)(8676002)(316002)(54906003)(4326008)(7696005)(336012)(6666004)(107886003)(40460700003)(86362001)(2616005)(83380400001)(186003)(478600001)(16526019)(6286002)(26005)(82740400003)(1076003)(7636003)(356005)(8936002)(47076005)(40480700001)(426003)(55016003)(36860700001)(36756003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2022 10:48:01.9864 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 686c93da-2b46-4d24-a3ea-08dac7c008c9 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT069.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB8145 Cc: Eli Britstein <elibr@nvidia.com> Subject: [ovs-dev] [PATCH V2 3/8] ovs-ofctl: Fix 'usable_protocols' may be used uninitialized X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: <ovs-dev.openvswitch.org> List-Unsubscribe: <https://mail.openvswitch.org/mailman/options/ovs-dev>, <mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe> List-Archive: <http://mail.openvswitch.org/pipermail/ovs-dev/> List-Post: <mailto:ovs-dev@openvswitch.org> List-Help: <mailto:ovs-dev-request@openvswitch.org?subject=help> List-Subscribe: <https://mail.openvswitch.org/mailman/listinfo/ovs-dev>, <mailto:ovs-dev-request@openvswitch.org?subject=subscribe> From: Eli Britstein via dev <ovs-dev@openvswitch.org> Reply-To: Eli Britstein <elibr@nvidia.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" <ovs-dev-bounces@openvswitch.org> |
| Series |
Fix warnings and enable Werror
|
expand
|
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
| ovsrobot/intel-ovs-compilation | success | test: success |
diff --git a/utilities/ovs-ofctl.c b/utilities/ovs-ofctl.c index fe9114580..6805140d6 100644 --- a/utilities/ovs-ofctl.c +++ b/utilities/ovs-ofctl.c @@ -3121,7 +3121,7 @@ static void ofctl_group_mod_file(int argc OVS_UNUSED, char *argv[], int command) { struct ofputil_group_mod *gms = NULL; - enum ofputil_protocol usable_protocols; + enum ofputil_protocol usable_protocols = 0; size_t n_gms = 0; char *error;
With --enable-Werror and --with-dpdk=no: ../utilities/ovs-ofctl.c: In function 'ofctl_group_mod_file': ../utilities/ovs-ofctl.c:3107:16: error: 'usable_protocols' may be used uninitialized in this function [-Werror=maybe-uninitialized] 3107 | protocol = open_vconn_for_flow_mod(remote, &vconn, usable_protocols); | ^ ../utilities/ovs-ofctl.c:3124:27: note: 'usable_protocols' was declared here 3124 | enum ofputil_protocol usable_protocols; | ^ Fixes: 69185eb25acb ("ovs-ofctl: Only allow usable protocols for group commands") Signed-off-by: Eli Britstein <elibr@nvidia.com> --- utilities/ovs-ofctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)