| Message ID | 20221109203150.783265-1-david.marchand@redhat.com |
|---|---|
| State | Accepted |
| Commit | c6062d107716e6bf84f8106b0806ee73ba7207a3 |
| Headers | show |
| Series | [ovs-dev] vswitchd: Publish per iface received multicast packets. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
| ovsrobot/intel-ovs-compilation | success | test: success |
On Wed, Nov 9, 2022 at 3:32 PM David Marchand <david.marchand@redhat.com> wrote: > > The count of received multicast packets has been computed internally, > but not exposed to ovsdb. Fix this. > > Signed-off-by: David Marchand <david.marchand@redhat.com> Acked-by: Mike Pattrick <mkp@redhat.com> > --- > Strictly speaking, nothing was broken so I put no Fixes: tag. > However, this is probably something we should backport to enhance > exposed stats. > > --- > vswitchd/bridge.c | 1 + > 1 file changed, 1 insertion(+) >
On Wed, Nov 9, 2022 at 3:32 PM David Marchand <david.marchand@redhat.com> wrote: > > The count of received multicast packets has been computed internally, > but not exposed to ovsdb. Fix this. > > Signed-off-by: David Marchand <david.marchand@redhat.com> Acked-by: Michael Santana <msantana@redhat.com> > --- > Strictly speaking, nothing was broken so I put no Fixes: tag. > However, this is probably something we should backport to enhance > exposed stats. > > --- > vswitchd/bridge.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c > index 25ce45e3dc..d0667f229d 100644 > --- a/vswitchd/bridge.c > +++ b/vswitchd/bridge.c > @@ -2619,6 +2619,7 @@ iface_refresh_stats(struct iface *iface) > IFACE_STAT(tx_512_to_1023_packets, "tx_512_to_1023_packets") \ > IFACE_STAT(tx_1024_to_1522_packets, "tx_1024_to_1522_packets") \ > IFACE_STAT(tx_1523_to_max_packets, "tx_1523_to_max_packets") \ > + IFACE_STAT(multicast, "rx_multicast_packets") \ > IFACE_STAT(tx_multicast_packets, "tx_multicast_packets") \ > IFACE_STAT(rx_broadcast_packets, "rx_broadcast_packets") \ > IFACE_STAT(tx_broadcast_packets, "tx_broadcast_packets") \ > -- > 2.38.1 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev >
On 11/9/22 21:31, David Marchand wrote: > The count of received multicast packets has been computed internally, > but not exposed to ovsdb. Fix this. > > Signed-off-by: David Marchand <david.marchand@redhat.com> > --- > Strictly speaking, nothing was broken so I put no Fixes: tag. > However, this is probably something we should backport to enhance > exposed stats. > > --- > vswitchd/bridge.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c > index 25ce45e3dc..d0667f229d 100644 > --- a/vswitchd/bridge.c > +++ b/vswitchd/bridge.c > @@ -2619,6 +2619,7 @@ iface_refresh_stats(struct iface *iface) > IFACE_STAT(tx_512_to_1023_packets, "tx_512_to_1023_packets") \ > IFACE_STAT(tx_1024_to_1522_packets, "tx_1024_to_1522_packets") \ > IFACE_STAT(tx_1523_to_max_packets, "tx_1523_to_max_packets") \ > + IFACE_STAT(multicast, "rx_multicast_packets") \ > IFACE_STAT(tx_multicast_packets, "tx_multicast_packets") \ > IFACE_STAT(rx_broadcast_packets, "rx_broadcast_packets") \ > IFACE_STAT(tx_broadcast_packets, "tx_broadcast_packets") \ Thanks! Applied and backported down to 2.17. Best regards, Ilya Maximets.
diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c index 25ce45e3dc..d0667f229d 100644 --- a/vswitchd/bridge.c +++ b/vswitchd/bridge.c @@ -2619,6 +2619,7 @@ iface_refresh_stats(struct iface *iface) IFACE_STAT(tx_512_to_1023_packets, "tx_512_to_1023_packets") \ IFACE_STAT(tx_1024_to_1522_packets, "tx_1024_to_1522_packets") \ IFACE_STAT(tx_1523_to_max_packets, "tx_1523_to_max_packets") \ + IFACE_STAT(multicast, "rx_multicast_packets") \ IFACE_STAT(tx_multicast_packets, "tx_multicast_packets") \ IFACE_STAT(rx_broadcast_packets, "rx_broadcast_packets") \ IFACE_STAT(tx_broadcast_packets, "tx_broadcast_packets") \
The count of received multicast packets has been computed internally, but not exposed to ovsdb. Fix this. Signed-off-by: David Marchand <david.marchand@redhat.com> --- Strictly speaking, nothing was broken so I put no Fixes: tag. However, this is probably something we should backport to enhance exposed stats. --- vswitchd/bridge.c | 1 + 1 file changed, 1 insertion(+)