| Message ID | 20220916101205.2130702-2-cian.ferriter@intel.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | Enable AVX512 NVGRE optimizations. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
| ovsrobot/intel-ovs-compilation | success | test: success |
> -----Original Message----- > From: dev <ovs-dev-bounces@openvswitch.org> On Behalf Of Cian Ferriter > Sent: Friday, September 16, 2022 3:42 PM > To: ovs-dev@openvswitch.org > Subject: [ovs-dev] [PATCH 1/2] dpif-netdev/dpcls: Specialize 8, 1 and 5, 2 > signatures. > > The subtable signatures being specialized here were found in an NVGRE > tunnel scenario. > > Signed-off-by: Cian Ferriter <cian.ferriter@intel.com> > > --- > > v2: > * Improve commit title. > --- > lib/dpif-netdev-lookup-avx512-gather.c | 4 ++++ > lib/dpif-netdev-lookup-generic.c | 4 ++++ > 2 files changed, 8 insertions(+) Hey Cian, Thanks for the patch, the changes LGTM, Acked-by: Sunil Pai G <sunil.pai.g@intel.com> Thanks and regards Sunil
On 16 Sep 2022, at 12:12, Cian Ferriter wrote: > The subtable signatures being specialized here were found in an NVGRE > tunnel scenario. > > Signed-off-by: Cian Ferriter <cian.ferriter@intel.com> > --- Sorry for the late response, but I was rather busy. Changes look good to me, and did basic testing using make check* with all avx512 stuff enabled. Acked-by: Eelco Chaudron <echaudro@redhat.com>
> On 16 Sep 2022, at 12:12, Cian Ferriter wrote: > > > The subtable signatures being specialized here were found in an NVGRE > > tunnel scenario. > > > > Signed-off-by: Cian Ferriter <cian.ferriter@intel.com> > > --- > > Sorry for the late response, but I was rather busy. > Changes look good to me, and did basic testing using make check* with all > avx512 stuff enabled. > > Acked-by: Eelco Chaudron <echaudro@redhat.com> Thanks for the ack Eelco and Sunil, this seems straight forward enough so I've pushed this patch to master. Thanks Ian > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
diff --git a/lib/dpif-netdev-lookup-avx512-gather.c b/lib/dpif-netdev-lookup-avx512-gather.c index 7d3d81151..b916b2487 100644 --- a/lib/dpif-netdev-lookup-avx512-gather.c +++ b/lib/dpif-netdev-lookup-avx512-gather.c @@ -380,7 +380,9 @@ avx512_lookup_impl(struct dpcls_subtable *subtable, DECLARE_OPTIMIZED_LOOKUP_FUNCTION(9, 4) DECLARE_OPTIMIZED_LOOKUP_FUNCTION(9, 1) +DECLARE_OPTIMIZED_LOOKUP_FUNCTION(8, 1) DECLARE_OPTIMIZED_LOOKUP_FUNCTION(5, 3) +DECLARE_OPTIMIZED_LOOKUP_FUNCTION(5, 2) DECLARE_OPTIMIZED_LOOKUP_FUNCTION(5, 1) DECLARE_OPTIMIZED_LOOKUP_FUNCTION(4, 1) DECLARE_OPTIMIZED_LOOKUP_FUNCTION(4, 0) @@ -419,7 +421,9 @@ dpcls_subtable_avx512_gather_probe__(uint32_t u0_bits, uint32_t u1_bits, CHECK_LOOKUP_FUNCTION(9, 4, use_vpop); CHECK_LOOKUP_FUNCTION(9, 1, use_vpop); + CHECK_LOOKUP_FUNCTION(8, 1, use_vpop); CHECK_LOOKUP_FUNCTION(5, 3, use_vpop); + CHECK_LOOKUP_FUNCTION(5, 2, use_vpop); CHECK_LOOKUP_FUNCTION(5, 1, use_vpop); CHECK_LOOKUP_FUNCTION(4, 1, use_vpop); CHECK_LOOKUP_FUNCTION(4, 0, use_vpop); diff --git a/lib/dpif-netdev-lookup-generic.c b/lib/dpif-netdev-lookup-generic.c index 6c74ac3a1..76f92dd5e 100644 --- a/lib/dpif-netdev-lookup-generic.c +++ b/lib/dpif-netdev-lookup-generic.c @@ -284,7 +284,9 @@ dpcls_subtable_lookup_generic(struct dpcls_subtable *subtable, DECLARE_OPTIMIZED_LOOKUP_FUNCTION(9, 4) DECLARE_OPTIMIZED_LOOKUP_FUNCTION(9, 1) +DECLARE_OPTIMIZED_LOOKUP_FUNCTION(8, 1) DECLARE_OPTIMIZED_LOOKUP_FUNCTION(5, 3) +DECLARE_OPTIMIZED_LOOKUP_FUNCTION(5, 2) DECLARE_OPTIMIZED_LOOKUP_FUNCTION(5, 1) DECLARE_OPTIMIZED_LOOKUP_FUNCTION(4, 1) DECLARE_OPTIMIZED_LOOKUP_FUNCTION(4, 0) @@ -308,7 +310,9 @@ dpcls_subtable_generic_probe(uint32_t u0_bits, uint32_t u1_bits) CHECK_LOOKUP_FUNCTION(9, 4); CHECK_LOOKUP_FUNCTION(9, 1); + CHECK_LOOKUP_FUNCTION(8, 1); CHECK_LOOKUP_FUNCTION(5, 3); + CHECK_LOOKUP_FUNCTION(5, 2); CHECK_LOOKUP_FUNCTION(5, 1); CHECK_LOOKUP_FUNCTION(4, 1); CHECK_LOOKUP_FUNCTION(4, 0);
The subtable signatures being specialized here were found in an NVGRE tunnel scenario. Signed-off-by: Cian Ferriter <cian.ferriter@intel.com> --- v2: * Improve commit title. --- lib/dpif-netdev-lookup-avx512-gather.c | 4 ++++ lib/dpif-netdev-lookup-generic.c | 4 ++++ 2 files changed, 8 insertions(+)