| Message ID | 20220718113002.2305512-1-david.marchand@redhat.com |
|---|---|
| State | Accepted |
| Commit | 81d186c1c281c40dd65b27454a002792865fa0c4 |
| Headers | show |
| Series | [ovs-dev] ci: Prefer pip3 to install unit test dependencies | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
| ovsrobot/intel-ovs-compilation | success | test: success |
On 7/18/22 13:30, David Marchand wrote: > While it looks like the right python3 versions of those dependencies > seems to be installed in the CI, prefer calling this via pip3 like the > rest of the script. > > Fixes: 445dceb88461 ("python: Introduce unit tests.") > Signed-off-by: David Marchand <david.marchand@redhat.com> > --- > .ci/linux-prepare.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/.ci/linux-prepare.sh b/.ci/linux-prepare.sh > index 1698a0713b..16a7aec0b5 100755 > --- a/.ci/linux-prepare.sh > +++ b/.ci/linux-prepare.sh > @@ -43,7 +43,7 @@ if [ "$M32" ]; then > fi > > # Install python test dependencies > -pip install -r python/test_requirements.txt > +pip3 install -r python/test_requirements.txt > > # IPv6 is supported by kernel but disabled in TravisCI images: > # https://github.com/travis-ci/travis-ci/issues/8891 Thanks! Applied to master and branch-3.0. Best regards, Ilya Maximets.
diff --git a/.ci/linux-prepare.sh b/.ci/linux-prepare.sh index 1698a0713b..16a7aec0b5 100755 --- a/.ci/linux-prepare.sh +++ b/.ci/linux-prepare.sh @@ -43,7 +43,7 @@ if [ "$M32" ]; then fi # Install python test dependencies -pip install -r python/test_requirements.txt +pip3 install -r python/test_requirements.txt # IPv6 is supported by kernel but disabled in TravisCI images: # https://github.com/travis-ci/travis-ci/issues/8891
While it looks like the right python3 versions of those dependencies seems to be installed in the CI, prefer calling this via pip3 like the rest of the script. Fixes: 445dceb88461 ("python: Introduce unit tests.") Signed-off-by: David Marchand <david.marchand@redhat.com> --- .ci/linux-prepare.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)