| Message ID | 20220708200340.13053-6-gvrose8192@gmail.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Remove OVS kernel driver | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | warning | apply and check: warning |
| ovsrobot/intel-ovs-compilation | fail | test: fail |
Bleep bloop. Greetings Gregory Rose, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. Patch skipped due to previous failure. Please check this out. If you feel there has been an error, please email aconole@redhat.com Thanks, 0-day Robot
On Fri, Jul 8, 2022 at 10:05 PM Greg Rose <gvrose8192@gmail.com> wrote: > > The OVS kernel module is no longer supported as of OVS 2.18 > > Signed-off-by: Greg Rose <gvrose8192@gmail.com> This leaves behind some reference in the documentation. WDYT of: diff --git a/Documentation/topics/testing.rst b/Documentation/topics/testing.rst index c15d5b38f2..d4df656d04 100644 --- a/Documentation/topics/testing.rst +++ b/Documentation/topics/testing.rst @@ -428,13 +428,6 @@ your system, run:: $ make check-kernel -To install the kernel module from the current build directory and run the -testsuite against that kernel module:: - - $ make check-kmod - -The results of the testsuite are in ``tests/system-kmod-testsuite.dir``. - All the features documented under `Unit Tests`_ are available for the kernel datapath testsuite. > --- > tests/automake.mk | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/tests/automake.mk b/tests/automake.mk > index b29cb783e..3496f9002 100644 > --- a/tests/automake.mk > +++ b/tests/automake.mk > @@ -343,12 +343,6 @@ check-kernel: all > set $(SHELL) '$(SYSTEM_KMOD_TESTSUITE)' -C tests AUTOTEST_PATH='$(AUTOTEST_PATH)'; \ > "$$@" $(TESTSUITEFLAGS) -j1 || (test X'$(RECHECK)' = Xyes && "$$@" --recheck) > > -# Testing the out of tree Kernel module > -check-kmod: all > - $(MAKE) modules_install > - modprobe -r -a vport-geneve vport-gre vport-lisp vport-stt vport-vxlan openvswitch > - $(MAKE) check-kernel > - > check-system-userspace: all > set $(SHELL) '$(SYSTEM_USERSPACE_TESTSUITE)' -C tests AUTOTEST_PATH='$(AUTOTEST_PATH)'; \ > "$$@" $(TESTSUITEFLAGS) -j1 || (test X'$(RECHECK)' = Xyes && "$$@" --recheck) > -- > 2.17.1 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev >
On 7/9/2022 12:23 AM, David Marchand wrote: > On Fri, Jul 8, 2022 at 10:05 PM Greg Rose <gvrose8192@gmail.com> wrote: >> >> The OVS kernel module is no longer supported as of OVS 2.18 >> >> Signed-off-by: Greg Rose <gvrose8192@gmail.com> > > This leaves behind some reference in the documentation. > > WDYT of: > > diff --git a/Documentation/topics/testing.rst b/Documentation/topics/testing.rst > index c15d5b38f2..d4df656d04 100644 > --- a/Documentation/topics/testing.rst > +++ b/Documentation/topics/testing.rst > @@ -428,13 +428,6 @@ your system, run:: > > $ make check-kernel > > -To install the kernel module from the current build directory and run the > -testsuite against that kernel module:: > - > - $ make check-kmod > - > -The results of the testsuite are in ``tests/system-kmod-testsuite.dir``. > - > All the features documented under `Unit Tests`_ are available for the kernel > datapath testsuite. Yep, missed all that. I'll incorporate that into the patch for the next series. Thanks! - Greg > > >> --- >> tests/automake.mk | 6 ------ >> 1 file changed, 6 deletions(-) >> >> diff --git a/tests/automake.mk b/tests/automake.mk >> index b29cb783e..3496f9002 100644 >> --- a/tests/automake.mk >> +++ b/tests/automake.mk >> @@ -343,12 +343,6 @@ check-kernel: all >> set $(SHELL) '$(SYSTEM_KMOD_TESTSUITE)' -C tests AUTOTEST_PATH='$(AUTOTEST_PATH)'; \ >> "$$@" $(TESTSUITEFLAGS) -j1 || (test X'$(RECHECK)' = Xyes && "$$@" --recheck) >> >> -# Testing the out of tree Kernel module >> -check-kmod: all >> - $(MAKE) modules_install >> - modprobe -r -a vport-geneve vport-gre vport-lisp vport-stt vport-vxlan openvswitch >> - $(MAKE) check-kernel >> - >> check-system-userspace: all >> set $(SHELL) '$(SYSTEM_USERSPACE_TESTSUITE)' -C tests AUTOTEST_PATH='$(AUTOTEST_PATH)'; \ >> "$$@" $(TESTSUITEFLAGS) -j1 || (test X'$(RECHECK)' = Xyes && "$$@" --recheck) >> -- >> 2.17.1 >> >> _______________________________________________ >> dev mailing list >> dev@openvswitch.org >> https://mail.openvswitch.org/mailman/listinfo/ovs-dev >> > >
diff --git a/tests/automake.mk b/tests/automake.mk index b29cb783e..3496f9002 100644 --- a/tests/automake.mk +++ b/tests/automake.mk @@ -343,12 +343,6 @@ check-kernel: all set $(SHELL) '$(SYSTEM_KMOD_TESTSUITE)' -C tests AUTOTEST_PATH='$(AUTOTEST_PATH)'; \ "$$@" $(TESTSUITEFLAGS) -j1 || (test X'$(RECHECK)' = Xyes && "$$@" --recheck) -# Testing the out of tree Kernel module -check-kmod: all - $(MAKE) modules_install - modprobe -r -a vport-geneve vport-gre vport-lisp vport-stt vport-vxlan openvswitch - $(MAKE) check-kernel - check-system-userspace: all set $(SHELL) '$(SYSTEM_USERSPACE_TESTSUITE)' -C tests AUTOTEST_PATH='$(AUTOTEST_PATH)'; \ "$$@" $(TESTSUITEFLAGS) -j1 || (test X'$(RECHECK)' = Xyes && "$$@" --recheck)
The OVS kernel module is no longer supported as of OVS 2.18 Signed-off-by: Greg Rose <gvrose8192@gmail.com> --- tests/automake.mk | 6 ------ 1 file changed, 6 deletions(-)