| Message ID | 20220429150426.2318121-4-cian.ferriter@intel.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Build some AVX512 code on older compilers. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
| ovsrobot/intel-ovs-compilation | success | test: success |
> -----Original Message----- > From: Ferriter, Cian <cian.ferriter@intel.com> > Sent: Friday, April 29, 2022 8:34 PM > To: ovs-dev@openvswitch.org > Cc: Ferriter, Cian <cian.ferriter@intel.com>; Van Haaren, Harry > <harry.van.haaren@intel.com>; Pai G, Sunil <sunil.pai.g@intel.com> > Subject: [PATCH v4 3/5] dpif-netdev-extract: Remove unnecessary compiler > targets. > > No instructions from the AVX512VL ISA are used. > > Compilation for the AVX512F ISA is already enabled in lib/automake.mk for > the dpif-netdev-lookup-avx512-gather.c file because it's part of the > libopenvswitchavx512.la library. It doesn't need to be enabled at a > function level. > > Remove both of these unnecessary function-level compiler target > attributes. > > Signed-off-by: Cian Ferriter <cian.ferriter@intel.com> > Changes LGTM, Acked-by: Sunil Pai G <sunil.pai.g@intel.com>
diff --git a/lib/dpif-netdev-extract-avx512.c b/lib/dpif-netdev-extract-avx512.c index a0fedb137..2815bf480 100644 --- a/lib/dpif-netdev-extract-avx512.c +++ b/lib/dpif-netdev-extract-avx512.c @@ -628,8 +628,6 @@ mfex_avx512_process(struct dp_packet_batch *packets, #define DECLARE_MFEX_FUNC(name, profile) \ uint32_t \ -__attribute__((__target__("avx512f"))) \ -__attribute__((__target__("avx512vl"))) \ __attribute__((__target__("avx512vbmi"))) \ mfex_avx512_vbmi_##name(struct dp_packet_batch *packets, \ struct netdev_flow_key *keys, uint32_t keys_size,\ @@ -641,8 +639,6 @@ mfex_avx512_vbmi_##name(struct dp_packet_batch *packets, \ } \ \ uint32_t \ -__attribute__((__target__("avx512f"))) \ -__attribute__((__target__("avx512vl"))) \ mfex_avx512_##name(struct dp_packet_batch *packets, \ struct netdev_flow_key *keys, uint32_t keys_size, \ odp_port_t in_port, struct dp_netdev_pmd_thread \
No instructions from the AVX512VL ISA are used. Compilation for the AVX512F ISA is already enabled in lib/automake.mk for the dpif-netdev-lookup-avx512-gather.c file because it's part of the libopenvswitchavx512.la library. It doesn't need to be enabled at a function level. Remove both of these unnecessary function-level compiler target attributes. Signed-off-by: Cian Ferriter <cian.ferriter@intel.com> --- v4: * Remove the 'avx512f' target since it's also unnecessary. * Sunil acked the v3 version of this commit, but since it's changed, I'm not carrying the ack over. --- lib/dpif-netdev-extract-avx512.c | 4 ---- 1 file changed, 4 deletions(-)