| Message ID | 20220422120311.19569-1-david.marchand@redhat.com |
|---|---|
| State | Accepted |
| Commit | c896bffd8c594fff2d88c8e61d617272d5a7c94c |
| Headers | show |
| Series | [ovs-dev] netdev-dpdk: Remove a leftover lock annotation. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
| ovsrobot/intel-ovs-compilation | success | test: success |
> Subject: [ovs-dev] [PATCH] netdev-dpdk: Remove a leftover lock annotation. > > A lock annotation was left behind after removing the nonpmd mutex. > Remove it. > > Fixes: 1166b0d82043 ("netdev-dpdk: Remove useless nonpmd_mempool_mutex.") > Signed-off-by: David Marchand <david.marchand@redhat.com> > --- > lib/netdev-dpdk.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index > e0a2dccf5c..c9ef2be855 100644 > --- a/lib/netdev-dpdk.c > +++ b/lib/netdev-dpdk.c > @@ -2753,7 +2753,6 @@ dpdk_copy_dp_packet_to_mbuf(struct rte_mempool *mp, > struct dp_packet *pkt_orig) > /* Tx function. Transmit packets indefinitely */ static void > dpdk_do_tx_copy(struct netdev *netdev, int qid, struct dp_packet_batch > *batch) > - OVS_NO_THREAD_SAFETY_ANALYSIS LGTM, Acked-by: Sunil Pai G <sunil.pai.g@intel.com>
On 4/25/22 17:24, Pai G, Sunil wrote: >> Subject: [ovs-dev] [PATCH] netdev-dpdk: Remove a leftover lock annotation. >> >> A lock annotation was left behind after removing the nonpmd mutex. >> Remove it. >> >> Fixes: 1166b0d82043 ("netdev-dpdk: Remove useless nonpmd_mempool_mutex.") >> Signed-off-by: David Marchand <david.marchand@redhat.com> >> --- >> lib/netdev-dpdk.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index >> e0a2dccf5c..c9ef2be855 100644 >> --- a/lib/netdev-dpdk.c >> +++ b/lib/netdev-dpdk.c >> @@ -2753,7 +2753,6 @@ dpdk_copy_dp_packet_to_mbuf(struct rte_mempool *mp, >> struct dp_packet *pkt_orig) >> /* Tx function. Transmit packets indefinitely */ static void >> dpdk_do_tx_copy(struct netdev *netdev, int qid, struct dp_packet_batch >> *batch) >> - OVS_NO_THREAD_SAFETY_ANALYSIS > > LGTM, > > Acked-by: Sunil Pai G <sunil.pai.g@intel.com> Thanks! Applied to master and branch-2.17. Best regards, Ilya Maximets.
diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index e0a2dccf5c..c9ef2be855 100644 --- a/lib/netdev-dpdk.c +++ b/lib/netdev-dpdk.c @@ -2753,7 +2753,6 @@ dpdk_copy_dp_packet_to_mbuf(struct rte_mempool *mp, struct dp_packet *pkt_orig) /* Tx function. Transmit packets indefinitely */ static void dpdk_do_tx_copy(struct netdev *netdev, int qid, struct dp_packet_batch *batch) - OVS_NO_THREAD_SAFETY_ANALYSIS { const size_t batch_cnt = dp_packet_batch_size(batch); #if !defined(__CHECKER__) && !defined(_WIN32)
A lock annotation was left behind after removing the nonpmd mutex. Remove it. Fixes: 1166b0d82043 ("netdev-dpdk: Remove useless nonpmd_mempool_mutex.") Signed-off-by: David Marchand <david.marchand@redhat.com> --- lib/netdev-dpdk.c | 1 - 1 file changed, 1 deletion(-)