From patchwork Tue Jan 25 09:41:25 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wan Junjie X-Patchwork-Id: 1583951 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=bytedance-com.20210112.gappssmtp.com header.i=@bytedance-com.20210112.gappssmtp.com header.a=rsa-sha256 header.s=20210112 header.b=TpHMavzd; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.137; helo=smtp4.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4Jjhhy4mZmz9sXM for ; Tue, 25 Jan 2022 20:42:26 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 4EB35415A2; Tue, 25 Jan 2022 09:42:24 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ijExUfAc4EPq; Tue, 25 Jan 2022 09:42:23 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp4.osuosl.org (Postfix) with ESMTPS id 9D1D54159D; Tue, 25 Jan 2022 09:42:22 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 59E25C0039; Tue, 25 Jan 2022 09:42:22 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 42ECBC002F for ; Tue, 25 Jan 2022 09:42:21 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 23B0683E18 for ; Tue, 25 Jan 2022 09:42:21 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp1.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=bytedance-com.20210112.gappssmtp.com Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jTFCk6CIu8pk for ; Tue, 25 Jan 2022 09:42:20 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) by smtp1.osuosl.org (Postfix) with ESMTPS id 66CA583DFB for ; Tue, 25 Jan 2022 09:42:20 +0000 (UTC) Received: by mail-pl1-x62b.google.com with SMTP id k17so1171812plk.0 for ; Tue, 25 Jan 2022 01:42:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=MK5vcqvqzW6vMBjJPDqWTsTYifxUJmyy3UD4/flRGG4=; b=TpHMavzdbp+XgDYnPIn1R/DwdRN27P1pz4Tm6MNPn1Orsgcqvqy8OxvDH+QpQzYgiM vkTGXIxpIvYq3PPf/Jx6CqKCPIN1UAaHRIKKty4bw6ck70J2FvVJ2lXNfh+qAI00/sxQ igCrMSzNpiK8EBhdnYZcgon3JzpoJfsBTlyNcLI7ZhVVg4mm+3TZwxUqfmPb1MWUmim+ m7dfKVLiqZFUs4WzVSPPO3fQxeNZvTp8z0625CHAPRWBDr1Ogt5Y7z7eySyioNldayPX v++aS5OZpw6t9lXJCQTM3PN5aH2iBaWvIHIreVi1dRIlsQYslxKB5dnZq0qCyB41ZJjt 8bXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=MK5vcqvqzW6vMBjJPDqWTsTYifxUJmyy3UD4/flRGG4=; b=QbWkC2n3pP9tTQ6SQqa7Y95066Lc8Yhsv8rAjOF2Ksrr5rwdGEwVyFkAAg9w6iRtrR qFgalB2Yxl1wD4dJl0MEa6RjldFfuBy55+E1NIDIeEyPy7745MWy+O6HyozaTLvycpOO zlfCY3GxPaOUaxR8OHD/2QE10qBLlxXtAduw5n43iRm67DaJ8Xf6mncTguV3+Rl6Jqvm VKL/8gp8pdy+1F+xGYWv6ITsYLZ49rUp8cLVqRtgogtJfMkTr06olnnfZnTuFldt/msB zGTxi6a8j2EoZ5GQXxp1LCwS2Th3MIAtW+noFgv4cpZIFEsbNaPeLKYskhf4kzjJBOUI SuVQ== X-Gm-Message-State: AOAM532mjIVarHiVwXpkCQx75mQUNYxa3rVFzK1oSnb8p0BozHrWwrXK Wfb4pP023dzRt8rBiWvRxSJ2NmS/6A56N/lo X-Google-Smtp-Source: ABdhPJwc1HjFN2y9JMcBOocr+Ofk1EsGgP9KXmgZ/cOwlnaYujZbJZeLjhFnls8oGfXbFan2lDpbJA== X-Received: by 2002:a17:90b:4b42:: with SMTP id mi2mr2528447pjb.245.1643103739559; Tue, 25 Jan 2022 01:42:19 -0800 (PST) Received: from C02Z10J4LVCK.bytedance.net ([139.177.225.253]) by smtp.gmail.com with ESMTPSA id mt14sm56254pjb.21.2022.01.25.01.42.17 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 25 Jan 2022 01:42:19 -0800 (PST) From: Wan Junjie To: dev@openvswitch.org, Kevin Traynor Date: Tue, 25 Jan 2022 17:41:25 +0800 Message-Id: <20220125094125.33915-1-wanjunjie@bytedance.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20220124111439.2911-1-wanjunjie@bytedance.com> References: <20220124111439.2911-1-wanjunjie@bytedance.com> MIME-Version: 1.0 Subject: [ovs-dev] [PATCH v2] netdev-dpdk: add mempool count in cmd get-mempool-info X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" The ```rte_mempool_avail_count``` and ```rte_mempool_in_use_count``` can tell us the usage of the mempool. It could be helpful for debug on any memleak in the mempool. Add a line in the cmd's output. - Count: avail (118988), in use (12084) Acked-by: Aaron Conole Signed-off-by: Wan Junjie Acked-by: Kevin Traynor --- v2: remove prefix '-' from output --- lib/netdev-dpdk.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index b6b29c75e..334e348fc 100644 --- a/lib/netdev-dpdk.c +++ b/lib/netdev-dpdk.c @@ -3864,6 +3864,9 @@ netdev_dpdk_get_mempool_info(struct unixctl_conn *conn, ovs_mutex_lock(&dpdk_mp_mutex); rte_mempool_dump(stream, dev->dpdk_mp->mp); + fprintf(stream, " count: avail (%u), in use (%u)\n", + rte_mempool_avail_count(dev->dpdk_mp->mp), + rte_mempool_in_use_count(dev->dpdk_mp->mp)); ovs_mutex_unlock(&dpdk_mp_mutex); ovs_mutex_unlock(&dev->mutex);