| Message ID | 20220119172530.32149-1-david.marchand@redhat.com |
|---|---|
| State | Accepted |
| Commit | 8723063c3c30177c3fe9c1b34db0066ec7abeb1d |
| Headers | show |
| Series | [ovs-dev] system-dpdk: Fix MFEX logs check. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
On 19 Jan 2022, at 18:25, David Marchand wrote: > Some warning logs must be waived when using the net/pcap DPDK driver. > Those logs can affect different DPDK drivers (like mlx5) and the tests in > system-dpdk are not testing MTU and Rx checksum, we might as well ignore > those warnings from OVS. > > Fixes: d446dcb7e03f ("system-dpdk: Refactor common logs matching.") > Signed-off-by: David Marchand <david.marchand@redhat.com> Reviewed and verified in my setup (where I did not get these specific errors), but the tests do pass. Acked-by: Eelco Chaudron <echaudro@redhat.com>
> -----Original Message----- > From: David Marchand <david.marchand@redhat.com> > Sent: Wednesday 19 January 2022 17:26 > To: dev@openvswitch.org > Cc: Stokes, Ian <ian.stokes@intel.com>; Phelan, Michael <michael.phelan@intel.com>; Ferriter, Cian > <cian.ferriter@intel.com>; i.maximets@ovn.org; ktraynor@redhat.com > Subject: [PATCH] system-dpdk: Fix MFEX logs check. > > Some warning logs must be waived when using the net/pcap DPDK driver. > Those logs can affect different DPDK drivers (like mlx5) and the tests in > system-dpdk are not testing MTU and Rx checksum, we might as well ignore > those warnings from OVS. > > Fixes: d446dcb7e03f ("system-dpdk: Refactor common logs matching.") > Signed-off-by: David Marchand <david.marchand@redhat.com> Reviewed and tested. This fixes the errors I see prior to applying the patch. The MFEX tests now pass: OVS-DPDK unit tests 6: OVS-DPDK - MFEX Autovalidator ok 7: OVS-DPDK - MFEX Autovalidator Fuzzy ok 8: OVS-DPDK - MFEX Configuration ok Acked-by: Cian Ferriter <cian.ferriter@intel.com>
> > -----Original Message----- > > From: David Marchand <david.marchand@redhat.com> > > Sent: Wednesday 19 January 2022 17:26 > > To: dev@openvswitch.org > > Cc: Stokes, Ian <ian.stokes@intel.com>; Phelan, Michael > <michael.phelan@intel.com>; Ferriter, Cian > > <cian.ferriter@intel.com>; i.maximets@ovn.org; ktraynor@redhat.com > > Subject: [PATCH] system-dpdk: Fix MFEX logs check. > > > > Some warning logs must be waived when using the net/pcap DPDK driver. > > Those logs can affect different DPDK drivers (like mlx5) and the tests in > > system-dpdk are not testing MTU and Rx checksum, we might as well ignore > > those warnings from OVS. > > > > Fixes: d446dcb7e03f ("system-dpdk: Refactor common logs matching.") > > Signed-off-by: David Marchand <david.marchand@redhat.com> > > Reviewed and tested. This fixes the errors I see prior to applying the patch. The > MFEX tests now pass: > > OVS-DPDK unit tests > > 6: OVS-DPDK - MFEX Autovalidator ok > 7: OVS-DPDK - MFEX Autovalidator Fuzzy ok > 8: OVS-DPDK - MFEX Configuration ok > > Acked-by: Cian Ferriter <cian.ferriter@intel.com> Thanks David, Eelco & Cian, applied to master and 2.17. Thanks Ian
diff --git a/tests/system-dpdk.at b/tests/system-dpdk.at index 1dd7aae1b7..9384cf7f0f 100644 --- a/tests/system-dpdk.at +++ b/tests/system-dpdk.at @@ -5,8 +5,10 @@ AT_BANNER([OVS-DPDK unit tests]) m4_define([SYSTEM_DPDK_ALLOWED_LOGS],[ \@does not exist. The Open vSwitch kernel module is probably not loaded.@d +\@does not support MTU configuration,@d \@EAL: No \(available\|free\) .*hugepages reported@d \@Failed to enable flow control@d +\@Rx checksum offload is not supported on@d \@TELEMETRY: No legacy callbacks, legacy socket not created@d ])
Some warning logs must be waived when using the net/pcap DPDK driver. Those logs can affect different DPDK drivers (like mlx5) and the tests in system-dpdk are not testing MTU and Rx checksum, we might as well ignore those warnings from OVS. Fixes: d446dcb7e03f ("system-dpdk: Refactor common logs matching.") Signed-off-by: David Marchand <david.marchand@redhat.com> --- tests/system-dpdk.at | 2 ++ 1 file changed, 2 insertions(+)