diff mbox series

[ovs-dev,v4,5/9] pmd.at: Add test-cases for ovs-actions commands.

Message ID 20220105165349.3447695-6-emma.finn@intel.com
State Superseded
Headers show
Series Actions Infrastructure + Optimizations | expand

Checks

Context Check Description
ovsrobot/apply-robot success apply and check: success
ovsrobot/github-robot-_Build_and_Test success github build: passed

Commit Message

Emma Finn Jan. 5, 2022, 4:53 p.m. UTC 
From: Kumar Amber <kumar.amber@intel.com>

Added separate test-case for ovs-actions get/set commands:
1023: PMD - ovs-actions configuration

The above added tests are to test the commands which are used
to either get or set the ovs-actions function pointers to
various different implementations like AVX512 or auto-validator
based on different CPU ISA supported.

Signed-off-by: Kumar Amber <kumar.amber@intel.com>
---
 tests/pmd.at | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

Comments

Van Haaren, Harry Jan. 6, 2022, 1:11 p.m. UTC | #1 
> -----Original Message-----
> From: Finn, Emma <emma.finn@intel.com>
> Sent: Wednesday, January 5, 2022 4:54 PM
> To: dev@openvswitch.org; Van Haaren, Harry <harry.van.haaren@intel.com>;
> Amber, Kumar <kumar.amber@intel.com>
> Subject: [PATCH v4 5/9] pmd.at: Add test-cases for ovs-actions commands.
> 
> From: Kumar Amber <kumar.amber@intel.com>
> 
> Added separate test-case for ovs-actions get/set commands:
> 1023: PMD - ovs-actions configuration
> 
> The above added tests are to test the commands which are used
> to either get or set the ovs-actions function pointers to
> various different implementations like AVX512 or auto-validator
> based on different CPU ISA supported.
> 
> Signed-off-by: Kumar Amber <kumar.amber@intel.com>

This is a small patch - consider squashing it into the commit which
introduces the commands in the first place?

This test-case is failing here, id is 1025 when this set is applied to current master;
diff mbox series

Patch

diff --git a/tests/pmd.at b/tests/pmd.at
index c875a744f..4384652ff 100644
--- a/tests/pmd.at
+++ b/tests/pmd.at
@@ -1160,3 +1160,23 @@  ovs-appctl: ovs-vswitchd: server returned an error
 
 OVS_VSWITCHD_STOP
 AT_CLEANUP
+
+AT_SETUP([PMD - ovs-actions configuration])
+OVS_VSWITCHD_START([], [], [], [--dummy-numa 0,0])
+AT_CHECK([ovs-vsctl add-port br0 p1 -- set Interface p1 type=dummy-pmd])
+
+AT_CHECK([ovs-vsctl show], [], [stdout])
+AT_CHECK([ovs-appctl dpif-netdev/action-impl-get | grep "scalar"], [], [dnl
+  scalar (available: True, active: True)
+])
+
+AT_CHECK([ovs-appctl dpif-netdev/action-impl-get | grep "autovalidator"], [], [dnl
+  autovalidator (available: True, active: False)
+])
+
+AT_CHECK([ovs-appctl dpif-netdev/action-impl-set scalar], [0], [dnl
+action implementation set to scalar.
+])
+
+OVS_VSWITCHD_STOP
+AT_CLEANUP
\ No newline at end of file