| Message ID | 20220103231603.3396540-1-i.maximets@ovn.org |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev] dpif-netdev-extract: Change availability log level to DBG. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
Hi IIlya, Thanks for the patch. Tested and Reviewed all looks good. > -----Original Message----- > From: Ilya Maximets <i.maximets@ovn.org> > Sent: Tuesday, January 4, 2022 4:46 AM > To: ovs-dev@openvswitch.org > Cc: David Marchand <dmarchan@redhat.com>; Amber, Kumar > <kumar.amber@intel.com>; Ilya Maximets <i.maximets@ovn.org> > Subject: [PATCH] dpif-netdev-extract: Change availability log level to DBG. > > Availability logs are not essential for a normal run. The same information can be > obtained via appctl in runtime. They also can not show if particular > implementation will actually be used or not, hence not useful for post-crash > investigations. Moving to DBG level to avoid bulky unnecessary logging. > > Additionally making them a bit more readable. > > Signed-off-by: Ilya Maximets <i.maximets@ovn.org> > --- > lib/dpif-netdev-private-extract.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/dpif-netdev-private-extract.c b/lib/dpif-netdev-private-extract.c > index 5f29861b8..a29bdcfa7 100644 > --- a/lib/dpif-netdev-private-extract.c > +++ b/lib/dpif-netdev-private-extract.c > @@ -116,8 +116,8 @@ dpif_miniflow_extract_init(void) > /* Return zero is success, non-zero means error. */ > avail = (mfex_impls[i].probe() == 0); > } > - VLOG_INFO("Miniflow Extract implementation %s (available: %s)\n", > - mfex_impls[i].name, avail ? "available" : "not available"); > + VLOG_DBG("Miniflow Extract implementation '%s' %s available.", > + mfex_impls[i].name, avail ? "is" : "is not"); > mfex_impls[i].available = avail; > } > > -- > 2.31.1 Acked-by: Kumar Amber <kumar.amber@intel.com> Regards Amber
On 1/4/22 12:47, Amber, Kumar wrote: > Hi IIlya, > > Thanks for the patch. > Tested and Reviewed all looks good. > > > >> -----Original Message----- >> From: Ilya Maximets <i.maximets@ovn.org> >> Sent: Tuesday, January 4, 2022 4:46 AM >> To: ovs-dev@openvswitch.org >> Cc: David Marchand <dmarchan@redhat.com>; Amber, Kumar >> <kumar.amber@intel.com>; Ilya Maximets <i.maximets@ovn.org> >> Subject: [PATCH] dpif-netdev-extract: Change availability log level to DBG. >> >> Availability logs are not essential for a normal run. The same information can be >> obtained via appctl in runtime. They also can not show if particular >> implementation will actually be used or not, hence not useful for post-crash >> investigations. Moving to DBG level to avoid bulky unnecessary logging. >> >> Additionally making them a bit more readable. >> >> Signed-off-by: Ilya Maximets <i.maximets@ovn.org> >> --- >> lib/dpif-netdev-private-extract.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/lib/dpif-netdev-private-extract.c b/lib/dpif-netdev-private-extract.c >> index 5f29861b8..a29bdcfa7 100644 >> --- a/lib/dpif-netdev-private-extract.c >> +++ b/lib/dpif-netdev-private-extract.c >> @@ -116,8 +116,8 @@ dpif_miniflow_extract_init(void) >> /* Return zero is success, non-zero means error. */ >> avail = (mfex_impls[i].probe() == 0); >> } >> - VLOG_INFO("Miniflow Extract implementation %s (available: %s)\n", >> - mfex_impls[i].name, avail ? "available" : "not available"); >> + VLOG_DBG("Miniflow Extract implementation '%s' %s available.", >> + mfex_impls[i].name, avail ? "is" : "is not"); >> mfex_impls[i].available = avail; >> } >> >> -- >> 2.31.1 > > Acked-by: Kumar Amber <kumar.amber@intel.com> Thanks! Applied. Best regards, Ilya Maximets.
diff --git a/lib/dpif-netdev-private-extract.c b/lib/dpif-netdev-private-extract.c index 5f29861b8..a29bdcfa7 100644 --- a/lib/dpif-netdev-private-extract.c +++ b/lib/dpif-netdev-private-extract.c @@ -116,8 +116,8 @@ dpif_miniflow_extract_init(void) /* Return zero is success, non-zero means error. */ avail = (mfex_impls[i].probe() == 0); } - VLOG_INFO("Miniflow Extract implementation %s (available: %s)\n", - mfex_impls[i].name, avail ? "available" : "not available"); + VLOG_DBG("Miniflow Extract implementation '%s' %s available.", + mfex_impls[i].name, avail ? "is" : "is not"); mfex_impls[i].available = avail; }
Availability logs are not essential for a normal run. The same information can be obtained via appctl in runtime. They also can not show if particular implementation will actually be used or not, hence not useful for post-crash investigations. Moving to DBG level to avoid bulky unnecessary logging. Additionally making them a bit more readable. Signed-off-by: Ilya Maximets <i.maximets@ovn.org> --- lib/dpif-netdev-private-extract.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)