diff mbox series

[ovs-dev,v1] dpdk-stub: Change the ERR log to DBG.

Message ID 20210930084147.2204893-1-kumar.amber@intel.com
State Accepted
Delegated to: Ilya Maximets
Headers show
Series [ovs-dev,v1] dpdk-stub: Change the ERR log to DBG. | expand

Checks

Context Check Description
ovsrobot/apply-robot success apply and check: success
ovsrobot/github-robot-_Build_and_Test success github build: passed

Commit Message

Kumar Amber Sept. 30, 2021, 8:41 a.m. UTC 
When DPDK is not availble and avx512 looks for isa
the function returns an error log which results in
unit test failures.

By logging a debug level log, this still shows up
in the vswitchd.log file, but won't fail unit tests
that do not have DPDK built in.

Suggested by: Ilya Maximets <i.maximets@ovn.org>
Signed-off-by: Kumar Amber <kumar.amber@intel.com>
---
 lib/dpdk-stub.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ilya Maximets Oct. 12, 2021, 7:18 p.m. UTC | #1 
On 9/30/21 10:41, Kumar Amber wrote:
> When DPDK is not availble and avx512 looks for isa
> the function returns an error log which results in
> unit test failures.
> 
> By logging a debug level log, this still shows up
> in the vswitchd.log file, but won't fail unit tests
> that do not have DPDK built in.
> 
> Suggested by: Ilya Maximets <i.maximets@ovn.org>
> Signed-off-by: Kumar Amber <kumar.amber@intel.com>
> ---
>  lib/dpdk-stub.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/dpdk-stub.c b/lib/dpdk-stub.c
> index b7d577870..fe24f9abd 100644
> --- a/lib/dpdk-stub.c
> +++ b/lib/dpdk-stub.c
> @@ -83,7 +83,7 @@ bool
>  dpdk_get_cpu_has_isa(const char *arch OVS_UNUSED,
>                       const char *feature OVS_UNUSED)
>  {
> -    VLOG_ERR_ONCE("DPDK not supported in this version of Open vSwitch, "
> +    VLOG_DBG_ONCE("DPDK not supported in this version of Open vSwitch, "
>                    "cannot use CPU flag based optimizations");
>      return false;
>  }
> 

Thanks!  Applied and backported.

Best regards, Ilya Maximets.
diff mbox series

Patch

diff --git a/lib/dpdk-stub.c b/lib/dpdk-stub.c
index b7d577870..fe24f9abd 100644
--- a/lib/dpdk-stub.c
+++ b/lib/dpdk-stub.c
@@ -83,7 +83,7 @@  bool
 dpdk_get_cpu_has_isa(const char *arch OVS_UNUSED,
                      const char *feature OVS_UNUSED)
 {
-    VLOG_ERR_ONCE("DPDK not supported in this version of Open vSwitch, "
+    VLOG_DBG_ONCE("DPDK not supported in this version of Open vSwitch, "
                   "cannot use CPU flag based optimizations");
     return false;
 }