diff mbox series

[ovs-dev,v2,5/6] netdev-offload-dpdk: Extract raw_encap and output netdev by parse_clone_actions

Message ID 20210823160140.12788-6-salems@nvidia.com
State New
Headers show
Series Adding support for multiple destinations | expand

Checks

Context Check Description
ovsrobot/apply-robot success apply and check: success
ovsrobot/github-robot-_Build_and_Test success github build: passed

Commit Message

Salem Sol Aug. 23, 2021, 4:01 p.m. UTC 
From: Noa Levy <noae@nvidia.com>

Extract the raw_encap and the output netdev of cloned actions as a pre-step
towards using them embedded in a sample action.

Co-authored-by: Salem Sol <salems@nvidia.com>
Signed-off-by: Noa Levy <noae@nvidia.com>
Signed-off-by: Salem Sol <salems@nvidia.com>
---
 lib/netdev-offload-dpdk.c | 39 +++++++++++++++++++++++++++------------
 1 file changed, 27 insertions(+), 12 deletions(-)
diff mbox series

Patch

diff --git a/lib/netdev-offload-dpdk.c b/lib/netdev-offload-dpdk.c
index efd7c844d..251515707 100644
--- a/lib/netdev-offload-dpdk.c
+++ b/lib/netdev-offload-dpdk.c
@@ -1707,9 +1707,12 @@  static int
 parse_clone_actions(struct netdev *netdev,
                     struct flow_actions *actions,
                     const struct nlattr *clone_actions,
-                    const size_t clone_actions_len)
+                    const size_t clone_actions_len,
+                    int *outdev_id,
+                    struct rte_flow_action_raw_encap *raw_encap)
 {
     const struct nlattr *ca;
+    struct netdev *outdev;
     unsigned int cleft;
 
     NL_ATTR_FOR_EACH_UNSAFE (ca, cleft, clone_actions, clone_actions_len) {
@@ -1717,23 +1720,35 @@  parse_clone_actions(struct netdev *netdev,
 
         if (clone_type == OVS_ACTION_ATTR_TUNNEL_PUSH) {
             const struct ovs_action_push_tnl *tnl_push = nl_attr_get(ca);
-            struct rte_flow_action_raw_encap *raw_encap;
-
-            if (tnl_push->tnl_type == OVS_VPORT_TYPE_VXLAN &&
-                !add_vxlan_encap_action(actions, tnl_push->header)) {
-                continue;
+            struct rte_flow_action_raw_encap *action_raw_encap = NULL;
+
+            if (!raw_encap) {
+                action_raw_encap = xzalloc(sizeof *action_raw_encap);
+                raw_encap = action_raw_encap;
+                if (tnl_push->tnl_type == OVS_VPORT_TYPE_VXLAN &&
+                    !add_vxlan_encap_action(actions, tnl_push->header)) {
+                    continue;
+                }
             }
 
-            raw_encap = xzalloc(sizeof *raw_encap);
             raw_encap->data = (uint8_t *) tnl_push->header;
             raw_encap->preserve = NULL;
             raw_encap->size = tnl_push->header_len;
 
-            add_flow_action(actions, RTE_FLOW_ACTION_TYPE_RAW_ENCAP,
-                            raw_encap);
+            if (action_raw_encap) {
+                add_flow_action(actions, RTE_FLOW_ACTION_TYPE_RAW_ENCAP,
+                                action_raw_encap);
+            }
         } else if (clone_type == OVS_ACTION_ATTR_OUTPUT) {
-            if (add_output_action(netdev, actions, ca)) {
-                return -1;
+            if (actions) {
+                if (add_output_action(netdev, actions, ca)) {
+                    return -1;
+                }
+            } else {
+                if (get_netdev_by_port(netdev, ca, outdev_id, &outdev)) {
+                    return -1;
+                }
+                netdev_close(outdev);
             }
         } else {
             VLOG_DBG_RL(&rl,
@@ -1889,7 +1904,7 @@  parse_flow_actions(struct netdev *netdev,
             size_t clone_actions_len = nl_attr_get_size(nla);
 
             if (parse_clone_actions(netdev, actions, clone_actions,
-                                    clone_actions_len)) {
+                                    clone_actions_len, NULL, NULL)) {
                 return -1;
             }
 #ifdef ALLOW_EXPERIMENTAL_API /* Packet restoration API required. */