From patchwork Wed Aug 18 02:22:15 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kaixi Fan X-Patchwork-Id: 1517902 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.137; helo=smtp4.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=bytedance-com.20150623.gappssmtp.com header.i=@bytedance-com.20150623.gappssmtp.com header.a=rsa-sha256 header.s=20150623 header.b=pKmjcCmf; dkim-atps=neutral Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4GqBWk12XQz9s1l for ; Wed, 18 Aug 2021 12:22:57 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 94E80402F2; Wed, 18 Aug 2021 02:22:53 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id iQSplcl27zFf; Wed, 18 Aug 2021 02:22:49 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp4.osuosl.org (Postfix) with ESMTPS id E1356402D8; Wed, 18 Aug 2021 02:22:48 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id B3242C001A; Wed, 18 Aug 2021 02:22:48 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 427A7C000E for ; Wed, 18 Aug 2021 02:22:47 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 2B66540222 for ; Wed, 18 Aug 2021 02:22:47 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp2.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=bytedance-com.20150623.gappssmtp.com Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7HMdZPWXlES5 for ; Wed, 18 Aug 2021 02:22:42 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by smtp2.osuosl.org (Postfix) with ESMTPS id DE6FA401B4 for ; Wed, 18 Aug 2021 02:22:42 +0000 (UTC) Received: by mail-pj1-x102d.google.com with SMTP id mq2-20020a17090b3802b0290178911d298bso1360376pjb.1 for ; Tue, 17 Aug 2021 19:22:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=nUTRJq9UadwH99/d1kuhebEbaWd7uB4U5gW7j+M7gA0=; b=pKmjcCmfMRgBqnAm1OpGQ0XmXwKi2xgDsTcFs4BnZMTHFWm0kDuYRsKt6lltn02knG pwFfpmL/XT0MX7if8BADUxmkKgKwtB3PbGDLeR/tWuc8xgrsgmzlnecAyekT6kg9O/Hm rSP8/0TOjWq5ZC7e4FSEKJd0Mjfb3yAQn44j9XcNh1dTZ/IaF8eYenKPq2NstDbbY4u8 Ahjp9HC/s7qkOCWWV3hWqopRpmbHjr9ptNkblSPCo9AVemWBORkDKap2BmRiZ21BvQPy MUb3VAsdOq9jizy+lgh4EC/2uRmZJ2TifBkk5Bt5m10DBzUlalnRzPyvjuYviRI5Y1m6 PbkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=nUTRJq9UadwH99/d1kuhebEbaWd7uB4U5gW7j+M7gA0=; b=Ia8V9GjI7Uk3qmPcQ7S2GkEBryixqcXJmC5+beFVUujEyWgO//d48MZHaKy/zUYN8g EDwQa9vDaYZBNt9hWZTMpVpCOfLfVCTD7pQ3HczbIey8shPfCpLKeZK9Ta1tM+5Awux/ I7hn9E0D/ytx0JpwmR6cUL++MRp1VkUSaQwO/0WqQdq6Z1J9J2bEpC/D13S5OadpLCCk nd0cwPYa6LZ7JW/RkMdVbls+k1fI/PVzqO62kkIfdEwW3e+c62tiV5x1j28f/2mcxnvI ciqMiRC5DKGiEFiuaIAaOAW2e4UHECe56l+sZDW2EH4ulO6K2fgc0YiYCDrWHu3fIejv QdTg== X-Gm-Message-State: AOAM533I3h1huYrnnUR+lK1LAeyR24hZmQBj8/1IuGxSgh2bgSZYc59u D1AoG/BvXl4snUI23o1XVqaG+1s8ELOOEw== X-Google-Smtp-Source: ABdhPJzDNf0RwID5c0mFQxo/BtQbjjnYzflEKMU9RqX6j5eUUKMR21j8EWGi3FEBO/vTNlR6TcYzuQ== X-Received: by 2002:a17:902:ab52:b0:12d:92b8:60c7 with SMTP id ij18-20020a170902ab5200b0012d92b860c7mr5388491plb.44.1629253361939; Tue, 17 Aug 2021 19:22:41 -0700 (PDT) Received: from localhost.localdomain ([139.177.225.245]) by smtp.gmail.com with ESMTPSA id t5sm4095938pfd.133.2021.08.17.19.22.39 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Aug 2021 19:22:41 -0700 (PDT) From: fankaixi.li@bytedance.com To: dev@openvswitch.org, netdev@vger.kernel.org Date: Wed, 18 Aug 2021 10:22:15 +0800 Message-Id: <20210818022215.5979-1-fankaixi.li@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) MIME-Version: 1.0 Cc: Cong Wang , xiexiaohui Subject: [ovs-dev] [PATCH] ovs: clear skb->tstamp in forwarding path X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" From: kaixi.fan fq qdisc requires tstamp to be cleared in the forwarding path. Now ovs doesn't clear skb->tstamp. We encountered a problem with linux version 5.4.56 and ovs version 2.14.1, and packets failed to dequeue from qdisc when fq qdisc was attached to ovs port. Signed-off-by: kaixi.fan Signed-off-by: xiexiaohui Reviewed-by: Cong Wang --- net/openvswitch/vport.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/openvswitch/vport.c b/net/openvswitch/vport.c index 88deb5b41429..cf2ce5812489 100644 --- a/net/openvswitch/vport.c +++ b/net/openvswitch/vport.c @@ -507,6 +507,7 @@ void ovs_vport_send(struct vport *vport, struct sk_buff *skb, u8 mac_proto) } skb->dev = vport->dev; + skb->tstamp = 0; vport->ops->send(skb); return;