From patchwork Mon Jul 26 08:14:52 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eli Britstein X-Patchwork-Id: 1509891 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=Ei9ImoGr; dkim-atps=neutral Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4GYCRP4xnVz9sWS for ; Mon, 26 Jul 2021 18:15:45 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id D27E560854; Mon, 26 Jul 2021 08:15:42 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Djxy9KvsgXzC; Mon, 26 Jul 2021 08:15:41 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp3.osuosl.org (Postfix) with ESMTPS id E117E60849; Mon, 26 Jul 2021 08:15:40 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id A1E95C0010; Mon, 26 Jul 2021 08:15:40 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 4221DC000E for ; Mon, 26 Jul 2021 08:15:39 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 1DAB640474 for ; Mon, 26 Jul 2021 08:15:39 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp4.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=nvidia.com Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ePl-S5nuuWGZ for ; Mon, 26 Jul 2021 08:15:38 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on20601.outbound.protection.outlook.com [IPv6:2a01:111:f400:7e88::601]) by smtp4.osuosl.org (Postfix) with ESMTPS id 1ADFC40470 for ; Mon, 26 Jul 2021 08:15:37 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NJNl73TYEoNACmqTvhDBbTsPKdw8kAgZZJS8wWT7xN5uu+MyBA+pDhdmTo5TNwGp/iX7UcEj5pfZWNKxa4JaprBKpFPqUrpL2UndNzfEMk+MJTQRMDvixIWFaJkJbqcjmvjydS7G7rIH2clQAmQp2oYv47O8/N7vlb/Y40ezTEH1ZI0dWk4JfLFNr80MkYNOX/jvN6qZZZLWIFCDiCzxLQtcrix0CMLecVHpuuZh1ofPs3pZx8xOo+lzEhzLWgfQvL5r4Lb9J396jeWTQpRu26ar9+lF5flsJQ/elwPCxhAZuSggT+a/ENRuR/WxWvX3w4OYWyIu0euviIQOuNhiXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KDpRjyFm4Q0oa7j6Mg+AT89n9FFWPnoa2PECUWMVL64=; b=JvB7lBW8pYfUF435u0DYESEYbYGgocP8LIxX69RDB40KktmCHN9OC1cJ/JfXS2m1xMWbEpWgEZK1M1VgWy0FIOjNeSZGcmllxSjL03Nhn62RK+eJp4nJ/kQ852BQ5++lDDXisncig4kXaagzSsruQhcffhEUwz6NxZL3ySy/qwQLPBJeXgLiwzr5Um3SsjcNOc5G0jCYq2/U9028+v/BlqZIm+vCxdKNy/VM4B5+0IPkYoZamI6aKHJK9DJYmFspPqd7co7zUU+1ZnzV5sPAhVOBRYtzSZQldHt5qBIRv0dI0Nq7wUzmJKokEEQ2iZ977odJ+6gND3NLIMM0aDASGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=redhat.com smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KDpRjyFm4Q0oa7j6Mg+AT89n9FFWPnoa2PECUWMVL64=; b=Ei9ImoGrKk/mC5GRN+9z7h/TVKvAkkZ2O6STHsFaO39BroUCHlT8gWHF5a/5jY/TYqRTivOugahgP8NMSYHd+x6UnHUf9rCmAUqNaRYJyQR4WfvWTUqR3hNKxS6MMsTFGazIEbhvVsn1bASxTTbjkVp0NUceBE6AI37MU4XFWxjQjHIKax7pU6IQzl/E9cXMPU01Uc/OlX4LpvM4YWowMvCCiBZftwAGOcpvdLCbfHAl21EhCY+bWzISojplEbyoiI0M5miat2TWNK/RH8cN6nI6c5KzxgYKA0aJeknPuVGVzfP2TaLLCpIPgleADot3UyZCxFhVtf/VHGYrCwFG2g== Received: from DM5PR07CA0074.namprd07.prod.outlook.com (2603:10b6:4:ad::39) by BYAPR12MB3350.namprd12.prod.outlook.com (2603:10b6:a03:ab::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4352.29; Mon, 26 Jul 2021 08:15:36 +0000 Received: from DM6NAM11FT023.eop-nam11.prod.protection.outlook.com (2603:10b6:4:ad:cafe::c4) by DM5PR07CA0074.outlook.office365.com (2603:10b6:4:ad::39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4352.25 via Frontend Transport; Mon, 26 Jul 2021 08:15:35 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by DM6NAM11FT023.mail.protection.outlook.com (10.13.173.96) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4352.24 via Frontend Transport; Mon, 26 Jul 2021 08:15:35 +0000 Received: from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 26 Jul 2021 08:15:19 +0000 To: , Ilya Maximets Date: Mon, 26 Jul 2021 11:14:52 +0300 Message-ID: <20210726081455.10632-2-elibr@nvidia.com> X-Mailer: git-send-email 2.18.1 In-Reply-To: <20210726081455.10632-1-elibr@nvidia.com> References: <20210726081455.10632-1-elibr@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 10d5e80b-9819-40fe-df50-08d9500d8bc1 X-MS-TrafficTypeDiagnostic: BYAPR12MB3350: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3968; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0imaD4OMDQL3AVyAcm9jaNemDv3RX24a+hLy4zOBRo0BDJkFe9nmm+rhzC5tzImxmMC5eMeBuo4XSqIzSWKsFbcQx/sShVQMgAeyGtmW6+xfExLJncLp6xNFIk6iItdv4xohfb9QlyD9Scya9wBbKCzchXjURUkD45zUvuUY6BJ+lV/yBycgoQIwiRLremmIq9N0yVz0A6LzjfrcAD8KrWfdH6xzdJbu5/DKZw7ErMmg0ZG6lOWnt0Xx8YZw40IySlRlTpWRT3+RoF92jCvxVlFBHc/u/YHLbNkV6R/V/HaC9tlL7nbnDLm80hAqdK7YKSgv6OVfcKCmN+2Og6Hg7o9yMrodn+zAm+7entE/JfT69FgxQ8OmXxonJ9CCknQnSug4fD4JnZKbrmQfHUTWkAMK3mZYNG04tpLG9d0pV94WCKyMqDRaF5m0W6RAzaVtFctVzdDIL4XeEOev1BrkEam0UaqEV76QiDiuU+shiY5iCBmD9joKl/ov/fTm+2yN0E2+gsP5GFZSTLVJVorIGh0qmDKPv2VKNr5ZL8aFs8aXZuPPB8Mbp5l2nQlZiym0z25DFfIYp/t2pUUNz0Dd/k0Wlq/jKxZ7nhdNw9TGyvD04W/V7fzA+qWga3N/SrEnv0Io0JIGdteCHW026XoJvzmMhEEj9EvGcT4lExYtdfo2FsD/6AY5h3JoaiRgjdpyAnVyq+gRDeILEiilzvBLEA== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(396003)(346002)(376002)(39860400002)(136003)(46966006)(36840700001)(36860700001)(83380400001)(82310400003)(7636003)(26005)(316002)(36906005)(6286002)(47076005)(356005)(36756003)(55016002)(82740400003)(5660300002)(426003)(70206006)(86362001)(70586007)(478600001)(4326008)(110136005)(8936002)(7696005)(2906002)(2616005)(54906003)(336012)(16526019)(8676002)(186003)(1076003)(107886003)(6666004); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2021 08:15:35.7902 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 10d5e80b-9819-40fe-df50-08d9500d8bc1 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT023.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB3350 Cc: Eli Britstein , David Marchand , Majd Dibbiny Subject: [ovs-dev] [PATCH V3 1/4] dpif-netdev: Do not flush PMD offloads on reload X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Eli Britstein via dev From: Eli Britstein Reply-To: Eli Britstein Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" Before flushing offloads of a removed port was supported by [1], it was necessary to flush the 'marks'. In doing so, all offloads of the PMD are removed, include the ones that are not related to the removed port and that are not modified following this removal. As a result such flows are evicted from being offloaded, and won't resume offloading. As PMD offload flush is not necessary, avoid it. [1] 62d1c28e9ce0 ("dpif-netdev: Flush offload rules upon port deletion.") Signed-off-by: Eli Britstein Reviewed-by: Gaetan Rivet --- lib/dpif-netdev.c | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index 59e326f11..b1fffbac7 100644 --- a/lib/dpif-netdev.c +++ b/lib/dpif-netdev.c @@ -2495,18 +2495,6 @@ mark_to_flow_disassociate(struct dp_netdev_pmd_thread *pmd, return ret; } -static void -flow_mark_flush(struct dp_netdev_pmd_thread *pmd) -{ - struct dp_netdev_flow *flow; - - CMAP_FOR_EACH (flow, mark_node, &flow_mark.mark_to_flow) { - if (flow->pmd_id == pmd->core_id) { - queue_netdev_flow_del(pmd, flow); - } - } -} - static struct dp_netdev_flow * mark_to_flow_find(const struct dp_netdev_pmd_thread *pmd, const uint32_t mark) @@ -5524,7 +5512,6 @@ reload_affected_pmds(struct dp_netdev *dp) CMAP_FOR_EACH (pmd, node, &dp->poll_threads) { if (pmd->need_reload) { - flow_mark_flush(pmd); dp_netdev_reload_pmd__(pmd); } }