diff mbox series

[ovs-dev,2/3] dpif-netlink: fix report_loss() message

Message ID 20210630095611.817982-3-mark.d.gray@redhat.com
State Superseded
Headers show
Series dpif-netlink: Introduce per-cpu upcall dispatching | expand

Checks

Context Check Description
ovsrobot/apply-robot success apply and check: success

Commit Message

Mark Gray June 30, 2021, 9:56 a.m. UTC
Fixes: 1579cf677fcb ("dpif-linux: Implement the API functions to allow multiple handler threads read upcall.")
Signed-off-by: Mark Gray <mark.d.gray@redhat.com>
---

Notes:
    v1 - Reworked based on Flavio's comments:
         * Added "Fixes" tag

 lib/dpif-netlink.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Flavio Leitner July 1, 2021, 7:59 p.m. UTC | #1
On Wed, Jun 30, 2021 at 05:56:10AM -0400, Mark Gray wrote:
> Fixes: 1579cf677fcb ("dpif-linux: Implement the API functions to allow multiple handler threads read upcall.")
> Signed-off-by: Mark Gray <mark.d.gray@redhat.com>
> ---

Acked-by: Flavio Leitner <fbl@sysclose.org>
Thanks Mark!
fbl
diff mbox series

Patch

diff --git a/lib/dpif-netlink.c b/lib/dpif-netlink.c
index 73d5608a81a2..f92905dd83fd 100644
--- a/lib/dpif-netlink.c
+++ b/lib/dpif-netlink.c
@@ -4666,7 +4666,7 @@  report_loss(struct dpif_netlink *dpif, struct dpif_channel *ch, uint32_t ch_idx,
                       time_msec() - ch->last_poll);
     }
 
-    VLOG_WARN("%s: lost packet on port channel %u of handler %u",
-              dpif_name(&dpif->dpif), ch_idx, handler_id);
+    VLOG_WARN("%s: lost packet on port channel %u of handler %u%s",
+              dpif_name(&dpif->dpif), ch_idx, handler_id, ds_cstr(&s));
     ds_destroy(&s);
 }